Planning for ledger 3.2

[Martin Michlmayr]

I think it's time to start planning for a ledger 3.2 release.

Dimitri John Ledkov has recently completed the port of the Python API
to Python 3, which is something Alexis started a long time ago.
Python 2 support is ending in 2020, and lack of Python 3 support is
already a problem for some distros.

There are still some issues left with Python 3 support (some tests
fail).

I'd like to start by gathering a list of issues that need to be
addressed before 3.2 can be shipped.

I added a 3.2 milestone on GitHub and tagged a few issues:
https://github.com/ledger/ledger/milestone/3

However, I should note that not all of these are strictly necessary
for 3.2. I tagged some issues that would be nice to resolve but that
aren't crucial. I might remove the milestone from some again.

Some of them are build issues, which may have already been resolved
but someone needs to confirm so. Some are (small) licensing issues
that would be good to resolve.

Anyway, I'm hoping everything can help:
- point out issues that should be fixed before 3.2. I'm talking
about *critical* stuff
- help fix as many things as possible
- test Python3 support and report issues

Thanks!
--
Martin Michlmayr
https://www.cyrius.com/

[John Wiegley]

>>>>> "MM" == Martin Michlmayr <t...@cyrius.com> writes:

MM> Anyway, I'm hoping everything can help:
MM> - point out issues that should be fixed before 3.2. I'm talking
MM> about *critical* stuff
MM> - help fix as many things as possible
MM> - test Python3 support and report issues

Thank you, Martin! I would love to help with this effort, though I may need to
pair up with you to keep other distractions at bay!

John

[psionl0]

I would like to see formatted output (coloured text, paging etc) made on an opt-in basis rather than an opt-out basis.

This is supposed to be a text based reporting system and all of the formatting characters play havoc on text based editors.

[John Wiegley]

>>>>> "p" == psionl0 <gsc...@iinet.net.au> writes:

p> This is supposed to be a text based reporting system and all of the
p> formatting characters play havoc on text based editors.

In ~/.ledgerrc you can put:

--no-color

John

[psionl0]

On Friday, December 13, 2019 at 12:23:47 AM UTC+8, John Wiegley wrote:

In ~/.ledgerrc you can put:

  --no-color

John

That's my point. In ~/.ledgerrc it should be

  --color
  --pager

I expected this to be a text based program. After the nasty formatting surprises, I had to research how to strip all of these formatting characters out of the output stream. Otherwise, it is useless if I want to feed the output into another display program.

[Yuri Khan]

On Sat, 14 Dec 2019 at 08:33, psionl0 <gsc...@iinet.net.au> wrote:

> I expected this to be a text based program. After the nasty formatting surprises, I had to research how to strip all of these formatting characters out of the output stream. Otherwise, it is useless if I want to feed the output into another display program.

I just tried this:

$ ledger balance
(got a colorful report in pager)

$ ledger balance|cat
(got a plain report, no pager)

which shows that if you feed the output to another program, it skips
formatting. (My .ledgerrc does not mention either --color or --pager.)

[psionl0]

Does it work for all piping commands?

I shouldn't have to research how to output unformatted text. Let those who want special formatting include those options in their command line.

[Michael Cooper]

Hey psion,

Every well behaving command line app should only use color at interactive colors that can render them. If you are seeing raw formatting codes, I think we can all agree there is a problem somewhere. It would be great if you could give some specific examples of times this goes wrong.

In the meantime, this is pretty far off topic for the thread. Can you move this troubleshooting elsewhere, perhaps a GitHub issue or another thread? Martin asked for *critical bugs* that would prevent a release. I don't think changing the intended behavior of the program fits into that category.

Thank,

-Mythmon

On Sun, Dec 15, 2019, 22:57 psionl0 <gsc...@iinet.net.au> wrote:

Does it work for all piping commands?

I shouldn't have to research how to output unformatted text. Let those who want special formatting include those options in their command line.

--

---
You received this message because you are subscribed to the Google Groups "Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ledger-cli+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ledger-cli/a04c8f73-1568-43e4-8307-ad2ae22be19a%40googlegroups.com.

[Martin Michlmayr]

* Martin Michlmayr <t...@cyrius.com> [2019-12-10 15:21]:

> Dimitri John Ledkov has recently completed the port of the Python API
> to Python 3, which is something Alexis started a long time ago.
> Python 2 support is ending in 2020, and lack of Python 3 support is
> already a problem for some distros.
>
> There are still some issues left with Python 3 support (some tests
> fail).

Andy Clayton has fixed the remaining issues in the meantime.

It looks like Python 3 support is ready now.

> Anyway, I'm hoping everything can help:
> - point out issues that should be fixed before 3.2. I'm talking
> about *critical* stuff
> - help fix as many things as possible
> - test Python3 support and report issues

Unfortunately I didn't get much response last time...

[Martin Michlmayr]

* Martin Michlmayr <t...@cyrius.com> [2020-03-27 15:01]:

> > Anyway, I'm hoping everything can help:
> > - point out issues that should be fixed before 3.2. I'm talking
> > about *critical* stuff
> > - help fix as many things as possible
> > - test Python3 support and report issues
>
> Unfortunately I didn't get much response last time...

Unfortunately still no reponse from anyone. I think it's time to
make a ledger 3.2 release in a few days from current Git. Python 2
is officially dead now and the lack of Python 3 support is a major
problem for the Linux distros.

If there are any major issues with the current master on GitHub,
please shout.

[John Wiegley]

>>>>> "MM" == Martin Michlmayr <t...@cyrius.com> writes:

MM> Unfortunately still no reponse from anyone. I think it's time to make a
MM> ledger 3.2 release in a few days from current Git. Python 2 is officially
MM> dead now and the lack of Python 3 support is a major problem for the Linux
MM> distros.

MM> If there are any major issues with the current master on GitHub, please
MM> shout.

Works for me.

John