Resource Customizations for Argo-CD

174 views
Skip to first unread message

Chandler Wilkerson

unread,
Sep 7, 2021, 3:09:50 PM9/7/21
to kubevirt-dev
Hello all,
I have created an issue [1] and a PR [2] to Argo Project's Argo-CD to support adding health checks for KubeVirt custom resources, specifically VM, VMI, and CDI's DV.

This makes it possible to more accurately reflect the state of VMs and DataVolumes within ArgoCD's sync loop (and provides nice information in the UI).

For example, without the health check, a VM is considered healthy as soon as the manifest is applied to Kubernetes, regardless of whether there is an actual VMI running, scheduled, or unschedulable.

I would appreciate some reviews from the KubeVirt community. The goal here is not to be completely exhaustive in our edge case coverage, but to cover the major reasons why a synchronization may not be considered complete.

Thanks!

--
Chandler Wilkerson, RHCE, CKA
Sr. Software Engineer

Red Hat

Zvi Cahana

unread,
Sep 9, 2021, 7:44:32 AM9/9/21
to kubevirt-dev
Hi Chandler,
I've added several comments in the PR, please take a look.

Chandler Wilkerson

unread,
Sep 9, 2021, 12:20:45 PM9/9/21
to Zvi Cahana, kubevirt-dev
Thanks! Your comments were very helpful, I have a bit more coding to do and test cases to create.

--
You received this message because you are subscribed to the Google Groups "kubevirt-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubevirt-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kubevirt-dev/87114150-a079-4623-bcd0-44bea3b64e73n%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages