Jan is out of office for 2 weeks

7 views
Skip to first unread message

Jan Safranek

unread,
Aug 31, 2018, 1:32:36 PM8/31/18
to kubernetes-sig-storage-wg-csi, Brad Childs, Hemant Kumar
Hi,

I am out of office for next 2 weeks, so I'd like to ask Brad and Hemant
to watch https://github.com/kubernetes/kubernetes/pull/67945 and
https://github.com/kubernetes/kubernetes/pull/67955 and rebase them /
fix review remarks and so on. You both can push to my Kubernetes fork on
github.

Namely, both need to be rebased when #67803 is merged as both my PRs
contain it as the 1st commit.

Jan

Saad Ali

unread,
Aug 31, 2018, 9:20:38 PM8/31/18
to kubernetes-sig-storage-wg-csi
Ok. Have a good vacation and thanks for all your work this release.

Brad and Hemant, the CSI registry change went in, so feel free to rebase.

Please note there is a follow up PR that is changing the workloads field (https://github.com/kubernetes/kubernetes/pull/68159/). Please also rebase the workload PR on that.

Let me know how I can help. Want to get these approved/lgtm'd ASAP. Reminder code freeze is Sept 4.

Hemant Kumar

unread,
Sep 4, 2018, 10:09:11 AM9/4/18
to Saad Ali, kubernetes-sig...@googlegroups.com
Thank you Jan.

Saad - I will take a look at them today and rebase and update them as necessary.



--
You received this message because you are subscribed to the Google Groups "kubernetes-sig-storage-wg-csi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-sig-stora...@googlegroups.com.
To post to this group, send email to kubernetes-sig...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-sig-storage-wg-csi/83c5e23a-7a01-4f65-8f0c-e879e0d62410%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Hemant Kumar

unread,
Sep 4, 2018, 4:56:00 PM9/4/18
to Saad Ali, Jan Safranek, Brad Childs, kubernetes-sig...@googlegroups.com
I pinged saad and brad but one problem is - both the PRs have WIP in their title. I have rebased one and I am about to update the other but I think WIP in title is still problematic and I can't update the title.


Saad Ali

unread,
Sep 4, 2018, 5:54:54 PM9/4/18
to Hemant Kumar, Jan Safranek, Brad Childs, kubernetes-sig-storage-wg-csi
I have permission to change the title -- so I removed WIP. Reminder that code freeze is EOD today -- PRs must be LGTM'd and approved by then to get in.
Reply all
Reply to author
Forward
0 new messages