Important and action Required: Update your pr description with issues

[Dawn Chen]

TL:DR: Please make sure your open pr description includes either a feature repo's issue or a main repo's issue by end of today. If you are already done with this, or don't care why your prs are not merged for 1.7 release, you can stop reading now.

The release team proposed the new policy: each pr should have an associated issue. We deployed the munge scripts earlier this afternoon, and there are 117 open prs affected by removing /approved label (many of them are not marked with 1.7 milestone).

The complete affected list is https://github.com/kubernetes/test-infra/issues/2868#issuecomment-306257592, which we collected through dry-run before the real deployment. 

 

You can stop reading now if you don't care how the release team process the affected prs.

In today's burndown meeting, the release team decided to shard triaging the PRs in above list to make the following decision for 1.7 release through the following process:

• ignore prs not marked with 1.7 milestone
• no /lgtm, not in list
• prs in 1.7 milestone and /lgtm (since /approved is removed by scripts), decide if 
• apply /approve if the pr is trivial, e.g. spelling fix
• ask authors to provide an issue if no issue present (add to spreadsheet) - no merging till issue provided.
• remove the pr from the milestone if the pr is stale (no activity from author, eg https://github.com/kubernetes/kubernetes/pull/41622 which was mistakenly included in 1.7 milestone), and no actions from the author since Feb.

How the release team shard the prs, please find the detail in Kubernetes 1.7 Burndown Meeting Notes. 

Thanks,

The release management team

[Garrett Rodrigues]

Quick Update:

A few volunteers reviewed the 117 PRs in the milestone and verified that 

1. If they are a feature, they were LGTMed prior to code freeze
2. They are relevant to the milestone (not last touched months ago)
3. They have an associated issue (assuming they are not very small, trivial PRs)

PRs not meeting these criteria were removed from the milestone or asked for additional updates (e.g. Ask the PR author reference the issue in the PR body).

Thanks,

Garrett

--
You received this message because you are subscribed to the Google Groups "Kubernetes developer/contributor discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-dev+unsubscribe@googlegroups.com.
To post to this group, send email to kubernetes-dev@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-dev/CAJo%3DGk7EeNaBvrK7hiGaYxmcYvHanP9hDbvEMhC3r2y%3DjCjXMw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--

Garrett 

[Ihor Dvoretskyi]

Great job, team.

One note:

> If they are a feature, they were LGTMed prior to code freeze

I would propose to establish a special policy for this sort of PR's/issues to keep them visible at the features repo as well.

Also, "feature" or "new feature" label can be a good start for the beginning.

On Tue, Jun 6, 2017 at 10:55 PM, 'Garrett Rodrigues' via Kubernetes developer/contributor discussion <kuberne...@googlegroups.com> wrote:

Quick Update:

A few volunteers reviewed the 117 PRs in the milestone and verified that 

1. If they are a feature, they were LGTMed prior to code freeze
2. They are relevant to the milestone (not last touched months ago)
3. They have an associated issue (assuming they are not very small, trivial PRs)

PRs not meeting these criteria were removed from the milestone or asked for additional updates (e.g. Ask the PR author reference the issue in the PR body).

Thanks,

Garrett

On Mon, Jun 5, 2017 at 4:00 PM, 'Dawn Chen' via Kubernetes developer/contributor discussion <kubernetes-dev@googlegroups.com> wrote:

TL:DR: Please make sure your open pr description includes either a feature repo's issue or a main repo's issue by end of today. If you are already done with this, or don't care why your prs are not merged for 1.7 release, you can stop reading now.

The release team proposed the new policy: each pr should have an associated issue. We deployed the munge scripts earlier this afternoon, and there are 117 open prs affected by removing /approved label (many of them are not marked with 1.7 milestone).

The complete affected list is https://github.com/kubernetes/test-infra/issues/2868#issuecomment-306257592, which we collected through dry-run before the real deployment. 

 

You can stop reading now if you don't care how the release team process the affected prs.

In today's burndown meeting, the release team decided to shard triaging the PRs in above list to make the following decision for 1.7 release through the following process:

• ignore prs not marked with 1.7 milestone
• no /lgtm, not in list
• prs in 1.7 milestone and /lgtm (since /approved is removed by scripts), decide if 
• apply /approve if the pr is trivial, e.g. spelling fix
• ask authors to provide an issue if no issue present (add to spreadsheet) - no merging till issue provided.
• remove the pr from the milestone if the pr is stale (no activity from author, eg https://github.com/kubernetes/kubernetes/pull/41622 which was mistakenly included in 1.7 milestone), and no actions from the author since Feb.

How the release team shard the prs, please find the detail in Kubernetes 1.7 Burndown Meeting Notes. 

Thanks,

The release management team

--
You received this message because you are subscribed to the Google Groups "Kubernetes developer/contributor discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-dev+unsubscribe@googlegroups.com.

To post to this group, send email to kuberne...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-dev/CAJo%3DGk7EeNaBvrK7hiGaYxmcYvHanP9hDbvEMhC3r2y%3DjCjXMw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--

Garrett 

--
You received this message because you are subscribed to the Google Groups "Kubernetes developer/contributor discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-dev+unsubscribe@googlegroups.com.
To post to this group, send email to kubernetes-dev@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-dev/CAJHQGQiPEM7k6q0%3Dzdz27y9%2BqEj5KFUMNos8vq-R86%3DnYa1dqw%40mail.gmail.com.