Can Krome be used with Enzo star formation?

70 views
Skip to first unread message

Joseph Smidt

unread,
Jul 4, 2018, 4:27:44 PM7/4/18
to KROMEusers
Hello,

   If I compile Krome like: 

./krome -enzo -compact -cooling ATOMIC,H2,Z -n networks/react_primordial3 -useTabs

Then I can run Enzo just fine without star formation with these cooling parameters activated in Enzo like:

RadiativeCooling            = 1
MultiSpecies                = 2
MetalCooling = 1

But if I turn on star formation in Enzo such as:

StarParticleCreation = 2
StarParticleFeedback = 2

I get immediate segmentation faults.  I then tried to add "-stars" to Krome by:

./krome -enzo -compact -cooling ATOMIC,H2,Z -n networks/react_primordial3 -useTabs -stars

which seems to run just fine.  But as soon as I run ./kromebuild.sh, I get this error:


-------

[jsmidt@gr-fe3 krome_enzo_patch]$ ./kromebuild.sh 
copying Grid_SolveRateAndCoolEquations.C
copying Grid_IdentifySpeciesFieldsKrome.C
copying InitializeRateData.C
build using ifort -c -O3
building opkda2.F
building opkda1.F
building opkdamain.F
building krome_user_commons.F90
building krome_all.F90
krome_all.F90(3422): error #6631: A non-optional actual argument must be present when invoking a procedure with an explicit interface.   [Z2]
    scr12 = stars_screen(Tgas,rho,n(:), zz(arr_r1(25)), zz(arr_r2(25)))
------------^
krome_all.F90(3422): error #8284: If the actual argument is scalar, the dummy argument shall be scalar unless the actual argument is of type character or is an element of an array that is not assumed shape, pointer, or polymorphic.   [ZZ]
    scr12 = stars_screen(Tgas,rho,n(:), zz(arr_r1(25)), zz(arr_r2(25)))
------------^
krome_all.F90(3422): error #6634: The shape matching rules of actual arguments and dummy arguments have been violated.   [ZZ]
    scr12 = stars_screen(Tgas,rho,n(:), zz(arr_r1(25)), zz(arr_r2(25)))
----------------------------------------^
krome_all.F90(3423): error #6631: A non-optional actual argument must be present when invoking a procedure with an explicit interface.   [Z2]


-------


So two questions:

1. Do I need to compile with the "-stars" option to run with star formation in Enzo?  If so, any ideas why ./kromebuild.sh is not working?

2. If  "-stars" is not needed, do I need to do something else to run with star formation on in Enzo?  Thanks. 




Stefano Bovino

unread,
Jul 6, 2018, 9:07:25 AM7/6/18
to Joseph Smidt, KROMEusers
Dear Joseph,

the -stars option in krome is related to different things and has nothing to do with SF.

If Enzo does not work when switching on star formation which I think you mean a sub grid model and sinks (perhaps), it means that it is not coupled with the chemistry or in this case with KROME. 

When we prepared the patch for Enzo we never tried to use this with sinks or with any other specific routines for star formation. So I think you have to dig into Enzo and try to see how this is coupled with Enzo chemistry and do the same with Krome.
This is something where we can’t help at the moment because you would have to work on the Enzo side.

Hope this helps.

In addition, I also noticed that you are using the option Z with a primordial network, this is wrong because Z requires metals in the network as it refers to non-equilibirum metal cooling.
If you want equilibrium metal cooling then you have to switch on the option ZCIE. Check it on our wiki or type ./krome -h to see which options are available.

Cheers,

Stefano

--
You received this message because you are subscribed to the Google Groups "KROMEusers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kromeusers+...@googlegroups.com.
To post to this group, send email to krome...@googlegroups.com.
Visit this group at https://groups.google.com/group/kromeusers.
To view this discussion on the web visit https://groups.google.com/d/msgid/kromeusers/f2125ce1-a749-4d29-a2ae-f7f5e9532624%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Joseph Smidt

unread,
Jul 6, 2018, 9:21:22 AM7/6/18
to poet...@gmail.com, krome...@googlegroups.com
Thank you.
--
------------------------------------------------------------------------
Joseph Smidt <josep...@gmail.com>

Theoretical Division
P.O. Box 1663, Mail Stop B283
Los Alamos, NM 87545
Office: 505-665-9752
Fax: 505-667-1931
Reply all
Reply to author
Forward
0 new messages