Small bugs in Krome

21 views
Skip to first unread message

Valentin Mauerhofer

unread,
Sep 3, 2018, 8:23:54 AM9/3/18
to KROMEusers

Hello,


I am a relatively new user of Krome, and I'd like to thank you for your work, it's a great software !

I noticed two very small bugs :


-Apparently the element "Boron" doesn't work, if I create a network with the element "B", it says "Unknown subelements in substring "B"."


-When I have an element with charge 11, like Si+++++++++++, there is a bug in "krome_subs.f90".  In the subroutine "conserveLin_x", it is written

1x(idx_SIjjjjjjjjjjj) / m(idx_SIjjjjjjjjjjj)

instead of

11d0*x(idx_SIjjjjjjjjjjj) / m(idx_SIjjjjjjjjjjj)

And so the code doesn't compile.


Do you know if I can easily fix those bugs, or maybe could you fix them and upload the correction on github ?


Thanks a lot,

Have a nice week,


Valentin Mauerhofer

Tommaso Grassi

unread,
Sep 3, 2018, 8:43:26 AM9/3/18
to Valentin Mauerhofer, KROMEusers
Hi Valentin,

thanks for using KROME.

I should have fixed the two bugs with the last commit 32bd799. Please check if everything works.

cheers,
-tg

--
You received this message because you are subscribed to the Google Groups "KROMEusers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kromeusers+...@googlegroups.com.
To post to this group, send email to krome...@googlegroups.com.
Visit this group at https://groups.google.com/group/kromeusers.
To view this discussion on the web visit https://groups.google.com/d/msgid/kromeusers/31f7a40a-060e-4356-b52c-e87a2939f462%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

tommaso grassi

unread,
Sep 3, 2018, 8:44:13 AM9/3/18
to KROMEusers
Hi Valentin,

thanks for using KROME.

I should have fixed the two bugs with the last commit 32bd799. Please check if everything works.

cheers,
-tg
Reply all
Reply to author
Forward
0 new messages