Contributing

[Yagamy Light]

Hello! Is it possible to contribute to the project? The http://libcode.org/ unless I misunderstand something seems to be an invite-only site, there's no way to register there.

[Yagamy Light]

Hi everyone! I've talked to our managers, and since contributing to the libcode.org is not possible, we forked the klish on github. Contributions are accepted here https://github.com/npobaum/

It is worth noting though: currently klish project can't be built on master (i.e. the master is broken in http://libcode.org/  repo too), so we develop on npobaum-2.2.0 branch that is based on 2.2.0. I didn't look yet what's up with the master, but I saw it has just 5-6 commits in comparison to 2.2.0, so once I'll finish the task I am working on, I might try to bisect and revert the offending commit. But fixes to master are welcome too of course.

[Serj Kalichev]

It's your right to fork klish but don't misinform community! Contributing is possible. This mailing list can be used for contributing.

Klish has a stable branch 2.2 (old klish) and "master" branch for new rewritten klish. New klish is not working yet. It's based on "faux" library.

Old stable klish doesn't need libfaux.

22.12.2020 18:08, Yagamy Light пишет:

--
You received this message because you are subscribed to the Google Groups "klish-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to klish-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/klish-dev/78722a30-8a42-4fbd-a29f-0a1523ad3772n%40googlegroups.com.

[Yagamy Light]

On Wednesday, 23 December 2020 at 10:35:57 UTC+3 Сергей Каличев wrote:

It's your right to fork klish but don't misinform community! Contributing is possible. This mailing list can be used for contributing.

Sorry, I didn't have any intention to misinform anyone. It isn't obvious that contributions are accepted on ML. Given the project has a full-blown git-forge with ability for stuff like pull-requests, this is unusual. And in any case docs did not mention possibility to contribute at all.

I see you have now added to the project page a new paragraph "Contributing". Thanks, I'll send patches here then.

 

Klish has a stable branch 2.2 (old klish) and "master" branch for new rewritten klish. New klish is not working yet. It's based on "faux" library.

Old stable klish doesn't need libfaux.

Oh, I didn't know that. At some point I confused someone's fork on github with klish, and I remember build there required faux (I have probably built from master before master broke), so I did some changes to faux as well.

Btw, while at it: I'm wondering if it's worth adding to faux project description also a paragraph "Contributing" with a link to an ML?

[Serj Kalichev]

Homepage was updated.
README files within master branch and 2.2 branch were updated.

23.12.2020 11:19, Yagamy Light пишет:

[Hi-Angel]

On Wed, 23 Dec 2020 at 12:02, Serj Kalichev <serj.k...@gmail.com> wrote:
>
> Homepage was updated.
> README files within master branch and 2.2 branch were updated.

Thanks! However, now that I look at the homepage, I see you only added
a paragraph for a discussion ML. Not a "where to contribute"
paragraph. If contributions are meant to be sent to the discussion
group, this is worth mentioning explicitly, because it is unusual
(usually ML-based projects have a dedicated ML for development
discussions and patches).

[Hi-Angel]

…and also because you have a git-forge site with abilities for
creating PRs, which will also confuse people. I know because I was
confused.

[Serj Kalichev]

Text from current main page:

"
Contributing

Use klish mailing list http://groups.google.com/group/klish-dev to send patches.
The best practice is to use "git format-patch" to format patch and "git send-email" to send it. It's great when the patch (or email) contain description for patch.

"

Is it good enough? Are you talking about this text?

23.12.2020 12:19, Hi-Angel пишет:

[Hi-Angel]

On Wed, 23 Dec 2020 at 13:33, Serj Kalichev <serj.k...@gmail.com> wrote:
>
> Text from current main page:
> "
> Contributing
>
> Use klish mailing list http://groups.google.com/group/klish-dev to send patches.
> The best practice is to use "git format-patch" to format patch and "git send-email" to send it. It's great when the patch (or email) contain description for patch.
>
> "
>
> Is it good enough? Are you talking about this text?

I think there is a bit of confusion: in the quoted paragraph I was
talking about `faux` project :)

I.e.:

> Homepage was updated.
> README files within master branch and 2.2 branch were updated.
>

[Serj Kalichev]

Ok, I see. I'll fix it later

23.12.2020 14:03, Hi-Angel пишет: