multi-arch image of kiali - PR needs review
4 views
Skip to first unread message
John Mazzitelli
Nov 16, 2020, 10:22:37 AM11/16/20
to kiali-dev
A community member submitted a PR to enable the building/pushing of a multi-arch docker image of Kiali using docker buildx.
https://github.com/kiali/kiali/pull/3405
I went through a series of reviews with the submitter of the PR and things are at a point where I would like to ask others to review and give your thoughts.
It only affects our Makefile - new targets are added, so it doesn't effect any existing targets in use today.
The idea is you run:
make build-linux-multi-arch container-multi-arch-push-kiali-quay
And up on quay.io gets an image that apparently supports multiple architectures (actually, I believe multiple images gets pushed to quay.io, but I'm not sure; it didn't fully run for me on my laptop because my laptop is only able to build amd64 - it doesn't support multiple arch building.)
This does NOT affect the operator - there is no multi-arch image for the operator yet. I'll assume that would be something that would be needed as followup work.
https://github.com/kiali/kiali/pull/3405
I went through a series of reviews with the submitter of the PR and things are at a point where I would like to ask others to review and give your thoughts.
It only affects our Makefile - new targets are added, so it doesn't effect any existing targets in use today.
The idea is you run:
make build-linux-multi-arch container-multi-arch-push-kiali-quay
And up on quay.io gets an image that apparently supports multiple architectures (actually, I believe multiple images gets pushed to quay.io, but I'm not sure; it didn't fully run for me on my laptop because my laptop is only able to build amd64 - it doesn't support multiple arch building.)
This does NOT affect the operator - there is no multi-arch image for the operator yet. I'll assume that would be something that would be needed as followup work.
Caina Costa
Nov 17, 2020, 9:46:58 PM11/17/20
to John Mazzitelli, kiali-dev
I added a comment there. Tested here, built went well, everything seems ok. Have not tested the generated images, of course.
--
You received this message because you are subscribed to the Google Groups "kiali-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kiali-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kiali-dev/7946981.24698633.1605540151537.JavaMail.zimbra%40redhat.com.
Reply all
Reply to author
Forward
0 new messages