Bunch of straightforward pull requests

11 views
Skip to first unread message

Réda Housni Alaoui

unread,
Apr 17, 2021, 10:18:52 AM4/17/21
to Keycloak Dev
Hi everyone,

According to the contribution guideline we can use the mailing list to ping for PR review. So here I am :)

Here is a bunch of (IMO) easy low hanging pull requests waiting (for quite some time) for review:
- freemarker sanitizer css rule relaxation: https://github.com/keycloak/keycloak/pull/7757
- brute force protection performance enhancement: https://github.com/keycloak/keycloak/pull/7748

Have a nice weekend

Stian Thorgersen

unread,
Apr 21, 2021, 4:48:37 AM4/21/21
to Réda Housni Alaoui, Keycloak Dev
On Sat, 17 Apr 2021 at 16:19, Réda Housni Alaoui <alaou...@gmail.com> wrote:
Hi everyone,

According to the contribution guideline we can use the mailing list to ping for PR review. So here I am :)

Here is a bunch of (IMO) easy low hanging pull requests waiting (for quite some time) for review:

We need a review from the community for any translation updates, could you send an email to this ML asking for someone to review it?
 
- freemarker sanitizer css rule relaxation: https://github.com/keycloak/keycloak/pull/7757

We can't accept this for security reasons.
 
- brute force protection performance enhancement: https://github.com/keycloak/keycloak/pull/7748

Looks okay to me, but needs a bit more investigation so we will review it properly when we have capacity.
 

Have a nice weekend

--
You received this message because you are subscribed to the Google Groups "Keycloak Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to keycloak-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/keycloak-dev/6b3b61d8-f66b-4bd9-a877-604172cd3faan%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages