Bug Report - Apache Toree Scala Kernal and "run all above"

[Mike Morton]

Hi Jupyter Team! Great to meet many of you at JupyterCon ;)

As many of you know we have implemented web-executable notebooks in Safari and O'Reilly (which we call "Orioles")

There is a "feature" where if you run a cell out of order and an execution error appears, a "Run All Above" button appears.

This works great with all of the kernels we have used so far, except for the Apache Toree Kernel. 

We believe this is specific to this kernel, and are wondering if anyone can investigate if there is some sort of missing hook?

Happy to provide more info - these notebooks/Orioles are behind a paywall, but I can provide access for a demonstration where requested.

An example of how we are seeing *most* kernels work is:

https://www.oreilly.com/learning/perform-sentiment-analysis-with-lstms-using-tensorflow

Skip down to the cell: "ids = np.load('idsMatrix.npy')" and run it - you will get an error (don't execute cells above it) and you will see the "Run All Above" button. This is the expected behaviour. (you can download the notebook here: https://github.com/adeshpande3/LSTM-Sentiment-Analysis)

With any notebooks running the toree kernel (apache_toree_scala) wee are not seeing that run all. The only difference between notebooks (in our system ) is the kernel - which is why I am leaning towards that being the issue.

TIA!

[Thomas Kluyver]

I'd make an educated guess that Toree is not signalling errors in the way you expect. There are (unfortunately, IMO) two ways to indicate that an error occurred:

- An error message on the iopub channel

- An error status in the execute_reply message on the shell channel

Kernels should use both, but it's easy for them to only use one. I hope to simplify it in a future version of the message spec.

It's also possible that it just displays an error message without sending any machine-readable indication that it's an error.

--
You received this message because you are subscribed to the Google Groups "Project Jupyter" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jupyter+unsubscribe@googlegroups.com.
To post to this group, send email to jup...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/f5355cf0-390e-4c6b-b84f-06083820b84c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Robert Schroll]

On Sep 26 2017, at 10:08 am, Thomas Kluyver <tak...@gmail.com> wrote: 

I'd make an educated guess that Toree is not signalling errors in the way you expect.

I can confirm that the Toree kernel does not signal errors properly.  I don't know what exactly it does wrong, but the notebook doesn't get outputs of type "error" after problems occur.  Instead the stack traces appear in a standard output cell.

We ran into this problem in our notebook testing infrastruture.  Our solution was to search for "StackTrace" in the output cell, and assume that this indicated an error.  Maybe that would work for you?

Robert

[Mike Morton]

Great suggestions, that is a good starting point to look at...

I wonder if anyone would want to take a crack at fixing the messaging to work as-expected in the kernel?  I am going to poll for resources internally to have a look at it - but if anyone else wanted to take a crack at it too...

https://github.com/apache/incubator-toree

[Thomas Kluyver]

Has someone filed an issue on the Toree kernel to work out a proper fix from their side?

--
You received this message because you are subscribed to the Google Groups "Project Jupyter" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jupyter+unsubscribe@googlegroups.com.
To post to this group, send email to jup...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/local-24435c24-e78d%40nylas-mail.nylas.com.

[Luciano Resende]

Yes, please file an issue with the Toree kernel community:
https://issues.apache.org/jira/projects/TOREE

or bring it up on the dev list.

On Tuesday, September 26, 2017 at 10:33:05 AM UTC-7, takowl wrote:

Has someone filed an issue on the Toree kernel to work out a proper fix from their side?

On 26 September 2017 at 18:23, Robert Schroll <rob...@thedataincubator.com> wrote:

On Sep 26 2017, at 10:08 am, Thomas Kluyver <tak...@gmail.com> wrote: 

I'd make an educated guess that Toree is not signalling errors in the way you expect.

I can confirm that the Toree kernel does not signal errors properly.  I don't know what exactly it does wrong, but the notebook doesn't get outputs of type "error" after problems occur.  Instead the stack traces appear in a standard output cell.

We ran into this problem in our notebook testing infrastruture.  Our solution was to search for "StackTrace" in the output cell, and assume that this indicated an error.  Maybe that would work for you?

Robert

--
You received this message because you are subscribed to the Google Groups "Project Jupyter" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jupyter+u...@googlegroups.com.

To post to this group, send email to jup...@googlegroups.com.