New member

[ssnid...@gmail.com]

Hi all,

After working with the Jupyter Notebook for awhile, I noticed that there are a few accessibility issues that I would like to help fix. I work in IBM Accessibility Research as an Accessibility Engineer and  I hope to be a contributor to the project very soon.

Thank you,

Sharon Snider

[Matthias Bussonnier]

Hi Sharon !

Thanks a lot for reaching ! We would be really happy to have your experience on the subject and fix issues with accessibility. Many of us do not have the experience to know what should be be done. 

Feel free to open issue on https://github.com/jupyterlab/jupyterlab or https://github.com/jupyter/notebook and ask guidance if you need ! 

Thanks !

--
You received this message because you are subscribed to the Google Groups "Project Jupyter" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jupyter+unsubscribe@googlegroups.com.
To post to this group, send email to jup...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/114f6dab-e781-4d14-8c65-3b47b5ca1c1d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Carol Willing]

Hi Sharon,

Welcome. Here's a link to an open issue on the notebook repo about accessibility which you may find useful for historical context https://github.com/jupyter/notebook/issues/1801.

While I work primarily on the JupyterHub projects, I'm happy to answer questions about contributing so please do reach out to me and others via Gitter too.

Warmly,

Carol

Carol Willing

Research Software Engineer
Project Jupyter at Cal Poly State University, San Luis Obispo

@willingc on GitHub and @willingcarol on Twitter

will...@gmail.com and cawi...@calpoly.edu

Signature Strengths
Empathy - Relator - Ideation - Strategic - Learner

To unsubscribe from this group and stop receiving emails from it, send an email to jupyter+u...@googlegroups.com.

To post to this group, send email to jup...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/CANJQusX1ucyiCiiNHh5TdsCAvYFTkYAveupcbp6kF84tJhmYeg%40mail.gmail.com.

[ssnid...@gmail.com]

Hi Carol,

Is it better for me to add what I have found (along with the fix) to issue#1801 or create new issues? For example, there are changes that can be made to the templates tree.html and page.html (that I have tested) to resolve issues related to aria landmarks and roles, as well as updates to style.min.css to fix color contrast.

Thanks in advance,

Sharon

To unsubscribe from this group and stop receiving emails from it, send an email to jupyter+u...@googlegroups.com.
To post to this group, send email to jup...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/114f6dab-e781-4d14-8c65-3b47b5ca1c1d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Matthias Bussonnier]

I would open a new issue and reference #1801 from it. New issues tend to see more activity, and you will likely get more feedback on a new issue.

If you know the fixes and are familiar with git, you can also make a Pull request (it is ok if you don't).

Note that style.min.css is likely autogenerated, so we would have to track down how to make this changes in the right place ; though we can do this part of you can tell us how to change style.min.css.

Thanks ! 

To unsubscribe from this group and stop receiving emails from it, send an email to jupyter+unsubscribe@googlegroups.com.

To post to this group, send email to jup...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/6342c173-1673-459e-a5ea-d795df68be44%40googlegroups.com.

[ssnid...@gmail.com]

Hi Matthias,

I'm familiar with git, but I was a little concenred that after I installed Jupyter Notebook, I had to apply the fix to the files in 

/Applications/anaconda3/lib/python3.6/site-packages/notebook/ rather then my local git repository to actually see the updates in the browser. 

Should I just copy the changed files to my git repository first so I can submit a pull request? 

Thanks :-)

Thanks ! 

[Matthias Bussonnier]

Hi Sharon, 

Yes, you can copy the change over and submit a pull-request. What I would suggest after is to look at the following page that guide you to steps to simplify contibuting:

http://jupyter-notebook.readthedocs.io/en/stable/contributing.html?#setting-up-a-development-environment

In particular it will guide you through how to do a "developer install", that is to say teach python how to see your git repository as the place where the notebook is installed. 

This mean that changes you make there are automatically reflected in the application. If anything is unclear or if this page can be improved let us know and we'll update it. 

Thanks.

-- 

Matthias

To unsubscribe from this group and stop receiving emails from it, send an email to jupyter+unsubscribe@googlegroups.com.

To post to this group, send email to jup...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jupyter/72b8736b-f906-4a94-a157-a29ceb3ba7b1%40googlegroups.com.