Semantic change of RenderQuotedNames.ALWAYS in JOOQ 3.14.x?

Johannes Bühler

unread,

Nov 28, 2020, 6:59:30 AM11/28/20

to jOOQ User Group

After updating from JOOQ 3.13.6 to 3.14.4 the generated SQL for functions are now different and wrongly (""" instead of ") quoted for the RenderQuotedNames.ALWAYS setting.

3.13.6

Executing query :

SELECT "insert_build"("incoming_build" := ROW(CAST(? AS timestamp with time zone), ?, ?::"build_tool_type", ?, ?, ?))

3.14.4

Executing query :
SELECT """insert_build"""("incoming_build" := ROW(CAST(? AS timestamp with time zone), ?, ?::"build_tool_type", ?, ?, ?))

Changing the setting to RenderQuotedNames.EXPLICIT_DEFAULT_QUOTED solves the problem for us.

Has the semantic of RenderQuotedNames.ALWAYS changed since 3.14.x and is it safe to use RenderQuotedNames.EXPLICIT_DEFAULT_QUOTED instead - we use some explicit unquotedName() in our codebase.

Thanks

Johannes

BTW

I think the doc is wrong for the // Defaults to

Lukas Eder

unread,

Nov 30, 2020, 3:44:33 AM11/30/20

to jOOQ User Group

Hi Johannes,

Thanks for your message. Some improvements were implemented in this area. Can you please report a bug with details on how to reproduce this?

https://github.com/jOOQ/jOOQ/issues/new/choose

I can't see what doc error you're pointing at, I think your copy pasting didn't work...

Thanks,
Lukas

--
You received this message because you are subscribed to the Google Groups "jOOQ User Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jooq-user+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jooq-user/73f6b491-4123-422d-8758-640cafcb5fdan%40googlegroups.com.

Johannes Bühler

unread,

Nov 30, 2020, 4:54:23 PM11/30/20

to jOOQ User Group

Hi Lukas

Issue is filled: #11055 including a MCVE

Retrying copy pasting the error pointing to the documentation - I would expect that both values are the same.

Thanks!

Johannes

Lukas Eder

unread,

Dec 1, 2020, 2:58:46 AM12/1/20

to jOOQ User Group

Hi Johannes,

Thanks for the issue. I'll continue looking into it directly there.

The idea in the manual is to show any possible value, and the default as a comment. You wouldn't need to set the default...

Thanks,

Lukas

To view this discussion on the web visit https://groups.google.com/d/msgid/jooq-user/e0cf8e7f-663f-43d7-a48d-6f8efe1699bcn%40googlegroups.com.

Johannes Bühler

unread,

Dec 1, 2020, 4:31:01 AM12/1/20

to jooq...@googlegroups.com

Hi Lukas,

I read `Defaults to` wrongly. Makes sense as it is.

Thanks

Johannes

To view this discussion on the web visit https://groups.google.com/d/msgid/jooq-user/CAB4ELO4sL9zxjt1-6fj%2BV4azudJ6nxowDsq5EM3yAA%3DSTiYHSg%40mail.gmail.com.