Missing Configuration constructor in DefaultCloseableDSLContext

[Johannes Bühler]

In 3.14.x the DefaultCloseableDSLContext has been introduced and the DefaultDSLContext is not autocloseable anymore. We are using the Autoclosable capabilties within our tests to ensure a clean shutdown. In the previous JOOQ version 3.13.x we used the DSL.using(Configuration) api. Is there an Autoclosable equivalent in 3.14.x or is it planned to add a new constructor DefaultCloseableDSLContext(Configuration)? 

I am happy to create an Issue for that and provide a PR if that's the way to go.      

Thanks.

[Lukas Eder]

Hi Johannes,

Can you please show what you're doing (in code) and why you're expecting the things you're expecting? 

Thanks,

Lukas

--
You received this message because you are subscribed to the Google Groups "jOOQ User Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jooq-user+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jooq-user/38464b74-de2e-4f96-a9c3-56d39f5caff1n%40googlegroups.com.

[Johannes Bühler]

Hi Lukas,

I created a simplified example similar to what we have in our codebase. You can find the working example here. It basically narrows down to the usage of the spock.lang.@AutoCleanup usage as you can see in BaseDBTest.groovy Let me know if you need more details. 

Thanks

Johannes

To view this discussion on the web visit https://groups.google.com/d/msgid/jooq-user/CAB4ELO48q3ij3jNg5uF_ZuQ6yGRSqtx%2BD6%3DaZ8j7a5rM%2BP-dFw%40mail.gmail.com.

--

Johannes Bühler
Senior Software Engineer
Gradle
W. gradle.com

[Lukas Eder]

Hi Johannes,

But why do you need to clean it up? The whole point of this (incompatible) change is that people called close() on non-resourceful DSLContext instances all the time, like you're doing right now. Your cleanup call does not have any effect.

Maybe, the issue description of the change helps explain this?

https://github.com/jOOQ/jOOQ/issues/10512

Thanks,

Lukas

To view this discussion on the web visit https://groups.google.com/d/msgid/jooq-user/CAL_ciTLPTL4OJ8nOy%2BTcaCB-JnScZ5fp18Ja1U6ABe8KHZKyRQ%40mail.gmail.com.

[Johannes Bühler]

Hi Lukas, 

got it - I adjusted it on our side. 

Thanks for making that (breaking) change for the better. 👍  

Johannes

To view this discussion on the web visit https://groups.google.com/d/msgid/jooq-user/CAB4ELO4Gdt_mgqneDYE%2B4QmHvq4kvkngunrA2docPduCqXCJ_g%40mail.gmail.com.