Modules for Jooby 2.x

[István Mészáros]

Hi all,

we are currently using Jooby 1.x, and are really-really satisfied with it. Sooner or later we would like to migrate to Jooby 2.

Is there any plan or roadmap for migration of 1.x modules to 2.x? We use the following modules which are not available for 2.x, therefore we cannot migrate just yet:

• jooby-whoops
• jooby-banner
• jooby-commons-email
• jooby-pac4j2

The first two are just cosmetics, but the latter two are essential for us. I'd happy to help and migrate these modules and contribute them to Jooby 2! I guess only the migration of the PAC4J module would be not so straightforward... Maybe instead of PAC4J v2 Jooby 2.x could target PAC4J v4?

[Edgar Espina]

Hi,

  The first three (whoops, banner and commons-email) should be pretty easy to add them. I feel whoops must be part of jooby:run not something that you add to your application (similar thought about the livereload module).

  Pac4j is not necessarily super hard but requires a bit more of work and yes we should target latest version (v4).

 I will add them to the queue but better/quick if you send pull request for them.

[István Mészáros]

Hi Edgar,

as a warmup i started with the banner module.

Could you have a look on it?

I need to complete the test cases but otherwise it's kind of ready: https://github.com/imeszaros/jooby/commit/6977d84b2fc1bf69ebe16269f04aa5677a51ae79

Thanks in advance,

[Paul Hammant]

I wish that GitHub had a more advanced /compare/ feature that could make an elegant diff between your work and the last non-deleted banner sources (and nothing else). Otherwise, great work.

--
You received this message because you are subscribed to the Google Groups "jooby-project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jooby-projec...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jooby-project/4bea01d3-2478-4aa7-847a-356beae58dca%40googlegroups.com.

[István Mészáros]

Indeed. :) I tried to change as little as possible.

- I needed to drop in a replacement for Guava's CharMatcher

- Funzy's Try is not there anymore

- I extracted the font path generation as a package private method to be able to use it in tests

- In this version the module uses the logger provided by the Jooby app instead of getting an own instance, this way I can mock the log in tests

2019. augusztus 22., csütörtök 8:24:03 UTC+2 időpontban Paul Hammant a következőt írta:

I wish that GitHub had a more advanced /compare/ feature that could make an elegant diff between your work and the last non-deleted banner sources (and nothing else). Otherwise, great work.

On Thu, Aug 22, 2019 at 7:09 AM István Mészáros <contact....@gmail.com> wrote:

Hi Edgar,

as a warmup i started with the banner module.

Could you have a look on it?

I need to complete the test cases but otherwise it's kind of ready: https://github.com/imeszaros/jooby/commit/6977d84b2fc1bf69ebe16269f04aa5677a51ae79

Thanks in advance,

--
You received this message because you are subscribed to the Google Groups "jooby-project" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jooby-...@googlegroups.com.