Plugin micro site

[Thorsten Scherler]

Hi all,

let me introduce myself and the reason why I am writing to this list. 

I am Thorsten Scherler a long time user of Jenkins/Hudson at work and at Apache where I am still VP of Cocoon.

I have a long record of java programming but since 2 years I am doing exclusively node.js/react.js projects.

I saw https://wiki.jenkins-ci.org/display/JENKINS/Jenkins+2.0+Website+vision+from+Daniel+Beck and started working on a plugin micro site with Gus. As stated in the readme: "This is a simple rendering of the plugin list as taken from updates.jenkins-ci.org/current/update-center.json to make the information of plugins searchable and filterable." You can find the result in https://github.com/scherler/jenkins-plugin-site. I know it may not be the most popular architecture in java land but it works pretty good and I created a docker image so you can easily test it without installing node.js in your box.

I deployed an example, so it may easier for you to review the work, but just realised that there is a problem with the search form (will look into that after finishing this mail) besides the problem with the paginations css, so to try the search you need to use query parameters. e.g. http://plugin-site.stax.net/?q=git&limit=50

I would love to hear feedback from you whether you find it usable and think it is worth a contribution to Jenkins. If you think that it would be useful for the community but it needs some changes I am open for suggestions. Further I thought about introducing features like rating, commenting and sharing of plugins, but before spend more time on such features I would love to hear your opinion.

Regards Thor

[Kohsuke Kawaguchi]

This looks great. I have a few questions:

• What does the "All" button do? It doesn't do anything for me.
• Categories on the left --- is it related to Wiki labels? Probably not.
• What does the '+' mark in the card mean?
• Cards render HTML as plain text. For example, search for "PMD" and you see a bunch of <a> tags. HTML served from Update Center is vetted for XSS, so it's safe to just render those HTMLs. It really only allows a few formatting tags and hyperlinks.

Also, the core should define a mechanism to package an icon into a plugin, which I think would help an effort like this.

--
You received this message because you are subscribed to the Google Groups "Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-use...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/38ab7a6b-197c-436f-b9ff-9fa07b0634ba%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Kohsuke Kawaguchi

[Thorsten Scherler]

Hello Kohsuke,

thank you for your quick reply. :)

I uploaded a video, that explains the whole site a bit more, but a written summary may be better since I did not want to wake the family. 

https://youtu.be/YI5UI0fbhGY

On Wednesday, March 9, 2016 at 12:40:35 AM UTC+1, Kohsuke Kawaguchi wrote:

This looks great. I have a few questions:

• What does the "All" button do? It doesn't do anything for me.

We have currently 2 sections of "search" due to historic growth of the fetching of the initial plugin list. One is searching the list and the other filtering the current results you see. That said, you can apply e.g. a filter on "tags" to be "builder" this will filter the from the current search-result set and it is sticky. Meaning you switch to the next page you will only see plugins with the builder tag. To remove this filter you press all.

 

• Categories on the left --- is it related to Wiki labels? Probably not.

not yet, but IMO plugins should choose which category they belong to for now we have created

https://github.com/scherler/jenkins-plugin-site/blob/hotfix/searchbox/server/static/category-plugins.json

...but that is something that we could implement in the backend if we really persist the data and link it to additional data we collect from e.g. the author or user of the plugin via a web form.

 

• What does the '+' mark in the card mean?

I have to consult Gus. For me stands for up meaning bigger versions then that, but that is an educated guess.

• Cards render HTML as plain text. For example, search for "PMD" and you see a bunch of <a> tags. HTML served from Update Center is vetted for XSS, so it's safe to just render those HTMLs. It really only allows a few formatting tags and hyperlinks.

yeah, problem of the source. ;) ...but seriously, I tried with https://facebook.github.io/react/tips/dangerously-set-inner-html.html but that was not good for the overall design at all. React has the right on naming. ;) Problem are this un-closed <li> <div> <etc.> which are then temper the overall design. I am not sure about a good solution yet, but in apache cocoon I would have used https://cocoon.apache.org/2.1/userdocs/html-generator.html to get a valid html and then display it but yeah, have to thing to do similar thing before showing the description markup.

 

Also, the core should define a mechanism to package an icon into a plugin, which I think would help an effort like this.

+1 that would get rid of some code that I think is not our concern. 

salu2