[JIRA] (JENKINS-62184) Ownership based authorization preventing fallback authorizations from kicking in

[antoine.malliarakis@gmail.com (JIRA)]

Antoine Malliarakis updated an issue

Jenkins / JENKINS-62184 Ownership based authorization preventing fallback authorizations from kicking in Change By: Antoine Malliarakis Summary: Ownership based authorization falling back to anonymous when no ownership defined preventing fallback authorizations from kicking in Add Comment

This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)

[antoine.malliarakis@gmail.com (JIRA)]

Antoine Malliarakis edited a comment on JENKINS-62184

Re: Ownership based authorization preventing fallback authorizations from kicking in Looking at the code it seems that this issue would not be "that easy" to fix without introducing a breaking change. Indeed: if I fix this the way I thought it should be (e.g. by returning null if ownership is not defined), then, in cases where no fallback policy is defined a default one would be returned which would be system, instead of anonymous. To me this would make sense, though, but I'm no expert on this matter (I started playing with this plugin a few weeks ago so I cannot be considered as a "guru" here ;) ). If the option I saw is seen as acceptable, I would be glad to be making make the corresponding PR (with unit tests and so on).

Add Comment

[antoine.malliarakis@gmail.com (JIRA)]

Antoine Malliarakis commented on JENKINS-62184

Re: Ownership based authorization preventing fallback authorizations from kicking in

Looking at the code it seems that this issue would not be "that easy" to fix without introducing a breaking change. Indeed: if I fix this the way I thought it should be (e.g. by returning null if ownership is not defined), then, in cases where no fallback policy is defined a default one would be returned which would be system, instead of anonymous.

To me this would make sense, though, but I'm no expert on this matter (I started playing with this plugin a few weeks ago so I cannot be considered as a "guru" here  ). If the option I saw is seen as acceptable, I would be glad to be making the corresponding PR (with unit tests and so on).

Add Comment