[JIRA] (JENKINS-62079) No way to email just a PR's owner

12 views
Skip to first unread message

brian.murrell@intel.com (JIRA)

unread,
Apr 28, 2020, 10:43:03 AM4/28/20
to jenkinsc...@googlegroups.com
Brian J Murrell created an issue
 
Jenkins / Bug JENKINS-62079
No way to email just a PR's owner
Issue Type: Bug Bug
Assignee: Alex Earl
Components: email-ext-plugin
Created: 2020-04-28 14:42
Priority: Major Major
Reporter: Brian J Murrell

I can't seem to figure out any recipientProviders that contact just a (GitHub) PR's owner/author, in all cases.

In simple cases, where somebody creates a PR and pushes a few patches, developers seems like the right target.  But as soon as the PR owner merges with master, that becomes every patch owner in the merge also, correct?

Is there an option I am missing here to achieve what I am looking for?

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

slide.o.mix@gmail.com (JIRA)

unread,
Apr 28, 2020, 6:19:03 PM4/28/20
to jenkinsc...@googlegroups.com
Alex Earl commented on Bug JENKINS-62079
 
Re: No way to email just a PR's owner

I don't think I have access to that information. The GitHub plugin (if that is being used) might have that info and could implement their own RecipientProvider which could then be used in email-ext.

brian.murrell@intel.com (JIRA)

unread,
Apr 29, 2020, 8:35:03 AM4/29/20
to jenkinsc...@googlegroups.com

Yeah, I suspected email-ext wouldn't have access to GH info.  It's interesting that another plugin can implement a recipientProvider.

Is my observation correct about a PR that merges other patches into it, such as say, merging another (i.e. master) branch, the single owner of the primary patch of the PR is lost and there is no existing recipientProvider that will distinguish that owner (of the primary patch) on the PR from all of the owners of patches in the merge?

slide.o.mix@gmail.com (JIRA)

unread,
Apr 29, 2020, 12:33:04 PM4/29/20
to jenkinsc...@googlegroups.com

Jenkins is full of such extension points. It makes it very extendable. I do not know about the owner of the primary patch being lost, but there is no recipient provider that I know about that does what you want.

brian.murrell@intel.com (JIRA)

unread,
Apr 29, 2020, 1:27:03 PM4/29/20
to jenkinsc...@googlegroups.com

I do not know about the owner of the primary patch being lost

Not lost, but not identifiable as the single individual for which the patches in the PR belong, among the many authors of the perhaps many patches that got added from a merged branch (i.e. again, when say, merging master to a PR).

slide.o.mix@gmail.com (JIRA)

unread,
Apr 29, 2020, 1:36:03 PM4/29/20
to jenkinsc...@googlegroups.com

I don't know of any way to identify that from the email-ext plugin perspective. Which plugin are you using for SCM?

brian.murrell@intel.com (JIRA)

unread,
Apr 29, 2020, 1:55:02 PM4/29/20
to jenkinsc...@googlegroups.com

I am using the github-branch-source plugin with pipelines.

Ultimately the problem is that (AFAICT) the most useful recipientProvider to use with a single PR is:

developers

  • Sends email to all the people who caused a change in the change set.  

But as I mentioned before that list gets polluted with every author of every patch that was merged from a parent branch when doing a merge to get one's PR up-to-date with it's parent branch.

slide.o.mix@gmail.com (JIRA)

unread,
Apr 29, 2020, 6:39:02 PM4/29/20
to jenkinsc...@googlegroups.com

Correct, it looks through all of the changesets and grabs all the authors.

Reply all
Reply to author
Forward
0 new messages