[JIRA] (JENKINS-62074) Send build failure email to approver of pull request

8 views
Skip to first unread message

slahoti@bravurasolutions.com (JIRA)

unread,
Apr 27, 2020, 11:32:04 PM4/27/20
to jenkinsc...@googlegroups.com
Shivam Lahoti created an issue
 
Jenkins / New Feature JENKINS-62074
Send build failure email to approver of pull request
Issue Type: New Feature New Feature
Assignee: Unassigned
Components: mailer-plugin
Created: 2020-04-28 03:31
Priority: Minor Minor
Reporter: Shivam Lahoti

The "Send separate e-mails to individuals who broke the build" option sends emails to the commit's committers. However, there are cases when it's better to send emails to the commit's authors instead.

We use Gerrit for hosting our Git repositories and its workflow consists in pushing commits to pseudo-branches for review. After the commits have been approved they are submitted (integrated) automatically into the real branch, but this action is performed by Gerrit which may have to rebase the original commit in order to be able to tuck it on top of the current branch's HEAD. In these cases, the actual commit's committer becomes an administrative user. In our case we configured it to be a user called gerrit with an email like ger...@ourdomain.com.

So, for these commits it doesn's work to send notifications to the commit's committer. They should be sent to the commit's author instead.

What I propose is that there should exist another configuration option where we could specify a list of emails (a Regexp would also do). If the committer's email matches one of the emails specified, then the notifications should be sent to the commit's author instead.

This option should be subordinated to the "Send separate e-mails to individuals who broke the build" option.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

slahoti@bravurasolutions.com (JIRA)

unread,
Apr 27, 2020, 11:33:02 PM4/27/20
to jenkinsc...@googlegroups.com
Shivam Lahoti updated an issue
Change By: Shivam Lahoti
The "Send separate e-mails to individuals who broke the build" option sends emails to the commit's committers. However, there are cases when it's better to send emails to the commit's authors instead.

We use [Gerrit|https://www.gerritcodereview.com/] for hosting our Git repositories and its workflow consists in pushing commits to pseudo-branches for review. After the commits have been approved they are submitted (integrated) automatically into the real branch, but this action is performed by Gerrit which may have to rebase the original commit in order to be able to tuck it on top of the current branch's HEAD. In these cases, the actual commit's committer becomes an administrative user. In our case we configured it to be a user called *gerrit* with an email like *ger...@ourdomain.com*.


So, for these commits it doesn's work to send notifications to the commit's committer. They should be sent to the commit's author instead.

What I propose is that there should exist another configuration option where we could specify a list of emails (a Regexp would also do). If the committer's email matches one of the emails specified, then the notifications should be sent to the commit's author instead.

This option should be subordinated to the "Send separate e-mails to individuals who broke the build" option.

slahoti@bravurasolutions.com (JIRA)

unread,
Apr 27, 2020, 11:41:03 PM4/27/20
to jenkinsc...@googlegroups.com
Shivam Lahoti updated an issue
Change By: Shivam Lahoti
Issue Type: New Feature Improvement

slahoti@bravurasolutions.com (JIRA)

unread,
Apr 27, 2020, 11:51:02 PM4/27/20
to jenkinsc...@googlegroups.com
Shivam Lahoti updated an issue
Change By: Shivam Lahoti
Component/s: email-ext-plugin
Component/s: mailer-plugin

slahoti@bravurasolutions.com (JIRA)

unread,
Apr 27, 2020, 11:56:02 PM4/27/20
to jenkinsc...@googlegroups.com
Shivam Lahoti updated an issue
Currently the failure email goes to the developer and Build & Release team members but not to the approver.

In case the developer commits the change and then not available after that, the approver does not get to know about the failures unless someone manually contacts him/her.

slide.o.mix@gmail.com (JIRA)

unread,
Apr 28, 2020, 10:58:03 AM4/28/20
to jenkinsc...@googlegroups.com
Alex Earl commented on Improvement JENKINS-62074
 
Re: Send build failure email to approver of pull request

I don't believe I have access to anyone but the authors of commits via the API's available to me. So, I don't know how I would get that information.

Reply all
Reply to author
Forward
0 new messages