[JIRA] (JENKINS-62059) JabberIMConnectionProvider.createConnection() swallows Exceptions

[matthias.mueller@aiticon.com (JIRA)]

Matthias Müller created an issue

Jenkins / JENKINS-62059 JabberIMConnectionProvider.createConnection() swallows Exceptions Issue Type: Bug Assignee: Florian Schmaus Components: jabber-plugin Created: 2020-04-27 07:09 Environment: jabber: 1.38 Labels: jabber Priority: Minor Reporter: Matthias Müller Hi Florian Schmaus, this is a followup ticket to JENKINS-60193. While I was trying to find out why my connection didn't work, I came across this issue. When an XmppStringprepException occurs in JabberIMConnection(JabberPublisherDescriptor desc, AuthenticationHolder authentication), this exception is re-thrown as hudson.plugins.im.IMException. But in JabberIMConnectionProvider.createConnection(), only RuntimeExceptions are getting caught. So the log just tells me that the connection failed, but nut why it failed: h.p.j.i.t.JabberIMConnectionProvider#createConnection: Creating XMPP JabberIMConnection h.p.j.i.t.JabberIMConnectionProvider#createConnection: Connection failed So IMHO here Exception}}s should get caught here, not only {{RuntimeException. Regards Matthias Add Comment

This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)

[matthias.mueller@aiticon.com (JIRA)]

Matthias Müller updated an issue

Jenkins / JENKINS-62059 JabberIMConnectionProvider.createConnection() swallows Exceptions

Change By: Matthias Müller Hi [~flow],

this is a followup ticket to JENKINS-60193. While I was trying to find out why my connection didn't work, I came across this issue.

When an {{XmppStringprepException}} occurs in [JabberIMConnection(JabberPublisherDescriptor desc, AuthenticationHolder authentication)|https://github.com/jenkinsci/jabber-plugin/blob/1.38/src/main/java/hudson/plugins/jabber/im/transport/JabberIMConnection.java#L194], this exception is re-thrown as {{hudson.plugins.im.IMException}}. But in [JabberIMConnectionProvider.createConnection()|https://github.com/jenkinsci/jabber-plugin/blob/1.38/src/main/java/hudson/plugins/jabber/im/transport/JabberIMConnectionProvider.java#L72], only RuntimeExceptions are getting caught. So the log just tells me that the connection failed, but nut *why* it failed: {code} h.p.j.i.t.JabberIMConnectionProvider#createConnection: Creating XMPP JabberIMConnection h.p.j.i.t.JabberIMConnectionProvider#createConnection: Connection failed {code} So IMHO here {{Exception}} s should get caught here, not only {{RuntimeException}}. Regards Matthias

Add Comment

[flo@geekplace.eu (JIRA)]

Florian Schmaus commented on JENKINS-62059

Re: JabberIMConnectionProvider.createConnection() swallows Exceptions I had argued that the try/catch should be removed completely and any kind of exception should be handled by higher layers. So the issue is actually that IMConnectionProvider.create() of the jabber-im plugin, silently swallows the exception.

Add Comment

[flo@geekplace.eu (JIRA)]

Florian Schmaus commented on JENKINS-62059

Re: JabberIMConnectionProvider.createConnection() swallows Exceptions https://github.com/jenkinsci/instant-messaging-plugin/pull/40

Add Comment

[flo@geekplace.eu (JIRA)]

Florian Schmaus updated an issue

Jenkins / JENKINS-62059 JabberIMConnectionProvider.createConnection() swallows Exceptions

Change By: Florian Schmaus

Hi [~flow], this is a followup ticket to JENKINS-60193. While I was trying to find out why my connection didn't work, I came across this issue. When an {{XmppStringprepException}} occurs in [JabberIMConnection(JabberPublisherDescriptor desc, AuthenticationHolder authentication)|https://github.com/jenkinsci/jabber-plugin/blob/1.38/src/main/java/hudson/plugins/jabber/im/transport/JabberIMConnection.java#L194], this exception is re-thrown as {{hudson.plugins.im.IMException}}. But in [JabberIMConnectionProvider.createConnection()|https://github.com/jenkinsci/jabber-plugin/blob/1.38/src/main/java/hudson/plugins/jabber/im/transport/JabberIMConnectionProvider.java#L72], only RuntimeExceptions are getting caught. So the log just tells me that the connection failed, but nut *why* it failed:

{code :java }

h.p.j.i.t.JabberIMConnectionProvider#createConnection: Creating XMPP JabberIMConnection h.p.j.i.t.JabberIMConnectionProvider#createConnection: Connection failed {code}

So IMHO here {{Exception}} should get caught here, not only {{RuntimeException}}. Regards Matthias

Add Comment

[flo@geekplace.eu (JIRA)]

Florian Schmaus updated an issue

Jenkins / JENKINS-62059 JabberIMConnectionProvider.createConnection() swallows Exceptions

Change By: Florian Schmaus Component/s: instant-messaging-plugin Component/s: jabber-plugin

Add Comment

[flo@geekplace.eu (JIRA)]

Florian Schmaus started work on JENKINS-62059

Change By: Florian Schmaus Status: Open In Progress

Add Comment