[JIRA] (JENKINS-61718) Allow newer ADO services to work with the TFS plugin

0 views
Skip to first unread message

jenkins.io@jamesstapleton.com (JIRA)

unread,
Mar 27, 2020, 2:24:02 PM3/27/20
to jenkinsc...@googlegroups.com
James Stapleton created an issue
 
Jenkins / Improvement JENKINS-61718
Allow newer ADO services to work with the TFS plugin
Issue Type: Improvement Improvement
Assignee: redsolo
Components: tfs-plugin
Created: 2020-03-27 18:23
Environment: tfs-plugin: 5.157.1
Labels: plugin
Priority: Major Major
Reporter: James Stapleton

Right now it seems impossible to use the TFS plugin with a ADO (dev.azure.com) repository.  This seems like its because the plugin skips over the authentication piece for urls that host doesn't end with  `.visualstudio.com`.

That is because in the TeamRestClient constructor, it does:

 

if (isTeamServices && credentials != null) {
    authorization = createAuthorization(credentials);
}
else {
    authorization = null;
}

which then it doesn't send along the authorization that you configured in the jenkin's system configuration panel.

 

I made my own fix: https://github.com/jdstapleton/tfs-plugin/tree/fix-dev-azure

Then while looking at the pull requests, I saw a pretty identical pull request already: https://github.com/jenkinsci/tfs-plugin/pull/224

 

So the request of this ticket is that can the pull request 224 be merged and then deployed to Jenkin's plugin server.

 

 

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages