[JIRA] (JENKINS-61692) "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException

0 views
Skip to first unread message

thomas.patzig@etas.com (JIRA)

unread,
Mar 26, 2020, 9:15:03 AM3/26/20
to jenkinsc...@googlegroups.com
Thomas Patzig moved an issue
 
Jenkins / Bug JENKINS-61692
"HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException
Change By: Thomas Patzig
Project: Infrastructure Jenkins
Key: INFRA JENKINS - 2554 61692
Workflow: classic default workflow JNJira + In-Review
Component/s: core
Component/s: proxy
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

thomas.patzig@etas.com (JIRA)

unread,
Mar 26, 2020, 9:16:02 AM3/26/20
to jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
Change By: Thomas Patzig
Environment: Jenkins ver. 2.222.1
just plain Jenkins
no plugins

thomas.patzig@etas.com (JIRA)

unread,
Mar 26, 2020, 9:17:03 AM3/26/20
to jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
today I have test to deployed the latest LTS version: Jenkins ver. 2.222.1

as I want to configure my proxy it crashs directly on "Validate Proxy"


!screenshot-1.png|thumbnail!

before that new LTS version I use Jenkins ver. 2.204.5 were this working fine
!screenshot-2.png|thumbnail!
 
{code:java}
java.lang.NullPointerException
at hudson.util.Secret$1.convert(Secret.java:306)
at hudson.util.Secret$1.convert(Secret.java:304)
at org.kohsuke.stapler.AnnotationHandler.convert(AnnotationHandler.java:66)
at org.kohsuke.stapler.QueryParameter$HandlerImpl.parse(QueryParameter.java:74)
at org.kohsuke.stapler.QueryParameter$HandlerImpl.parse(QueryParameter.java:62)
at org.kohsuke.stapler.AnnotationHandler.handle(AnnotationHandler.java:91)
at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:204)
at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:145)
at org.kohsuke.stapler.MetaClass$11.doDispatch(MetaClass.java:535)
at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)
at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:747)
at org.kohsuke.stapler.Stapler.invoke(Stapler.java:878)
at org.kohsuke.stapler.MetaClass$4.doDispatch(MetaClass.java:280)
at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)
at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:747)
at org.kohsuke.stapler.Stapler.invoke(Stapler.java:878)
at org.kohsuke.stapler.Stapler.invoke(Stapler.java:676)
at org.kohsuke.stapler.Stapler.service(Stapler.java:238)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:755)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1617)
at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:154)
at jenkins.security.ResourceDomainFilter.doFilter(ResourceDomainFilter.java:76)
at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:151)
at jenkins.telemetry.impl.UserLanguages$AcceptLanguageFilter.doFilter(UserLanguages.java:128)
at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:151)
at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:157)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:153)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84)
at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:118)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at jenkins.security.BasicHeaderProcessor.doFilter(BasicHeaderProcessor.java:93)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249)
at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:90)
at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:171)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:49)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:82)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
at org.kohsuke.stapler.DiagnosticThreadNameFilter.doFilter(DiagnosticThreadNameFilter.java:30)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
at jenkins.security.SuspiciousRequestFilter.doFilter(SuspiciousRequestFilter.java:36)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:545)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:566)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1610)
at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1300)
at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:485)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1580)
at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1215)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at org.eclipse.jetty.server.Server.handle(Server.java:500)
at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:383)
at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:547)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:375)
at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:273)
at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:103)
at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:117)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:129)
at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:375)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806)
at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:938)
at java.lang.Thread.run(Unknown Source)
{code}

thomas.patzig@etas.com (JIRA)

unread,
Mar 26, 2020, 9:17:04 AM3/26/20
to jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
Change By: Thomas Patzig
Environment:
Jenkins ver. 2.222.1
just plain Jenkins
no plugins
user is an active directory user

thomas.patzig@etas.com (JIRA)

unread,
Mar 26, 2020, 9:19:02 AM3/26/20
to jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
today I have test to deployed the latest LTS version: Jenkins ver. 2.222.1

as I want to configure my proxy it crashs directly on "Validate Proxy"

user is an AD user, have already try:

us...@domain.tld
domain\user
user
=> same behavior

thomas.patzig@etas.com (JIRA)

unread,
Mar 26, 2020, 9:28:03 AM3/26/20
to jenkinsc...@googlegroups.com

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 26, 2020, 7:53:02 PM3/26/20
to jenkinsc...@googlegroups.com

o.v.nenashev@gmail.com (JIRA)

unread,
Mar 26, 2020, 7:59:02 PM3/26/20
to jenkinsc...@googlegroups.com
Oleg Nenashev commented on Bug JENKINS-61692
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException

There is no recent changes in Secret.java or Stapler which would cause that behavior AFAICT. I assume that the nll check is missing in the code, but I am not sure what causes it to be passed

static { 
  Stapler.CONVERT_UTILS.register(new org.apache.commons.beanutils.Converter() { 
    public Secret convert(Class type, Object value) { 
306:      return Secret.fromString(value.toString()); 
} }, Secret.class); }

dbeck@cloudbees.com (JIRA)

unread,
Mar 26, 2020, 9:07:03 PM3/26/20
to jenkinsc...@googlegroups.com

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 1:56:03 AM3/27/20
to jenkinsc...@googlegroups.com

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 1:56:03 AM3/27/20
to jenkinsc...@googlegroups.com
Thomas Patzig edited a comment on Bug JENKINS-61692
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException
have try to add system property
  <arguments>-Xrs -Xmx256m -Dhudson.lifecycle=hudson.lifecycle.WindowsServiceLifecycle -jar "%BASE%\jenkins.war" --httpPort=8081 -Dhudson.Functions.hidingPasswordFields=true --webroot="%BASE%\war"</arguments>

same error

and the system property is not know:
!screenshot-3.png|thumbnail!

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 1:56:03 AM3/27/20
to jenkinsc...@googlegroups.com
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException

have try to add system property
<arguments>-Xrs -Xmx256m -Dhudson.lifecycle=hudson.lifecycle.WindowsServiceLifecycle -jar "%BASE%\jenkins.war" --httpPort=8081 -Dhudson.Functions.hidingPasswordFields=true --webroot="%BASE%\war"</arguments>

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 2:00:02 AM3/27/20
to jenkinsc...@googlegroups.com

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 2:02:02 AM3/27/20
to jenkinsc...@googlegroups.com

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 2:03:03 AM3/27/20
to jenkinsc...@googlegroups.com
Thomas Patzig edited a comment on Bug JENKINS-61692
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException
@ [~danielbeck] , @ [~oleg_nenashev]
..are you able to reproduce? It doesn't matter what you enter it will crash:
!screenshot-4.png|thumbnail!

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 2:03:04 AM3/27/20
to jenkinsc...@googlegroups.com

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 3:20:02 AM3/27/20
to jenkinsc...@googlegroups.com

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 3:21:03 AM3/27/20
to jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
today I have test to deployed the latest LTS version: Jenkins ver. 2.222.1

as I want to configure my proxy it crashs directly on "Validate Proxy"

proxy.xml is different between v 2.222.1 and 2.204.5
!diff of proxy.xml.png|thumbnail!

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 3:23:03 AM3/27/20
to jenkinsc...@googlegroups.com
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException

secretPassword is no longer stored in proxy.xml
is this the reason?

dbeck@cloudbees.com (JIRA)

unread,
Mar 27, 2020, 6:18:03 AM3/27/20
to jenkinsc...@googlegroups.com

and the system property is not know:

That's because you're doing it wrong. System properties go before '-jar' argument.

dbeck@cloudbees.com (JIRA)

unread,
Mar 27, 2020, 6:19:02 AM3/27/20
to jenkinsc...@googlegroups.com

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 7:40:02 AM3/27/20
to jenkinsc...@googlegroups.com

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 7:41:02 AM3/27/20
to jenkinsc...@googlegroups.com
Thomas Patzig commented on Bug JENKINS-61692
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException

ok... changed the order of parameters:

...same behavior....nothing changed

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 7:41:04 AM3/27/20
to jenkinsc...@googlegroups.com

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 7:42:02 AM3/27/20
to jenkinsc...@googlegroups.com

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 7:42:02 AM3/27/20
to jenkinsc...@googlegroups.com
Thomas Patzig edited a comment on Bug JENKINS-61692
ok... changed the order of parameters:
!screenshot-5.png!

...same behavior....nothing changed
!screenshot-6.png|thumbnail!
  !screenshot-7.png|thumbnail!

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 7:44:03 AM3/27/20
to jenkinsc...@googlegroups.com

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 8:15:02 AM3/27/20
to jenkinsc...@googlegroups.com
Thomas Patzig edited a comment on Bug JENKINS-61692
ok... changed the order of parameters:
!screenshot-5.png |thumbnail !


...same behavior....nothing changed
!screenshot-6.png|thumbnail!  !screenshot-7.png|thumbnail!

timjacomb1@gmail.com (JIRA)

unread,
Mar 27, 2020, 8:16:02 AM3/27/20
to jenkinsc...@googlegroups.com

timjacomb1@gmail.com (JIRA)

unread,
Mar 27, 2020, 8:17:03 AM3/27/20
to jenkinsc...@googlegroups.com

dbeck@cloudbees.com (JIRA)

unread,
Mar 27, 2020, 8:23:03 AM3/27/20
to jenkinsc...@googlegroups.com

thomas.patzig@etas.com (JIRA)

unread,
Mar 27, 2020, 8:49:04 AM3/27/20
to jenkinsc...@googlegroups.com

..can't access the links....

 

...but AFAIK it is only on validation. "submit" works... 

 

but then the other issue happens: proxy doesn't work with git...  https://issues.jenkins-ci.org/browse/JENKINS-61693

dbeck@cloudbees.com (JIRA)

unread,
Mar 27, 2020, 9:14:06 AM3/27/20
to jenkinsc...@googlegroups.com

...but AFAIK it is only on validation. "submit" works...

Thanks for the clarification.

dbeck@cloudbees.com (JIRA)

unread,
Mar 27, 2020, 12:54:02 PM3/27/20
to jenkinsc...@googlegroups.com
Daniel Beck started work on Bug JENKINS-61692
 
Change By: Daniel Beck
Status: Open In Progress

dbeck@cloudbees.com (JIRA)

unread,
Mar 27, 2020, 12:54:03 PM3/27/20
to jenkinsc...@googlegroups.com

dbeck@cloudbees.com (JIRA)

unread,
Mar 27, 2020, 12:54:04 PM3/27/20
to jenkinsc...@googlegroups.com

thomas.patzig@etas.com (JIRA)

unread,
Mar 28, 2020, 1:38:02 PM3/28/20
to jenkinsc...@googlegroups.com
Thomas Patzig commented on Bug JENKINS-61692
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException

..have try jenkins.war from PR 4607.... it works...

 

have also found a mistake on my side....

I automize the Jenkins installation and bootstrap config to check latest versions... for that I do some http posts like the user would do...

 

for setup the proxy I have use "post descriptorByName/hudson.ProxyConfiguration/validateProxy" with body form url encoded content and the content "password" instead of "secretPassword"...

(same on http post pluginManager/proxyConfigure)

 

I think "password" is no longer supported in that post. Am I right? (..and that were the Links before)

 

....with fix on my side ("secretPassword" instead of "password") it works fine.

dbeck@cloudbees.com (JIRA)

unread,
Mar 28, 2020, 2:16:02 PM3/28/20
to jenkinsc...@googlegroups.com

I think "password" is no longer supported in that post. Am I right? (..and that were the Links before)

....with fix on my side ("secretPassword" instead of "password") it works fine.

That's correct; you're effectively saving the configuration without password when using the obsolete name.

dbeck@cloudbees.com (JIRA)

unread,
Mar 28, 2020, 2:18:03 PM3/28/20
to jenkinsc...@googlegroups.com
Change By: Daniel Beck
Status: In Review Fixed but Unreleased
Resolution: Fixed
Released As: Jenkins 2.229

dbeck@cloudbees.com (JIRA)

unread,
Mar 28, 2020, 2:20:03 PM3/28/20
to jenkinsc...@googlegroups.com

dbeck@cloudbees.com (JIRA)

unread,
Mar 30, 2020, 7:19:03 AM3/30/20
to jenkinsc...@googlegroups.com

ogondza@gmail.com (JIRA)

unread,
Apr 3, 2020, 4:34:03 AM4/3/20
to jenkinsc...@googlegroups.com

mark.earl.waite@gmail.com (JIRA)

unread,
Apr 14, 2020, 5:06:02 PM4/14/20
to jenkinsc...@googlegroups.com
Mark Waite commented on Bug JENKINS-61692
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException

This is labeled 2.222.2-fixed Oliver Gondža, but I don't see any indication in the commit messages to tell me that it was merged. I've left it out of the 2.222.2 changelog draft.

If it needs to be included, please notify me.

mark.earl.waite@gmail.com (JIRA)

unread,
Apr 14, 2020, 5:26:03 PM4/14/20
to jenkinsc...@googlegroups.com
Mark Waite updated an issue
 
Change By: Mark Waite
Comment: This is [labeled 2.222.2-fixed|https://issues.jenkins-ci.org/issues/?jql=labels%20%3D%202.222.2-fixed%20ORDER%20BY%20key%20DESC] [~olivergondza], but I don't see any indication in the commit messages to tell me that it was merged.  I've left it out of the 2.222.2 changelog draft.


If it needs to be included, please notify me.
Reply all
Reply to author
Forward
0 new messages