[JIRA] (JENKINS-61692) "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException

0 vue
Accéder directement au premier message non lu

thomas.patzig@etas.com (JIRA)

non lue,
26 mars 2020, 09:15:0326/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig moved an issue
 
Jenkins / Bug JENKINS-61692
"HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException
Change By: Thomas Patzig
Project: Infrastructure Jenkins
Key: INFRA JENKINS - 2554 61692
Workflow: classic default workflow JNJira + In-Review
Component/s: core
Component/s: proxy
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

thomas.patzig@etas.com (JIRA)

non lue,
26 mars 2020, 09:16:0226/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
Change By: Thomas Patzig
Environment: Jenkins ver. 2.222.1
just plain Jenkins
no plugins

thomas.patzig@etas.com (JIRA)

non lue,
26 mars 2020, 09:17:0326/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
today I have test to deployed the latest LTS version: Jenkins ver. 2.222.1

as I want to configure my proxy it crashs directly on "Validate Proxy"
!screenshot-1.png|thumbnail!

before that new LTS version I use Jenkins ver. 2.204.5 were this working fine
!screenshot-2.png|thumbnail!
 
{code:java}
java.lang.NullPointerException
at hudson.util.Secret$1.convert(Secret.java:306)
at hudson.util.Secret$1.convert(Secret.java:304)
at org.kohsuke.stapler.AnnotationHandler.convert(AnnotationHandler.java:66)
at org.kohsuke.stapler.QueryParameter$HandlerImpl.parse(QueryParameter.java:74)
at org.kohsuke.stapler.QueryParameter$HandlerImpl.parse(QueryParameter.java:62)
at org.kohsuke.stapler.AnnotationHandler.handle(AnnotationHandler.java:91)
at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:204)
at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:145)
at org.kohsuke.stapler.MetaClass$11.doDispatch(MetaClass.java:535)
at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)
at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:747)
at org.kohsuke.stapler.Stapler.invoke(Stapler.java:878)
at org.kohsuke.stapler.MetaClass$4.doDispatch(MetaClass.java:280)
at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)
at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:747)
at org.kohsuke.stapler.Stapler.invoke(Stapler.java:878)
at org.kohsuke.stapler.Stapler.invoke(Stapler.java:676)
at org.kohsuke.stapler.Stapler.service(Stapler.java:238)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:755)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1617)
at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:154)
at jenkins.security.ResourceDomainFilter.doFilter(ResourceDomainFilter.java:76)
at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:151)
at jenkins.telemetry.impl.UserLanguages$AcceptLanguageFilter.doFilter(UserLanguages.java:128)
at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:151)
at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:157)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:153)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84)
at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:118)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at jenkins.security.BasicHeaderProcessor.doFilter(BasicHeaderProcessor.java:93)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249)
at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67)
at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:90)
at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:171)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:49)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:82)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
at org.kohsuke.stapler.DiagnosticThreadNameFilter.doFilter(DiagnosticThreadNameFilter.java:30)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
at jenkins.security.SuspiciousRequestFilter.doFilter(SuspiciousRequestFilter.java:36)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:545)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:566)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1610)
at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1300)
at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:485)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1580)
at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1215)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at org.eclipse.jetty.server.Server.handle(Server.java:500)
at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:383)
at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:547)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:375)
at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:273)
at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:103)
at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:117)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171)
at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:129)
at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:375)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806)
at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:938)
at java.lang.Thread.run(Unknown Source)
{code}

thomas.patzig@etas.com (JIRA)

non lue,
26 mars 2020, 09:17:0426/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
Change By: Thomas Patzig
Environment:
Jenkins ver. 2.222.1
just plain Jenkins
no plugins
user is an active directory user

thomas.patzig@etas.com (JIRA)

non lue,
26 mars 2020, 09:19:0226/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
today I have test to deployed the latest LTS version: Jenkins ver. 2.222.1

as I want to configure my proxy it crashs directly on "Validate Proxy"
user is an AD user, have already try:

us...@domain.tld
domain\user
user
=> same behavior

thomas.patzig@etas.com (JIRA)

non lue,
26 mars 2020, 09:28:0326/03/2020
à jenkinsc...@googlegroups.com

o.v.nenashev@gmail.com (JIRA)

non lue,
26 mars 2020, 19:53:0226/03/2020
à jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
Change By: Oleg Nenashev
Labels: regression

o.v.nenashev@gmail.com (JIRA)

non lue,
26 mars 2020, 19:59:0226/03/2020
à jenkinsc...@googlegroups.com
Oleg Nenashev commented on Bug JENKINS-61692
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException

There is no recent changes in Secret.java or Stapler which would cause that behavior AFAICT. I assume that the nll check is missing in the code, but I am not sure what causes it to be passed

static { 
  Stapler.CONVERT_UTILS.register(new org.apache.commons.beanutils.Converter() { 
    public Secret convert(Class type, Object value) { 
306:      return Secret.fromString(value.toString()); 
} }, Secret.class); }

dbeck@cloudbees.com (JIRA)

non lue,
26 mars 2020, 21:07:0326/03/2020
à jenkinsc...@googlegroups.com

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 01:56:0327/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
 
Change By: Thomas Patzig
Attachment: screenshot-3.png

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 01:56:0327/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig edited a comment on Bug JENKINS-61692
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException
have try to add system property
  <arguments>-Xrs -Xmx256m -Dhudson.lifecycle=hudson.lifecycle.WindowsServiceLifecycle -jar "%BASE%\jenkins.war" --httpPort=8081 -Dhudson.Functions.hidingPasswordFields=true --webroot="%BASE%\war"</arguments>
same error

and the system property is not know:
!screenshot-3.png|thumbnail!

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 01:56:0327/03/2020
à jenkinsc...@googlegroups.com
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException

have try to add system property
<arguments>-Xrs -Xmx256m -Dhudson.lifecycle=hudson.lifecycle.WindowsServiceLifecycle -jar "%BASE%\jenkins.war" --httpPort=8081 -Dhudson.Functions.hidingPasswordFields=true --webroot="%BASE%\war"</arguments>

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 02:00:0227/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
Change By: Thomas Patzig
Priority: Critical Blocker

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 02:02:0227/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
Change By: Thomas Patzig
Attachment: screenshot-4.png

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 02:03:0327/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig edited a comment on Bug JENKINS-61692
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException
@ [~danielbeck] , @ [~oleg_nenashev]
..are you able to reproduce? It doesn't matter what you enter it will crash:
!screenshot-4.png|thumbnail!

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 02:03:0427/03/2020
à jenkinsc...@googlegroups.com


..are you able to reproduce? It doesn't matter what you enter it will crash:

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 03:20:0227/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
Change By: Thomas Patzig
Attachment: diff of proxy.xml.png

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 03:21:0327/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
today I have test to deployed the latest LTS version: Jenkins ver. 2.222.1

as I want to configure my proxy it crashs directly on "Validate Proxy"
proxy.xml is different between v 2.222.1 and 2.204.5
!diff of proxy.xml.png|thumbnail!

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 03:23:0327/03/2020
à jenkinsc...@googlegroups.com
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException

secretPassword is no longer stored in proxy.xml
is this the reason?

dbeck@cloudbees.com (JIRA)

non lue,
27 mars 2020, 06:18:0327/03/2020
à jenkinsc...@googlegroups.com

and the system property is not know:

That's because you're doing it wrong. System properties go before '-jar' argument.

dbeck@cloudbees.com (JIRA)

non lue,
27 mars 2020, 06:19:0227/03/2020
à jenkinsc...@googlegroups.com

Based on latest comment, pinging Tim Jacomb from JENKINS-56553.

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 07:40:0227/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
Change By: Thomas Patzig
Attachment: screenshot-5.png

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 07:41:0227/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig commented on Bug JENKINS-61692
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException

ok... changed the order of parameters:

...same behavior....nothing changed

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 07:41:0427/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
Change By: Thomas Patzig
Attachment: screenshot-6.png

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 07:42:0227/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig updated an issue
Change By: Thomas Patzig
Attachment: screenshot-7.png

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 07:42:0227/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig edited a comment on Bug JENKINS-61692
ok... changed the order of parameters:
!screenshot-5.png!

...same behavior....nothing changed
!screenshot-6.png|thumbnail!   !screenshot-7.png|thumbnail!

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 07:44:0327/03/2020
à jenkinsc...@googlegroups.com

...and I don't use any plugin... no JCasC.

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 08:15:0227/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig edited a comment on Bug JENKINS-61692
ok... changed the order of parameters:
!screenshot-5.png |thumbnail !


...same behavior....nothing changed
!screenshot-6.png|thumbnail!  !screenshot-7.png|thumbnail!

timjacomb1@gmail.com (JIRA)

non lue,
27 mars 2020, 08:16:0227/03/2020
à jenkinsc...@googlegroups.com
Tim Jacomb assigned an issue to Tim Jacomb
 
Change By: Tim Jacomb
Assignee: Tim Jacomb

timjacomb1@gmail.com (JIRA)

non lue,
27 mars 2020, 08:17:0327/03/2020
à jenkinsc...@googlegroups.com
Tim Jacomb updated an issue
Change By: Tim Jacomb
Priority: Blocker Minor

dbeck@cloudbees.com (JIRA)

non lue,
27 mars 2020, 08:23:0327/03/2020
à jenkinsc...@googlegroups.com

thomas.patzig@etas.com (JIRA)

non lue,
27 mars 2020, 08:49:0427/03/2020
à jenkinsc...@googlegroups.com

..can't access the links....

 

...but AFAIK it is only on validation. "submit" works... 

 

but then the other issue happens: proxy doesn't work with git...  https://issues.jenkins-ci.org/browse/JENKINS-61693

dbeck@cloudbees.com (JIRA)

non lue,
27 mars 2020, 09:14:0627/03/2020
à jenkinsc...@googlegroups.com

...but AFAIK it is only on validation. "submit" works...

Thanks for the clarification.

dbeck@cloudbees.com (JIRA)

non lue,
27 mars 2020, 12:54:0227/03/2020
à jenkinsc...@googlegroups.com
Daniel Beck started work on Bug JENKINS-61692
 
Change By: Daniel Beck
Status: Open In Progress

dbeck@cloudbees.com (JIRA)

non lue,
27 mars 2020, 12:54:0327/03/2020
à jenkinsc...@googlegroups.com
Daniel Beck assigned an issue to Daniel Beck
 
Change By: Daniel Beck
Assignee: Tim Jacomb Daniel Beck

dbeck@cloudbees.com (JIRA)

non lue,
27 mars 2020, 12:54:0427/03/2020
à jenkinsc...@googlegroups.com
Change By: Daniel Beck
Status: In Progress Review

thomas.patzig@etas.com (JIRA)

non lue,
28 mars 2020, 13:38:0228/03/2020
à jenkinsc...@googlegroups.com
Thomas Patzig commented on Bug JENKINS-61692
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException

..have try jenkins.war from PR 4607.... it works...

 

have also found a mistake on my side....

I automize the Jenkins installation and bootstrap config to check latest versions... for that I do some http posts like the user would do...

 

for setup the proxy I have use "post descriptorByName/hudson.ProxyConfiguration/validateProxy" with body form url encoded content and the content "password" instead of "secretPassword"...

(same on http post pluginManager/proxyConfigure)

 

I think "password" is no longer supported in that post. Am I right? (..and that were the Links before)

 

....with fix on my side ("secretPassword" instead of "password") it works fine.

dbeck@cloudbees.com (JIRA)

non lue,
28 mars 2020, 14:16:0228/03/2020
à jenkinsc...@googlegroups.com

I think "password" is no longer supported in that post. Am I right? (..and that were the Links before)

....with fix on my side ("secretPassword" instead of "password") it works fine.

That's correct; you're effectively saving the configuration without password when using the obsolete name.

dbeck@cloudbees.com (JIRA)

non lue,
28 mars 2020, 14:18:0328/03/2020
à jenkinsc...@googlegroups.com
Change By: Daniel Beck
Status: In Review Fixed but Unreleased
Resolution: Fixed
Released As: Jenkins 2.229

dbeck@cloudbees.com (JIRA)

non lue,
28 mars 2020, 14:20:0328/03/2020
à jenkinsc...@googlegroups.com
Daniel Beck updated an issue
Change By: Daniel Beck
Labels: lts-candidate regression

dbeck@cloudbees.com (JIRA)

non lue,
30 mars 2020, 07:19:0330/03/2020
à jenkinsc...@googlegroups.com
Change By: Daniel Beck
Status: Fixed but Unreleased Resolved

ogondza@gmail.com (JIRA)

non lue,
3 avr. 2020, 04:34:0303/04/2020
à jenkinsc...@googlegroups.com
Oliver Gondža updated an issue
Change By: Oliver Gondža
Labels: lts 2.222.2 - candidate fixed regression

mark.earl.waite@gmail.com (JIRA)

non lue,
14 avr. 2020, 17:06:0214/04/2020
à jenkinsc...@googlegroups.com
Mark Waite commented on Bug JENKINS-61692
 
Re: "HTTP Proxy Configuration" -> "Validate Proxy" crashs immediately with NullPointerException

This is labeled 2.222.2-fixed Oliver Gondža, but I don't see any indication in the commit messages to tell me that it was merged. I've left it out of the 2.222.2 changelog draft.

If it needs to be included, please notify me.

mark.earl.waite@gmail.com (JIRA)

non lue,
14 avr. 2020, 17:26:0314/04/2020
à jenkinsc...@googlegroups.com
Mark Waite updated an issue
 
Change By: Mark Waite
Comment: This is [labeled 2.222.2-fixed|https://issues.jenkins-ci.org/issues/?jql=labels%20%3D%202.222.2-fixed%20ORDER%20BY%20key%20DESC] [~olivergondza], but I don't see any indication in the commit messages to tell me that it was merged.  I've left it out of the 2.222.2 changelog draft.


If it needs to be included, please notify me.
Répondre à tous
Répondre à l'auteur
Transférer
0 nouveau message