[JIRA] (JENKINS-61519) Odd rendering of Monitoring of Jenkins master plugin in Manage Jenkins screen

[dbeck@cloudbees.com (JIRA)]

Daniel Beck updated an issue

Jenkins / JENKINS-61519 Odd rendering of Monitoring of Jenkins master plugin in Manage Jenkins screen Change By: Daniel Beck Summary: Odd rendering of Monitoring of Jenkins master plugin in new Manage Jenkins screen Add Comment

This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)

[jsoref+jenkins@gmail.com (JIRA)]

Josh Soref commented on JENKINS-61519

Re: Odd rendering of Monitoring of Jenkins master plugin in Manage Jenkins screen Oops, I guess it just wasn't as noticably bad without a sibling.

Add Comment

[evernat@free.fr (JIRA)]

evernat commented on JENKINS-61519

Re: Odd rendering of Monitoring of Jenkins master plugin in Manage Jenkins screen

There are 3 <a/> html tags on "Monitoring of Jenkins master": <div class="manage-option manage-page__column"> <a href="/monitoring" title="Monitoring of Jenkins master"><img src="/static/163b9cff/images/48x48/monitor.gif" alt="manage-option" class="icon"></a> <dl><a href="/monitoring" title="Monitoring of Jenkins master"><dt>Monitoring of Jenkins master</dt></a> <dd><a href="/monitoring" title="Monitoring of Jenkins master">Monitoring of memory, cpu, http requests and more in Jenkins master.</a><a href="./monitoring/nodes">You can also view the monitoring of builds, build queue and Jenkins nodes.</a></dd><dd></dd> </dl> </div> The other management links in the page have only the first one. Given that the view is AFAIK in manage.jelly: <a href="${m.urlName}" title="${m.displayName}"> <img class="icon" src="${iconUrl}" alt="manage-option"/> <dl> <dt>${m.displayName}</dt> <dd><j:out value="${m.description}"/></dd> <dd><st:include it="${m}" page="info.jelly" optional="true"/></dd> </dl> </a> and given that the ManagementLink code is https://github.com/jenkinsci/monitoring-plugin/blob/master/src/main/java/org/jvnet/hudson/plugins/monitoring/PluginManagementLink.java how can it print 3 <a/> html tags?

Add Comment

[evernat@free.fr (JIRA)]

evernat edited a comment on JENKINS-61519

Re: Odd rendering of Monitoring of Jenkins master plugin in Manage Jenkins screen

There are 3 <a/> html tags on "Monitoring of Jenkins master":

{code:java}

<div class="manage-option manage-page__column"> <a href="/monitoring" title="Monitoring of Jenkins master"><img src="/static/163b9cff/images/48x48/monitor.gif" alt="manage-option" class="icon"></a> <dl><a href="/monitoring" title="Monitoring of Jenkins master"><dt>Monitoring of Jenkins master</dt></a> <dd><a href="/monitoring" title="Monitoring of Jenkins master">Monitoring of memory, cpu, http requests and more in Jenkins master.</a><a href="./monitoring/nodes">You can also view the monitoring of builds, build queue and Jenkins nodes.</a></dd><dd></dd> </dl> </div>

{code}

The other management links in the page have only the first one.

Given that the view is AFAIK in [ manage.jelly |https : //github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/jenkins/model/Jenkins/manage.jelly]: {code:java}

<a href="${m.urlName}" title="${m.displayName}"> <img class="icon" src="${iconUrl}" alt="manage-option"/> <dl>    <dt>${m.displayName}</dt>    <dd><j:out value="${m.description}"/></dd>    <dd><st:include it="${m}" page="info.jelly" optional="true"/></dd> </dl>   </a>

{code}

and given that the ManagementLink code is https://github.com/jenkinsci/monitoring-plugin/blob/master/src/main/java/org/jvnet/hudson/plugins/monitoring/PluginManagementLink.java how can it print 3 <a/> html tags?

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck commented on JENKINS-61519

Re: Odd rendering of Monitoring of Jenkins master plugin in Manage Jenkins screen

how can it print 3 <a/> html tags? You're looking at the DOM, not the raw HTML source code returned by Jenkins. The problem is the illegal nesting of "a" tags (one to wrap the entire item, including img and dl/dt/dd; and one in dd from your description) which is resolved for the DOM, making the DOM HTML structure different than what is sent as text.

Add Comment