[JIRA] (JENKINS-61518) update notice odd spacing before closing parenthesis

9 views
Skip to first unread message

jsoref+jenkins@gmail.com (JIRA)

unread,
Mar 18, 2020, 8:54:02 PM3/18/20
to jenkinsc...@googlegroups.com
Josh Soref created an issue
 
Jenkins / Bug JENKINS-61518
update notice odd spacing before closing parenthesis
Issue Type: Bug Bug
Assignee: Unassigned
Attachments: image-2020-03-18-20-51-32-428.png
Components: core
Created: 2020-03-19 00:53
Priority: Minor Minor
Reporter: Josh Soref

New version of Jenkins (2.226) is available for download (changelog).
[Manage Jenkins]

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

dbeck@cloudbees.com (JIRA)

unread,
Mar 19, 2020, 9:26:02 AM3/19/20
to jenkinsc...@googlegroups.com
Daniel Beck commented on Bug JENKINS-61518
 
Re: update notice odd spacing before closing parenthesis

This exists exclusively in the popup, and not on Manage Jenkins which isn't really clear from your report (inferred from "Manage Jenkins" link).

.page-header__hyperlinks A has a margin-right: 0.25rem; from base-styles-v2.css.

Pinging Félix Queiruga Balado – seems like the UI refresh caught more elements than expected due to the popup.

dbeck@cloudbees.com (JIRA)

unread,
Mar 19, 2020, 9:27:02 AM3/19/20
to jenkinsc...@googlegroups.com

Steps to reproduce:

docker run -p 8080:8080 -p 50000:50000 jenkins/jenkins:2.225 and get through the setup.

dbeck@cloudbees.com (JIRA)

unread,
Mar 19, 2020, 9:28:02 AM3/19/20
to jenkinsc...@googlegroups.com
Daniel Beck updated an issue
 
Change By: Daniel Beck
Labels: newbie-friendly regression

fqueiruga@cloudbees.com (JIRA)

unread,
Mar 20, 2020, 5:47:02 AM3/20/20
to jenkinsc...@googlegroups.com
Félix Queiruga Balado commented on Bug JENKINS-61518
 
Re: update notice odd spacing before closing parenthesis

The issue comes from the fact that the HTML code for the monitors popup is located within the header and the .page-headerhyperlinks div. I already needed to make a hack so that the header styles would not apply here (https://github.com/jenkinsci/jenkins/blob/144550b2fc4ef59ce1af0abe4dace9e4fe394c89/core/src/main/resources/jenkins/management/AdministrativeMonitorsDecorator/resources.css#L92). A solution would come from resetting the margin there as well.

Reply all
Reply to author
Forward
0 new messages