[JIRA] (JENKINS-60940) Convert git client plugin tests from JUnit 3 to JUnit 4

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite created an issue

Jenkins / JENKINS-60940 Convert git client plugin tests from JUnit 3 to JUnit 4 Issue Type: Bug Assignee: Mark Waite Components: git-client-plugin Created: 2020-02-02 08:31 Labels: newbie-friendly Priority: Minor Reporter: Mark Waite The git client plugin tests have started their transition process to retire the JUnit 3 based GitAPITestCase, CliGitAPIImplTest, and JGitAPIImplTest. They should be replaced by the parameterized GitClientTest. For each test in GitAPITestCase, CliGitAPIImplTest, and JGitAPIImplTest: If it is already tested in GitClientTest, delete the test from the JUnit 3 based tests If it is not already tested in GitClientTest, write a test in GitClientTest and delete the test from the JUnit 3 based tests This issue could be worked by multiple people concurrently, so long as they coordinate with one another on the specific tests they are converting. Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite assigned an issue to Unassigned

Jenkins / JENKINS-60940 Convert git client plugin tests from JUnit 3 to JUnit 4

Change By: Mark Waite Assignee: Mark Waite

Add Comment

[rishabhbudhouliya+jenkins@gmail.com (JIRA)]

Rishabh Budhouliya commented on JENKINS-60940

Re: Convert git client plugin tests from JUnit 3 to JUnit 4 Hi Mark Waite,  While I was looking at some test cases written in Junit 3, I can see those tests using private methods provided by a private inner class. While porting those tests, would you consider making those classes public so that GitClientTest can access it or would you like a plain copy of that particular private class?  If there is a better option would like to hear that!

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite commented on JENKINS-60940

Re: Convert git client plugin tests from JUnit 3 to JUnit 4

You're welcome to convert private inner classes in tests into public classes.

Add Comment

[loghijiaha.16@cse.mrt.ac.lk (JIRA)]

Loghi Perinpanayagam commented on JENKINS-60940

Re: Convert git client plugin tests from JUnit 3 to JUnit 4

Hi, I can also work on this transition process. Mark Waite Rishabh Budhouliya

Add Comment

[rishabhbudhouliya+jenkins@gmail.com (JIRA)]

Rishabh Budhouliya commented on JENKINS-60940

Re: Convert git client plugin tests from JUnit 3 to JUnit 4

Hi Loghi Perinpanayagam, I have ported the CliGitAPIImplTest Junit 3 tests to GitClientTest. You can work on GitAPITestCase or JGitAPIImplTest. Please mention the class here so that anyone can work on the other one. Thanks!

Add Comment

[loghijiaha.16@cse.mrt.ac.lk (JIRA)]

Loghi Perinpanayagam commented on JENKINS-60940

Re: Convert git client plugin tests from JUnit 3 to JUnit 4

I will work on JGitAPIImplTest.

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite started work on JENKINS-60940

Change By: Mark Waite Status: Open In Progress

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite commented on JENKINS-60940

Re: Convert git client plugin tests from JUnit 3 to JUnit 4

Thank you very much to both of you, Loghi Perinpanayagam and Rishabh Budhouliya!

Add Comment

[loghijiaha.16@cse.mrt.ac.lk (JIRA)]

Loghi Perinpanayagam commented on JENKINS-60940

Re: Convert git client plugin tests from JUnit 3 to JUnit 4

Any efficient idea you could suggest to check whether the test already implemented or not in GitClientTest ?

Add Comment

[rishabhbudhouliya+jenkins@gmail.com (JIRA)]

Rishabh Budhouliya commented on JENKINS-60940

Re: Convert git client plugin tests from JUnit 3 to JUnit 4

I'm not sure how Mark would suggest it, but here is my opinion: 1) The first obvious way would be to search for the same test-case name, for example: testRefSpecWithNullValues might be referred with a similar name in GitClientTest. 2) If the name isn't obvious then try to understand what the test is asserting and try to find the same definition. Also, if you are using IntelliJ it automatically highlights duplicate code, so that can be also used.

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite commented on JENKINS-60940

Re: Convert git client plugin tests from JUnit 3 to JUnit 4

Loghi Perinpanayagam I like the suggestion from Rishabh Budhouliya to review the test names and the test assertions. Some assertions are not immediately visible (like the assertion of expected job status in the build() calls, but assertions are a very useful way to avoid losing knowledge in the transition from JUnit 3 to JUnit 4.

Add Comment

[loghijiaha.16@cse.mrt.ac.lk (JIRA)]

Loghi Perinpanayagam commented on JENKINS-60940

Re: Convert git client plugin tests from JUnit 3 to JUnit 4

Great thanks. Mark Waite and Rishabh Budhouliya I check it out. I think most of the test cases lie on GitAPITestCase. @NotImplementedInJGit annotations are helping to identify the relevant tests in my case.

Add Comment

[mark.earl.waite@gmail.com (JIRA)]

Mark Waite updated an issue

Jenkins / JENKINS-60940

Convert git client plugin tests from JUnit 3 to JUnit 4

Change By: Mark Waite

The git client plugin tests have started their transition process to retire the JUnit 3 based GitAPITestCase, CliGitAPIImplTest, and JGitAPIImplTest.  They should be replaced by the parameterized GitClientTest. For each test in GitAPITestCase, CliGitAPIImplTest, and JGitAPIImplTest:

* If it is already tested in GitClientTest, delete the test from the JUnit 3 based tests * If it is not already tested in GitClientTest, write a test in GitClientTest or in a new test class and delete the test from the JUnit 3 based tests

This issue could be worked by multiple people concurrently, so long as they coordinate with one another on the specific tests they are converting.

Add Comment