[JIRA] (JENKINS-60895) Add doc details re behavior of choosing strategy Gerrit trigger

7 views
Skip to first unread message

christopher.lott@icloud.com (JIRA)

unread,
Jan 28, 2020, 9:42:03 AM1/28/20
to jenkinsc...@googlegroups.com
Chris Lott created an issue
 
Jenkins / Improvement JENKINS-60895
Add doc details re behavior of choosing strategy Gerrit trigger
Issue Type: Improvement Improvement
Assignee: rsandell
Components: gerrit-trigger-plugin
Created: 2020-01-28 14:41
Environment: latest - 2.30.3
Priority: Minor Minor
Reporter: Chris Lott

Request a minor doc extension to explain the advanced choosing strategy "Gerrit Trigger" in the git plugin. Please confirm that I understand.  I see two behaviors here:

  1. In a gerrit verify scenario - build before merge to target branch - this checks out the submitted change set which is in a branch like refs/changes/65/6365/1.
  2. In a gerrit merge scenario - build after merge to target branch - this checks out the target branch exactly at the point where the merge happened, NOT the current head/tip of the target branch.

If I got that right, and didn't miss anything, I'll be glad to write up & submit a PR to:

https://github.com/jenkinsci/gerrit-trigger-plugin/blob/master/docs/README.adoc

Thanks in advance
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

christopher.lott@icloud.com (JIRA)

unread,
Jan 28, 2020, 9:44:04 AM1/28/20
to jenkinsc...@googlegroups.com
Chris Lott updated an issue
Change By: Chris Lott
Request a minor doc extension to explain the advanced choosing strategy "Gerrit Trigger" in the git plugin. Please confirm that I understand.  I see two behaviors here:
# In a gerrit verify scenario - build before merge to target branch - this checks out the submitted change set which is in a branch like refs/changes/65/6365/1.
# In a gerrit merge scenario - build after merge to target branch - this checks out the target branch exactly at the point where the merge happened, NOT the current head/tip of the target branch.


If I got that right, and didn't miss anything, I'll be glad to write up & submit a PR to:

[https://github.com/jenkinsci/gerrit-trigger-plugin/blob/master/docs/README.adoc]

Thanks in advance


Here's the section I'd like to extend:
{noformat}
To get the Git Plugin to download your change; set Refspec to $GERRIT_REFSPEC and the Choosing strategy to Gerrit Trigger.
This may be under ''Additional Behaviours/Strategy For Choosing What To
Build' rather than directly visible as depicted in the screenshot. You
may also need to set 'Branches to build' to $GERRIT_BRANCH. If this does not work for you set Refspec to refs/changes/:refs/changes/* and 'Branches to build' to *$GERRIT_REFSPEC.{noformat}

christopher.lott@icloud.com (JIRA)

unread,
Jan 28, 2020, 9:45:02 AM1/28/20
to jenkinsc...@googlegroups.com
Chris Lott updated an issue
Request a minor doc extension to explain the advanced choosing strategy "Gerrit Trigger" in the git plugin. Please confirm that I understand.  I see two behaviors here:
# In a gerrit verify scenario - build before merge to target branch - this checks out the submitted change set which is in a branch like refs/changes/65/6365/1.
# In a gerrit merge scenario - build after merge to target branch - this checks out the target branch exactly at the point where the merge happened, NOT the current head/tip of the target branch.

If I got that right, and didn't miss anything, I'll be glad to write up & submit a PR to:

[https://github.com/jenkinsci/gerrit-trigger-plugin/blob/master/docs/README.adoc]

Thanks in advance

Here's the section I'd like to extend with , this is the only mention of "Choosing Strategy" that I could find:

{noformat}
To get the Git Plugin to download your change; set Refspec to $GERRIT_REFSPEC and the Choosing strategy to Gerrit Trigger.
This may be under ''Additional Behaviours/Strategy For Choosing What To
Build' rather than directly visible as depicted in the screenshot. You
may also need to set 'Branches to build' to $GERRIT_BRANCH. If this does not work for you set Refspec to refs/changes/:refs/changes/* and 'Branches to build' to *$GERRIT_REFSPEC.{noformat}

christopher.lott@icloud.com (JIRA)

unread,
Jan 28, 2020, 9:45:02 AM1/28/20
to jenkinsc...@googlegroups.com
Chris Lott updated an issue
Request a minor doc extension to explain the advanced choosing strategy "Gerrit Trigger" in the git plugin. Please confirm that I understand.  I see two behaviors here:
# In a gerrit verify scenario - build before merge to target branch - this checks out the submitted change set which is in a branch like refs/changes/65/6365/1.
# In a gerrit merge scenario - build after merge to target branch - this checks out the target branch exactly at the point where the merge happened, NOT the current head/tip of the target branch.

If I got that right, and didn't miss anything, I'll be glad to write up & submit a PR to:

[https://github.com/jenkinsci/gerrit-trigger-plugin/blob/master/docs/README.adoc]

Thanks in advance

Here's the section I'd like to extend with the only mention of "Choosing Strategy" that I could find :

{noformat}
To get the Git Plugin to download your change; set Refspec to $GERRIT_REFSPEC and the Choosing strategy to Gerrit Trigger.
This may be under ''Additional Behaviours/Strategy For Choosing What To
Build' rather than directly visible as depicted in the screenshot. You
may also need to set 'Branches to build' to $GERRIT_BRANCH. If this does not work for you set Refspec to refs/changes/:refs/changes/* and 'Branches to build' to *$GERRIT_REFSPEC.{noformat}
Reply all
Reply to author
Forward
0 new messages