[JIRA] (JENKINS-60859) hadolint support in checkstyle parser

reitzmichnicht@gmx.de (JIRA)

unread,

Jan 24, 2020, 5:19:03 AM1/24/20

to jenkinsc...@googlegroups.com

Michael Düsterhus created an issue

Jenkins /

JENKINS-60859

hadolint support in checkstyle parser

Issue Type:	Improvement
Assignee:	Ulli Hafner
Components:	analysis-model
Created:	2020-01-24 10:18
Environment:	warnings-ng 7.x
Priority:	Major
Reporter:	Michael Düsterhus

Hadolint is the most common linter for Dockerfiles.
https://github.com/hadolint/hadolint

It also supports checkstyle output:

 
                                                                hadolint Dockerfile -f checkstyle > checkstyle-hadolint.xml

Example hadolint output:

 
                                                                <?xml version='1.0' encoding='UTF-8'?><checkstyle version='4.3'><file name='Dockerfile' ><error line='13' column='1' severity='warning' message='Pin versions in apk add. Instead of &#96;apk add &#60;package&#62;&#96; use &#96;apk add &#60;package&#62;&#61;&#60;version&#62;&#96;' source='DL3018' /><error line='16' column='1' severity='warning' message='In POSIX sh&#44; set option pipefail is undefined.' source='SC2039' /><error line='16' column='1' severity='warning' message='Set the SHELL option &#45;o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash&#44; or disable this check' source='DL4006' /></file></checkstyle>

This works in general with warnings-ng, but the display of the source attribute is not working as your parser expects a '.' inside. This should have a fallback mechanism to support tools that reuse the checkstyle format.