[JIRA] (JENKINS-60856) Breakpad Symbols are not uploaded properly

26 views
Skip to first unread message

david.hodgkinson@outplay.com (JIRA)

unread,
Jan 24, 2020, 5:05:02 AM1/24/20
to jenkinsc...@googlegroups.com
David Hodgkinson created an issue
 
Jenkins / Bug JENKINS-60856
Breakpad Symbols are not uploaded properly
Issue Type: Bug Bug
Assignee: Mez Pahlan
Components: appcenter-plugin
Created: 2020-01-24 10:04
Environment: Plugin Version: 0.8.0
Priority: Minor Minor
Reporter: David Hodgkinson

AppCenter Plugin hardcodes uploaded Android symbols to be AndroidProguard when uploading to AppCenter. However, this is incorrect in the case of JNI projects. We either need a second field for specifying Breakpad symbols with Android projects or a selector to determine which type of symbols are being uploaded. 

 

As a workaround I have rebuilt the plugin for use in our cluster by changing the hardcoded value to Breakpad as we only require native symbols. However, as this would break other projects so I am not creating a pull request. 

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

mez.pahlan@gmail.com (JIRA)

unread,
Jan 29, 2020, 11:20:02 AM1/29/20
to jenkinsc...@googlegroups.com
Mez Pahlan commented on Bug JENKINS-60856
 
Re: Breakpad Symbols are not uploaded properly

Hi David Hodgkinson massive apologies, I've been quite busy at work lately and have neglected this. I'll try and get some this week to investigate. Thanks for raising it.

I think we did a similar fix for iOS and Mac symbols so I'll dig that out and copy the approach.

mez.pahlan@gmail.com (JIRA)

unread,
Feb 4, 2020, 2:23:03 AM2/4/20
to jenkinsc...@googlegroups.com

Hi David Hodgkinson I'm going to look at this next. Here's the official docs for what you describe: https://docs.microsoft.com/en-gb/appcenter/diagnostics/android-ndk

The only small complication vs the support we did for IOS is that I need to upload these symbols specifically as Breakpad symbols type as opposed to Android. With IOS / MacOS I could get away with simply Apple. But that's my problem

mez.pahlan@gmail.com (JIRA)

unread,
Feb 4, 2020, 2:31:02 PM2/4/20
to jenkinsc...@googlegroups.com
Mez Pahlan started work on Bug JENKINS-60856
 
Change By: Mez Pahlan
Status: Open In Progress

mez.pahlan@gmail.com (JIRA)

unread,
Feb 5, 2020, 4:51:03 PM2/5/20
to jenkinsc...@googlegroups.com

mez.pahlan@gmail.com (JIRA)

unread,
Feb 5, 2020, 5:11:04 PM2/5/20
to jenkinsc...@googlegroups.com
 
Re: Breakpad Symbols are not uploaded properly

Hi David Hodgkinson I've got a potential fix for this that I'd appreciate if you could test out before I merge it.

The PR is here: https://github.com/jenkinsci/appcenter-plugin/pull/45

And the upcoming change can be downloaded from the CI server: https://ci.jenkins.io/job/Plugins/job/appcenter-plugin/job/PR-45/1/artifact/target/appcenter.hpi

If you're happy could you let me know either here or on the Github PR. Many thanks!

mez.pahlan@gmail.com (JIRA)

unread,
Feb 5, 2020, 5:48:01 PM2/5/20
to jenkinsc...@googlegroups.com
Mez Pahlan updated an issue
 
Change By: Mez Pahlan
Priority: Minor Major

mez.pahlan@gmail.com (JIRA)

unread,
Feb 8, 2020, 11:22:03 AM2/8/20
to jenkinsc...@googlegroups.com
 
Re: Breakpad Symbols are not uploaded properly

Hi David Hodgkinson just checking if you're still able to test this out prior to me merging it in. I've got tests for it myself, but wanted to check if you're happy with it first. Many thanks.

mez.pahlan@gmail.com (JIRA)

unread,
Feb 8, 2020, 11:36:02 AM2/8/20
to jenkinsc...@googlegroups.com
Change By: Mez Pahlan
Status: In Review Fixed but Unreleased
Resolution: Fixed

mez.pahlan@gmail.com (JIRA)

unread,
Feb 8, 2020, 11:50:02 AM2/8/20
to jenkinsc...@googlegroups.com
Change By: Mez Pahlan
Resolution: Fixed
Status: Fixed but Unreleased Reopened

mez.pahlan@gmail.com (JIRA)

unread,
Feb 8, 2020, 11:50:02 AM2/8/20
to jenkinsc...@googlegroups.com
Mez Pahlan started work on Bug JENKINS-60856
 
Change By: Mez Pahlan
Status: Reopened In Progress

mez.pahlan@gmail.com (JIRA)

unread,
Feb 12, 2020, 3:51:03 PM2/12/20
to jenkinsc...@googlegroups.com
 
Re: Breakpad Symbols are not uploaded properly

I'm going to move this along and release it. Feel free to raise a new issue if you need. Many thanks for reporting.

mez.pahlan@gmail.com (JIRA)

unread,
Feb 12, 2020, 3:59:02 PM2/12/20
to jenkinsc...@googlegroups.com
Change By: Mez Pahlan
Status:
In Review Fixed but Unreleased
Resolution: Fixed

mez.pahlan@gmail.com (JIRA)

unread,
Feb 12, 2020, 3:59:03 PM2/12/20
to jenkinsc...@googlegroups.com

mez.pahlan@gmail.com (JIRA)

unread,
Mar 4, 2020, 4:03:04 PM3/4/20
to jenkinsc...@googlegroups.com
Change By: Mez Pahlan
Status: Fixed but Unreleased Resolved
Released As: 0.8.2
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages