[JIRA] (JENKINS-60821) Check and update any Jetty code with custom threadpool

0 views
Skip to first unread message

jnord@cloudbees.com (JIRA)

unread,
Jan 20, 2020, 6:10:06 AM1/20/20
to jenkinsc...@googlegroups.com
James Nord created an issue
 
Jenkins / Improvement JENKINS-60821
Check and update any Jetty code with custom threadpool
Issue Type: Improvement Improvement
Assignee: James Nord
Components: jenkins-test-harness, maven-hpi-plugin, winstone-jetty
Created: 2020-01-20 11:09
Priority: Minor Minor
Reporter: James Nord

As per Jetty Issue#4492 which was created to report the failure to process requests we have been told that our code is wrong.

Jesse Glick ​verified the fix in [ https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96]6 (https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe

We need to

  • see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread)
  • make sure other uses of Jetty in Jenkins (winsone, RunMojo (hpi-pluin)) are not affected also.

slack: https://cloudbees.slack.com/archives/CBXU9VCGL/p1579285074024500?thread_ts=1579193579.070300&cid=CBXU9VCGL
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

jnord@cloudbees.com (JIRA)

unread,
Jan 20, 2020, 6:16:07 AM1/20/20
to jenkinsc...@googlegroups.com
James Nord started work on Improvement JENKINS-60821
 
Change By: James Nord
Status: Open In Progress

jnord@cloudbees.com (JIRA)

unread,
Jan 20, 2020, 1:17:06 PM1/20/20
to jenkinsc...@googlegroups.com
James Nord updated an issue
Change By: James Nord
As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492)] which was created to report the failure to process requests we have been told that our code is wrong.

Jesse Glick ​verified the fix in [ https://github.com/ cloudbees /cloudbees -workflow-template-plugin /pull/ # 9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/ 96 9 ] 6 [ (https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe commit 0c4eb98d |https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe ) ]

We need to
* see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread)

* make sure other uses of Jetty in Jenkins (winsone, RunMojo (hpi-pluin)) are not affected also.



slack: [https://cloudbees.slack.com/archives/CBXU9VCGL/p1579285074024500?thread_ts=1579193579.070300&cid=CBXU9VCGL]

jnord@cloudbees.com (JIRA)

unread,
Jan 20, 2020, 1:18:04 PM1/20/20
to jenkinsc...@googlegroups.com
James Nord commented on Improvement JENKINS-60821
 
Re: Check and update any Jetty code with custom threadpool

removing the thread naming means the threadpool uses threads starting with "qtp" rather than "Jetty Thread Pool"

jnord@cloudbees.com (JIRA)

unread,
Jan 20, 2020, 1:19:02 PM1/20/20
to jenkinsc...@googlegroups.com
James Nord updated an issue
Change By: James Nord
As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492 ) ] which was created to report the failure to process requests we have been told that our code is wrong.

Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9]  [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]


We need to
* see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread)

* make sure other uses of Jetty in Jenkins (winsone, RunMojo (hpi-pluin)) are not affected also.

jnord@cloudbees.com (JIRA)

unread,
Jan 20, 2020, 1:52:07 PM1/20/20
to jenkinsc...@googlegroups.com
James Nord updated an issue
As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.


Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9]  [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

We need to
* see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread)
✔

* make sure other uses of Jetty in Jenkins
(winsone, RunMojo (
     * winstone
     * maven- hpi- pluin plugin (run mojoe etc ) ) are not affected also.   ✔

jnord@cloudbees.com (JIRA)

unread,
Jan 20, 2020, 2:33:03 PM1/20/20
to jenkinsc...@googlegroups.com
 
Re: Check and update any Jetty code with custom threadpool

maven-hpi-plugin seems unaffected

winstone allows for configuration of the acceptors and selectors and the max # threads (which by default uses Jetty defaults)

jnord@cloudbees.com (JIRA)

unread,
Jan 20, 2020, 2:33:03 PM1/20/20
to jenkinsc...@googlegroups.com
James Nord updated an issue
Change By: James Nord
As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.

Jesse Glick ​verified the fix in [cloudbees-workflow-template-plugin#9|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/9]  [commit 0c4eb98d|https://github.com/cloudbees/cloudbees-workflow-template-plugin/pull/96/commits/0c4eb98d94008760d077dbc36d5e33e5bdb398fe]

We need to
* see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔

* make sure other uses of Jetty in Jenkins
are safe
      * winstone   ✔
     * maven-hpi-plugin (run mojoe etc)  ✔

jnord@cloudbees.com (JIRA)

unread,
Jan 20, 2020, 2:34:02 PM1/20/20
to jenkinsc...@googlegroups.com
James Nord updated an issue
As per [Jetty Issue#4492|https://github.com/eclipse/jetty.project/issues/4492] which was created to report the failure to process requests we have been told that our code is wrong.



We need to
* see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔

* make sure other uses of Jetty in Jenkins are safe
     * winstone  ✔
     * maven-hpi-plugin (run mojoe etc)  ✔

jnord@cloudbees.com (JIRA)

unread,
Jan 23, 2020, 12:01:04 PM1/23/20
to jenkinsc...@googlegroups.com
Change By: James Nord
Status: In Progress Fixed but Unreleased
Resolution: Fixed

jnord@cloudbees.com (JIRA)

unread,
Jan 23, 2020, 12:01:05 PM1/23/20
to jenkinsc...@googlegroups.com
James Nord assigned an issue to Unassigned
Change By: James Nord
Assignee: James Nord

o.v.nenashev@gmail.com (JIRA)

unread,
Jan 27, 2020, 5:46:03 PM1/27/20
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue

James Nord Winstone fix was shipped in 2.218. Do we need to keep this issue open?
Change By: Oleg Nenashev
Released As: Jenkins 2.218

jnord@cloudbees.com (JIRA)

unread,
Jan 27, 2020, 6:13:02 PM1/27/20
to jenkinsc...@googlegroups.com
 
Re: Check and update any Jetty code with custom threadpool

Jenkins test harness has not been released yet but happy to close as it's been merged, just not sure on the process for jth

o.v.nenashev@gmail.com (JIRA)

unread,
Jan 27, 2020, 6:20:02 PM1/27/20
to jenkinsc...@googlegroups.com

I will cut the Jetty release

recena@gmail.com (JIRA)

unread,
Mar 1, 2020, 3:40:03 PM3/1/20
to jenkinsc...@googlegroups.com

The links provided in the issue description are broken. I assume they are private links.

According to the CHANGELOG, we are able to update the status of this issue. It is already released.
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

jnord@cloudbees.com (JIRA)

unread,
Mar 1, 2020, 4:06:03 PM3/1/20
to jenkinsc...@googlegroups.com
Change By: James Nord
Status: Fixed but Unreleased Resolved

jnord@cloudbees.com (JIRA)

unread,
Mar 1, 2020, 4:08:05 PM3/1/20
to jenkinsc...@googlegroups.com
James Nord commented on Improvement JENKINS-60821
 
Re: Check and update any Jetty code with custom threadpool

the link to jetty issue is public. the verification was a private repo
Reply all
Reply to author
Forward
0 new messages