[JIRA] (JENKINS-60773) Milestone aborting old builds before passing next milestone

0 views
Skip to first unread message

taylorp36@gmail.com (JIRA)

unread,
Jan 14, 2020, 4:31:07 PM1/14/20
to jenkinsc...@googlegroups.com
Taylor Patton updated an issue
 
Jenkins / Bug JENKINS-60773
Milestone aborting old builds before passing next milestone
Change By: Taylor Patton
Summary: Milestone cancelling aborting old builds before passing next milestone
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

taylorp36@gmail.com (JIRA)

unread,
Jan 14, 2020, 4:36:06 PM1/14/20
to jenkinsc...@googlegroups.com
Taylor Patton updated an issue
Change By: Taylor Patton
Component/s: pipeline-milestone-step-plugin
Component/s: pipeline

taylorp36@gmail.com (JIRA)

unread,
Jan 14, 2020, 5:01:07 PM1/14/20
to jenkinsc...@googlegroups.com
Taylor Patton updated an issue
Change By: Taylor Patton
Component/s: pipeline-input-step-plugin

taylorp36@gmail.com (JIRA)

unread,
Jan 14, 2020, 5:03:10 PM1/14/20
to jenkinsc...@googlegroups.com
Taylor Patton updated an issue
Change By: Taylor Patton
Environment: Jenkins 2.204.1
Milestone Step Plugin 1.3.1
Input Step Plugin 2.11

robin479@gmail.com (JIRA)

unread,
Apr 17, 2020, 6:51:03 AM4/17/20
to jenkinsc...@googlegroups.com
Kai Kunstmann commented on Bug JENKINS-60773
 
Re: Milestone aborting old builds before passing next milestone

This Issue should better be titled: "Cancelling a build should not abort older builds in sight of the same milestone".

I'm having the same problem as the reporting user.

I have setup a build-pipeline that waits for user approvals before deploying my application to my QA, STAGING and PRODUCTION environments, respectively. The situation is this:

There are multiple builds waiting for an approval to deploy to STAGING, so all of them are currently in sight of the same previous milestone (e.g. "deployed to QA"). I abort the newest build, because it didn't pass quality requirements on QA, and should never be deployed to STAGING, but I wish for older builds at the same input-step to continue waiting for approval to deploy to STAGING. The bad build gets cancelled as expected, but the milestone plugin subsequently performs some clean-up including aborting all other builds in sight of the same milestone (namely "deployed to QA"). This is not the expected behavior, because the just cancelled build did not progress to the next milestone in order to be allowed to abort its siblings.

 

I believe, this behaviour is due to this: https://github.com/jenkinsci/pipeline-milestone-step-plugin/blob/ab24d126caaad2c507ec0d26b7cb87d314e1f296/src/main/java/org/jenkinsci/plugins/pipeline/milestone/MilestoneStepExecution.java#L189

Which is only ever executed from here: https://github.com/jenkinsci/pipeline-milestone-step-plugin/blob/ab24d126caaad2c507ec0d26b7cb87d314e1f296/src/main/java/org/jenkinsci/plugins/pipeline/milestone/MilestoneStepExecution.java#L330

 

This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages