[JIRA] (JENKINS-60716) Loss of exception detail in LogRotator failures

16 views
Skip to first unread message

jglick@cloudbees.com (JIRA)

unread,
Jan 9, 2020, 2:59:03 PM1/9/20
to jenkinsc...@googlegroups.com
Jesse Glick created an issue
 
Jenkins / Bug JENKINS-60716
Loss of exception detail in LogRotator failures
Issue Type: Bug Bug
Assignee: Jesse Glick
Components: core
Created: 2020-01-09 19:58
Labels: regression lts-candidate plugin-compat-tester
Priority: Minor Minor
Reporter: Jesse Glick

The patch for JENKINS-58779 resulted in a loss of detail in the system log about the root cause of a build rotation failure. Caught by plugin-compat-tester on artifact-manager-s3:

WARNING	o.j.p.workflow.job.WorkflowRun#lambda$finish$2: failed to perform log rotation after p #2
hudson.tasks.LogRotator$CollatedLogRotatorException: Failed to rotate logs for [p #1]
	at hudson.tasks.LogRotator.perform(LogRotator.java:220)
	at hudson.model.Job.logRotate(Job.java:469)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.lambda$finish$2(WorkflowRun.java:608)
...
java.lang.AssertionError: 

Expected: iterable with items ["container not found: sorry about your artifacts"] in any order
     but: not matched: "Failed to rotate logs for [p #1]"
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:956)
	at org.junit.Assert.assertThat(Assert.java:923)
	at io.jenkins.plugins.artifact_manager_jclouds.NetworkTest.errorCleaningArtifacts(NetworkTest.java:335)

Original log contents for comparison:

WARNING	o.j.p.workflow.job.WorkflowRun#lambda$finish$2: failed to perform log rotation after p #2
org.jclouds.blobstore.ContainerNotFoundException: container not found: sorry about your artifacts
	at io.jenkins.plugins.artifact_manager_jclouds.NetworkTest.lambda$errorCleaningArtifacts$3(NetworkTest.java:333)
	at io.jenkins.plugins.artifact_manager_jclouds.MockApiMetadata$MockStrategy.removeBlob(MockApiMetadata.java:229)
	at ... io.jenkins.plugins.artifact_manager_jclouds.JCloudsVirtualFile.delete(JCloudsVirtualFile.java:370)
Caused: java.io.IOException
	at io.jenkins.plugins.artifact_manager_jclouds.JCloudsVirtualFile.delete(JCloudsVirtualFile.java:374)
	at io.jenkins.plugins.artifact_manager_jclouds.JCloudsArtifactManager.delete(JCloudsArtifactManager.java:206)
	at hudson.model.Run.deleteArtifacts(Run.java:1555)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.deleteArtifacts(WorkflowRun.java:633)
	at hudson.tasks.LogRotator.perform(LogRotator.java:158)
	at hudson.model.Job.logRotate(Job.java:468)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.lambda$finish$2(WorkflowRun.java:608)
	at ...
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

jglick@cloudbees.com (JIRA)

unread,
Jan 9, 2020, 3:00:02 PM1/9/20
to jenkinsc...@googlegroups.com
Jesse Glick started work on Bug JENKINS-60716
 
Change By: Jesse Glick
Status: Open In Progress

jglick@cloudbees.com (JIRA)

unread,
Jan 9, 2020, 3:01:03 PM1/9/20
to jenkinsc...@googlegroups.com
Jesse Glick updated an issue
Change By: Jesse Glick
The patch for JENKINS-58779 resulted in a loss of detail in the system log about the root cause of a build rotation failure. Caught by {{plugin-compat-tester}} on {{artifact-manager-s3}}:

{code:none}

WARNING o.j.p.workflow.job.WorkflowRun#lambda$finish$2: failed to perform log rotation after p #2
hudson.tasks.LogRotator$CollatedLogRotatorException: Failed to rotate logs for [p #1]
at hudson.tasks.LogRotator.perform(LogRotator.java:220)
at hudson.model.Job.logRotate(Job.java:469)
at org.jenkinsci.plugins.workflow.job.WorkflowRun.lambda$finish$2(WorkflowRun.java:608)
...
java.lang.AssertionError:

Expected: iterable with items ["container not found: sorry about your artifacts"] in any order
     but: not matched: "Failed to rotate logs for [p #1]"
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:956)
at org.junit.Assert.assertThat(Assert.java:923)
at io.jenkins.plugins.artifact_manager_jclouds.NetworkTest.errorCleaningArtifacts(NetworkTest.java:335)
{code}


Original log contents for comparison:

{code:none}

WARNING o.j.p.workflow.job.WorkflowRun#lambda$finish$2: failed to perform log rotation after p #2
org.jclouds.blobstore.ContainerNotFoundException: container not found: sorry about your artifacts
at io.jenkins.plugins.artifact_manager_jclouds.NetworkTest.lambda$errorCleaningArtifacts$3(NetworkTest.java:333)
at io.jenkins.plugins.artifact_manager_jclouds.MockApiMetadata$MockStrategy.removeBlob(MockApiMetadata.java:229)
at ...

at io.jenkins.plugins.artifact_manager_jclouds.JCloudsVirtualFile.delete(JCloudsVirtualFile.java:370)

Caused: java.io.IOException
at io.jenkins.plugins.artifact_manager_jclouds.JCloudsVirtualFile.delete(JCloudsVirtualFile.java:374)
at io.jenkins.plugins.artifact_manager_jclouds.JCloudsArtifactManager.delete(JCloudsArtifactManager.java:206)
at hudson.model.Run.deleteArtifacts(Run.java:1555)
at org.jenkinsci.plugins.workflow.job.WorkflowRun.deleteArtifacts(WorkflowRun.java:633)
at hudson.tasks.LogRotator.perform(LogRotator.java:158)
at hudson.model.Job.logRotate(Job.java:468)
at org.jenkinsci.plugins.workflow.job.WorkflowRun.lambda$finish$2(WorkflowRun.java:608)
at ...
{code}

jglick@cloudbees.com (JIRA)

unread,
Jan 9, 2020, 3:17:04 PM1/9/20
to jenkinsc...@googlegroups.com
Change By: Jesse Glick
Status: In Progress Review

o.v.nenashev@gmail.com (JIRA)

unread,
Jan 10, 2020, 5:00:02 AM1/10/20
to jenkinsc...@googlegroups.com
Oleg Nenashev commented on Bug JENKINS-60716
 
Re: Loss of exception detail in LogRotator failures

It was in 2.196, hence I suspect it is an LTS candidate

jglick@cloudbees.com (JIRA)

unread,
Jan 10, 2020, 9:19:02 AM1/10/20
to jenkinsc...@googlegroups.com

Yes, the regression was detected in 2.204.1.

jglick@cloudbees.com (JIRA)

unread,
Jan 14, 2020, 9:20:02 AM1/14/20
to jenkinsc...@googlegroups.com
Change By: Jesse Glick
Status: In Review Fixed but Unreleased
Resolution: Fixed
Released As: 2.215

jsoref+jenkins@gmail.com (JIRA)

unread,
Jan 21, 2020, 3:55:04 PM1/21/20
to jenkinsc...@googlegroups.com
Change By: Josh Soref
Status: Fixed but Unreleased Resolved

ogondza@gmail.com (JIRA)

unread,
Feb 13, 2020, 3:45:02 PM2/13/20
to jenkinsc...@googlegroups.com
Oliver Gondža updated an issue
Change By: Oliver Gondža
Labels: lts 2.204.3 - candidate fixed plugin-compat-tester regression
Reply all
Reply to author
Forward
0 new messages