[JIRA] (JENKINS-60703) Question marks in pipeline stage names break parameterized input steps

5 views
Skip to first unread message

james.barrett.lewis@gmail.com (JIRA)

unread,
Jan 8, 2020, 6:02:02 PM1/8/20
to jenkinsc...@googlegroups.com
Barrett Lewis created an issue
 
Jenkins / Bug JENKINS-60703
Question marks in pipeline stage names break parameterized input steps
Issue Type: Bug Bug
Assignee: Unassigned
Components: pipeline
Created: 2020-01-08 23:01
Environment: Jenkins 2.204.1
Pipeline 2.6
Pipeline: Declarative 1.5.0
Pipeline: Input Step 2.11
Priority: Minor Minor
Reporter: Barrett Lewis

Pipelines can have stages named with a question mark inside, but if that stage has an input step (with 'parameters' so that it brings up the input in a hyperlinked page) the question mark breaks the input return URI.  You get a 404 when you click the hyperlink in the console to bring up the input dialog.

 

To repro:

Put this stage into a pipeline

      stage('Approve?')
      {
            input {
                message "Should we continue?"
                ok "Yes, we should."
                parameters {
                    string(name: 'PERSON', defaultValue: 'Mr Jenkins', description: 'Who should I say hello to?')
                }
            }
            steps {
                echo "Hello, ${PERSON}, nice to meet you."
            }
      }

During pipeline execution, when coming to input step, it blocks in the console on a hyperlink "Input requested".  Clicking the hyperlink takes you to the input dialog.  Trying to click Ok gives a 404 since the stage name is in the URI.

 

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

james.barrett.lewis@gmail.com (JIRA)

unread,
Jan 8, 2020, 6:04:02 PM1/8/20
to jenkinsc...@googlegroups.com
Barrett Lewis updated an issue
Change By: Barrett Lewis
Pipelines can have stages named with a question mark inside, but if that stage has an input step (with 'parameters' so that it brings up the input in a hyperlinked page) the question mark breaks the input return URI.  You get a 404 when you click the hyperlink in the console to bring up the
input dialog.


 

To repro:

Put this stage into a pipeline
{code:java}

      stage('Approve?')
      {
            input {
                message "Should we continue?"
                ok "Yes, we should."
                parameters {
                    string(name: 'PERSON', defaultValue: 'Mr Jenkins', description: 'Who should I say hello to?')
                }
            }
            steps {
                echo "Hello, ${PERSON}, nice to meet you."
            }
      }
{code}

During pipeline execution, when coming to input step, it blocks in the console on a hyperlink "Input requested".  Clicking the hyperlink takes you to the input dialog.  Trying to click Ok gives a 404 since the stage name is in the URI.

 
Reply all
Reply to author
Forward
0 new messages