[JIRA] (JENKINS-60694) JellyTestSuite fails with timeout issue on Windows runner because it uses HudsonTestCase instead of JenkinsRule

0 views
Skip to first unread message

ajard@cloudbees.com (JIRA)

unread,
Jan 8, 2020, 8:37:02 AM1/8/20
to jenkinsc...@googlegroups.com
A. Jard created an issue
 
Jenkins / Bug JENKINS-60694
JellyTestSuite fails with timeout issue on Windows runner because it uses HudsonTestCase instead of JenkinsRule
Issue Type: Bug Bug
Assignee: Oliver Gondža
Components: jenkins-test-harness
Created: 2020-01-08 13:36
Environment: Windows agent on kubernetes
jenkins-test-harness-2.57 and above with jetty version greater than 9.4.6.v20170531
Priority: Minor Minor
Reporter: A. Jard

The test class TestInjection generated by maven-hpi-plugin fails to run the test suite with a timeout exception when updating jenkins-test-harness from 2.56 to 2.57 on Windows agent.

The same mvn install command run on a Linux agent run fine.

After investigation, the reason is that JellyTestSuite is based on HudsonTestCase, and HudsonTestCase does not work on the Windows agent with a jetty above 9.4.6.v20170531.

Between jenkins-test-harness-2:56 and jenkins-test-harness:2.57 jetty version has changed from 9.4.5.v20170502 to 9.4.22.v20191022.

Setting jetty version to 9.4.6.v20170531 in maven dependencies with jenkins-test-harness:2.57 (and above) solve the issue.

JellyTestSuiteBuilder should be updated to use JenkinsRule and not the deprecated HudsonTestCase.

https://github.com/jenkinsci/jenkins-test-harness/blob/0e0ec3c9ccbe6314d488faa248e2f50f312f3cad/src/main/java/org/jvnet/hudson/test/JellyTestSuiteBuilder.java#L138

Link to maven-hpi-plugin code that generate the TestInjection class:
https://github.com/jenkinsci/maven-hpi-plugin/blob/master/src/main/java/org/jenkinsci/maven/plugins/hpi/TestInsertionMojo.java

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

jglick@cloudbees.com (JIRA)

unread,
Jan 8, 2020, 9:02:02 AM1/8/20
to jenkinsc...@googlegroups.com

jnord@cloudbees.com (JIRA)

unread,
Jan 15, 2020, 4:17:02 PM1/15/20
to jenkinsc...@googlegroups.com
James Nord commented on Bug JENKINS-60694
 
Re: JellyTestSuite fails with timeout issue on Windows runner because it uses HudsonTestCase instead of JenkinsRule

9.4.5.v20170502 -> pass

9.4.5.v20180619 -> fail

from the commits between v20170502  and v20180619  and (https://github.com/eclipse/jetty.project/commits/jetty-9.4.5.v20180619https://github.com/eclipse/jetty.project/pull/2102 looks like the prime suspect as everything else looks like a bit of build fluff

jnord@cloudbees.com (JIRA)

unread,
Jan 15, 2020, 4:18:02 PM1/15/20
to jenkinsc...@googlegroups.com

jglick@cloudbees.com (JIRA)

unread,
Jan 16, 2020, 5:32:02 PM1/16/20
to jenkinsc...@googlegroups.com

jglick@cloudbees.com (JIRA)

unread,
Jan 16, 2020, 5:35:03 PM1/16/20
to jenkinsc...@googlegroups.com

jglick@cloudbees.com (JIRA)

unread,
Jan 16, 2020, 5:35:03 PM1/16/20
to jenkinsc...@googlegroups.com
Jesse Glick started work on Bug JENKINS-60694
 
Change By: Jesse Glick
Status: Open In Progress

jglick@cloudbees.com (JIRA)

unread,
Jan 16, 2020, 7:07:02 PM1/16/20
to jenkinsc...@googlegroups.com
Change By: Jesse Glick
Status: In Review Fixed but Unreleased
Resolution: Fixed
Released As: jenkins-test-harness 2.60

jglick@cloudbees.com (JIRA)

unread,
Jan 16, 2020, 7:54:02 PM1/16/20
to jenkinsc...@googlegroups.com
Change By: Jesse Glick
Status: Fixed but Unreleased Resolved
Released As: jenkins-test-harness 2.60 , plugin 3.56
Reply all
Reply to author
Forward
0 new messages