[JIRA] (JENKINS-60644) Jenkins resource loading issue in AntClassloader. scriptsecurity.sandbox.whitelists.StaticWhitelist NoClassDefFoundError

27 views
Skip to first unread message

o.v.nenashev@gmail.com (JIRA)

unread,
Jan 6, 2020, 4:53:03 AM1/6/20
to jenkinsc...@googlegroups.com
Oleg Nenashev updated an issue
 
Jenkins / Bug JENKINS-60644
Jenkins resource loading issue in AntClassloader. scriptsecurity.sandbox.whitelists.StaticWhitelist NoClassDefFoundError
Change By: Oleg Nenashev
Summary: Jenkins resource loading issue in AntClassloader. scriptsecurity.sandbox.whitelists.StaticWhitelist NoClassDefFoundError
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

o.v.nenashev@gmail.com (JIRA)

unread,
Jan 6, 2020, 6:31:03 AM1/6/20
to jenkinsc...@googlegroups.com
Oleg Nenashev commented on Bug JENKINS-60644
 
Re: Jenkins resource loading issue in AntClassloader. scriptsecurity.sandbox.whitelists.StaticWhitelist NoClassDefFoundError

In my case the JVM just hangs when I try to reproduce this issue. Not sure why, it should not happen in this way

jglick@cloudbees.com (JIRA)

unread,
Jan 6, 2020, 8:56:03 AM1/6/20
to jenkinsc...@googlegroups.com
Jesse Glick assigned an issue to Jesse Glick
 

I was able to reproduce this just by starting Jenkins (master) on a fresh home dir, installing suggested plugins, making a trivial Pipeline job, and running it. Root cause:

java.lang.NullPointerException
	at org.jenkinsci.plugins.scriptsecurity.sandbox.whitelists.StaticWhitelist.loadBlacklist(StaticWhitelist.java:317)
	at org.jenkinsci.plugins.scriptsecurity.sandbox.whitelists.StaticWhitelist.<clinit>(StaticWhitelist.java:323)

pointing here and suggesting a resource loading problem.
Change By: Jesse Glick
Assignee: Oleg Nenashev Jesse Glick

jglick@cloudbees.com (JIRA)

unread,
Jan 6, 2020, 9:55:03 AM1/6/20
to jenkinsc...@googlegroups.com
Jesse Glick commented on Bug JENKINS-60644
 
Re: Jenkins resource loading issue in AntClassloader. scriptsecurity.sandbox.whitelists.StaticWhitelist NoClassDefFoundError

Verified that #4254 is responsible by bisecting using WorkflowPluginTest.linearFlow. So far I have not found a mistake by code inspection.

o.v.nenashev@gmail.com (JIRA)

unread,
Jan 6, 2020, 9:58:02 AM1/6/20
to jenkinsc...@googlegroups.com

Jesse Glick my theory is a race condition in the collection. The code changed from thread-safe Vector implementation to unsafe Array list. I did review the code before merging and it did not seem to be a problem, but this is my best bet at the moment

bmathus+ossjira@cloudbees.com (JIRA)

unread,
Jan 6, 2020, 10:07:04 AM1/6/20
to jenkinsc...@googlegroups.com

Could we maybe add a simple test in ATH SmokeTest set or so that would have caught this? Thanks

jglick@cloudbees.com (JIRA)

unread,
Jan 6, 2020, 10:24:04 AM1/6/20
to jenkinsc...@googlegroups.com
Jesse Glick updated an issue
 
Change By: Jesse Glick
Component/s: script-security-plugin

jglick@cloudbees.com (JIRA)

unread,
Jan 6, 2020, 10:29:03 AM1/6/20
to jenkinsc...@googlegroups.com
Jesse Glick commented on Bug JENKINS-60644
 
Re: Jenkins resource loading issue in AntClassloader. scriptsecurity.sandbox.whitelists.StaticWhitelist NoClassDefFoundError

Tracked the problem down to a bad refactoring of a loop (took me a long time to notice this in the diff!). Will try to verify the fix using JTH.

Baptiste Mathus regarding ATH @SmokeTest’s I think the issue is that they only include tests which do not use any plugins. Adding plugins to the mix would make the test run nondeterministic unless we also pinned versions rather than using the latest from the UC.

jglick@cloudbees.com (JIRA)

unread,
Jan 6, 2020, 10:54:02 AM1/6/20
to jenkinsc...@googlegroups.com

Ah and the problem only affects plugins which include some sort of library (i.e., non-hpi dependency).

jglick@cloudbees.com (JIRA)

unread,
Jan 6, 2020, 11:03:04 AM1/6/20
to jenkinsc...@googlegroups.com
Change By: Jesse Glick
Status: In Progress Review

jglick@cloudbees.com (JIRA)

unread,
Jan 6, 2020, 1:54:03 PM1/6/20
to jenkinsc...@googlegroups.com
Change By: Jesse Glick
Status: In Review Fixed but Unreleased
Resolution: Fixed
Released As: 2.213

cat.england@nfp.com (JIRA)

unread,
Jan 6, 2020, 2:15:03 PM1/6/20
to jenkinsc...@googlegroups.com

jglick@cloudbees.com (JIRA)

unread,
Jan 6, 2020, 4:16:05 PM1/6/20
to jenkinsc...@googlegroups.com

I have notified Kohsuke Kawaguchi that we would like it to be cut ASAP.

o.v.nenashev@gmail.com (JIRA)

unread,
Jan 6, 2020, 6:37:04 PM1/6/20
to jenkinsc...@googlegroups.com
Change By: Oleg Nenashev
Status: Fixed but Unreleased Resolved
Released As: Jenkins 2.213

o.v.nenashev@gmail.com (JIRA)

unread,
Jan 6, 2020, 6:42:03 PM1/6/20
to jenkinsc...@googlegroups.com

kpop@vandewiele.com (JIRA)

unread,
Jan 7, 2020, 1:25:03 AM1/7/20
to jenkinsc...@googlegroups.com
kpop commented on Bug JENKINS-60644

Many thanks for the quick response and new release. It's working fine on my installation.

alexrowe1@hotmail.co.uk (JIRA)

unread,
Jan 7, 2020, 4:36:05 AM1/7/20
to jenkinsc...@googlegroups.com

Also confirming latest release has corrected this for us
Reply all
Reply to author
Forward
0 new messages