[JIRA] (JENKINS-60420) Skip notifications plugin fails after 1.0.4 release

19 views
Skip to first unread message

michelzanini@gmail.com (JIRA)

unread,
Dec 10, 2019, 9:38:03 AM12/10/19
to jenkinsc...@googlegroups.com
Michel Zanini created an issue
 
Jenkins / Bug JENKINS-60420
Skip notifications plugin fails after 1.0.4 release
Issue Type: Bug Bug
Assignee: Alex Dubrouski
Components: skip-notifications-trait-plugin
Created: 2019-12-10 14:37
Environment: Install Gihub and Bitbucket on the same Jenkins instance
Priority: Minor Minor
Reporter: Michel Zanini

If you have Github and Bitbucket installed as plugins and you use Skip Notifications Trait you will get this error after `1.0.4` release:

 

ERROR: Found multiple extensions which provide method skipNotificationsTrait with arguments []: [[com.cloudbees.jenkins.plugins.bitbucket.notifications.SkipNotificationsTrait, org.jenkinsci.plugins.github.notifications.SkipNotificationsTrait]]
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

michelzanini@gmail.com (JIRA)

unread,
Dec 10, 2019, 9:38:04 AM12/10/19
to jenkinsc...@googlegroups.com
Michel Zanini updated an issue
Change By: Michel Zanini
If you have Github and Bitbucket installed as plugins and you use Skip Notifications Trait you will get this error after `1.0.4` release:

 
{code:java}

ERROR: Found multiple extensions which provide method skipNotificationsTrait with arguments []: [[com.cloudbees.jenkins.plugins.bitbucket.notifications.SkipNotificationsTrait, org.jenkinsci.plugins.github.notifications.SkipNotificationsTrait]]
{code}
This problem was introduced by this PR:

[https://github.com/jenkinsci/skip-notifications-trait-plugin/pull/5]

sinister@2die4.com (JIRA)

unread,
Dec 10, 2019, 12:31:03 PM12/10/19
to jenkinsc...@googlegroups.com
Alex Dubrouski commented on Bug JENKINS-60420
 
Re: Skip notifications plugin fails after 1.0.4 release

Good morning,

Thanks a lot for reporting.
I have couple of options:
1. Roll back the changes by Victor Martinez and let him create a separate plugin for GitHub Branch Source
2. I have a local snapshot which has classes and method names renamed, tried to create GitHub/BitBucket organization and it was successful

Which way will be preferable for you Michel Zanini?

sinister@2die4.com (JIRA)

unread,
Dec 10, 2019, 12:33:03 PM12/10/19
to jenkinsc...@googlegroups.com
Alex Dubrouski edited a comment on Bug JENKINS-60420
Good morning,

Thanks a lot for reporting.
I have couple of options:
1. Roll back the changes by Victor Martinez [~v2v] and let him create a separate plugin for GitHub Branch Source

2. I have a local snapshot which has classes and method names renamed, tried to create GitHub/BitBucket organization and it was successful

Which way will be preferable for you [~michelzanini]?

VictorMartinezRubio@gmail.com (JIRA)

unread,
Dec 10, 2019, 2:05:03 PM12/10/19
to jenkinsc...@googlegroups.com

 

For some reason when I created that PR I though the annotation https://github.com/jenkinsci/skip-notifications-trait-plugin/pull/5/files#diff-23463add934ca349639c9de7d8e27777R66 was intended to help with this. Good to know for the future.

 

Sorry about that, I'd say option 2) could be more beneficial. 

 

Thanks

sinister@2die4.com (JIRA)

unread,
Dec 10, 2019, 3:48:02 PM12/10/19
to jenkinsc...@googlegroups.com

Thanks for your feedback Victor, let's wait for Michel and then I will do changes and release.

michelzanini@gmail.com (JIRA)

unread,
Dec 10, 2019, 4:07:02 PM12/10/19
to jenkinsc...@googlegroups.com

I agree. Option 2 should be ok.

sinister@2die4.com (JIRA)

unread,
Dec 10, 2019, 4:28:03 PM12/10/19
to jenkinsc...@googlegroups.com

Ok, I tested locally and haven't seen any issues creating BB/GH orgs. I will release soon, could you please re-test?

sinister@2die4.com (JIRA)

unread,
Dec 10, 2019, 4:39:02 PM12/10/19
to jenkinsc...@googlegroups.com

Added you both to PR.

sinister@2die4.com (JIRA)

unread,
Dec 10, 2019, 5:27:02 PM12/10/19
to jenkinsc...@googlegroups.com

New release is published, please re-check.

michelzanini@gmail.com (JIRA)

unread,
Dec 11, 2019, 7:27:02 AM12/11/19
to jenkinsc...@googlegroups.com

Seems to work, I updated and the error is not showing up anymore. Thanks.

sinister@2die4.com (JIRA)

unread,
Dec 12, 2019, 1:41:03 PM12/12/19
to jenkinsc...@googlegroups.com
Alex Dubrouski resolved as Fixed
 

Michel reported issue as fixed. Thanks a lot for your help
Change By: Alex Dubrouski
Status: Open Resolved
Resolution: Fixed
Released As: 1.0.5

lpiedra@gmail.com (JIRA)

unread,
Mar 13, 2020, 3:44:16 AM3/13/20
to jenkinsc...@googlegroups.com
Luis Piedra-Márquez commented on Bug JENKINS-60420
 
Re: Skip notifications plugin fails after 1.0.4 release

The same is happening for me between Bitbucket and GitLab plugins:

``` javaposse.jobdsl.dsl.DslException: Found multiple extensions which provide method skipNotifications with arguments []: [[com.cloudbees.jenkins.plugins.bitbucket.notifications.SkipNotificationsTrait, io.jenkins.plugins.gitlabbranchsource.SkipNotificationsTrait]]

```

I think Bitbucket extension came first, so probably this should change in GitLab plugin. I'll open an issue.{{}}
This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)
Atlassian logo

lpiedra@gmail.com (JIRA)

unread,
Mar 13, 2020, 3:45:02 AM3/13/20
to jenkinsc...@googlegroups.com
The same is happening for me between Bitbucket and GitLab plugins:

```  { { code:java}
javaposse.jobdsl.dsl.DslException: Found multiple extensions which provide method skipNotifications with arguments []: [[com.cloudbees.jenkins.plugins.bitbucket.notifications.SkipNotificationsTrait, io.jenkins.plugins.gitlabbranchsource.SkipNotificationsTrait]] }}
 
``` {code}

I think Bitbucket extension came first, so probably this should change in GitLab plugin. I'll open an issue. \ {{}}
Reply all
Reply to author
Forward
0 new messages