[JIRA] (JENKINS-60351) can not disable the retries of Util.delete

https://github.com/jenkinsci/jenkins/blob/c8efc7c78e26f3aefad24ef4c8a161cb9a269ea3/core/src/main/java/hudson/Util.java#L1581-L1596 is confused.

Issue Type:	Bug
Assignee:	Unassigned
Components:	core
Created:	2019-12-03 14:23
Priority:	Minor
Reporter:	James Nord

The properties is for "retries" which you should be able to disable with a count of zero. but you can not. but the comment implies it is just for the number of tries (not retries).

However the code calls PathRemover.newFilteredRobustRemover(pathChecker, DELETION_MAX - 1, GC_AFTER_FAILED_DELETE, WAIT_BETWEEN_DELETION_RETRIES);
which ends up in https://github.com/jenkinsci/jenkins/blob/c8efc7c78e26f3aefad24ef4c8a161cb9a269ea3/core/src/main/java/jenkins/util/io/PathRemover.java#L63-L65 which is using a max retries.

However if you run a test with the system property set to one. then you do get one retry not one try.

-DargLine=-Dhudson.Util.maxFileDeletionRetries=1

 
                                                                 Unable to delete 'C:\Users\IEUser\Desktop\oc-server\target\tmp\j h6725733765603761727'. Tried 2 time (of a maximum of 2) waiting 0.1 sec between attempts.  
                                                            

so the property does seem to be acting as a retry despite the code comment but you can not set it to zero one because...

 
                                                                static int DELETION_MAX = Math.max(1, SystemProperties.getInteger(Util.class.getName() + ".maxFileDeletionRetries", 3));  
                                                            

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

jnord@cloudbees.com (JIRA)

unread,

Dec 3, 2019, 9:28:07 AM12/3/19

to jenkinsc...@googlegroups.com

James Nord updated an issue

Jenkins /

Change By:	James Nord

[https://github.com/jenkinsci/jenkins/blob/c8efc7c78e26f3aefad24ef4c8a161cb9a269ea3/core/src/main/java/hudson/Util.java#L1581-L1596] is confused.

The properties is for "retries" which you should be able to disable with a count of zero. but you can not. but the comment implies it is just for the number of tries (not retries).

However the code calls [{{PathRemover.newFilteredRobustRemover(pathChecker, DELETION_MAX - 1, GC_AFTER_FAILED_DELETE, WAIT_BETWEEN_DELETION_RETRIES);}}| [https://github.com/jenkinsci/jenkins/blob/c8efc7c78e26f3aefad24ef4c8a161cb9a269ea3/core/src/main/java/hudson/Util.java #L1635]]

which ends up in [https://github.com/jenkinsci/jenkins/blob/c8efc7c78e26f3aefad24ef4c8a161cb9a269ea3/core/src/main/java/jenkins/util/io/PathRemover.java#L63-L65] which is using a max retries.

However if you run a test with the system property set to one. then you do get one retry not one try.

-DargLine=-Dhudson.Util.maxFileDeletionRetries=1

{noformat}
Unable to delete 'C:\Users\IEUser\Desktop\oc-server\target\tmp\j h6725733765603761727'. Tried 2 time (of a maximum of 2) waiting 0.1 sec between attempts. {noformat}

so the property does seem to be acting as a retry despite the code comment but you can not set it to zero one because...

{noformat}
static int DELETION_MAX = Math.max(1, SystemProperties.getInteger(Util.class.getName() + ".maxFileDeletionRetries", 3)); {noformat}

and the [PathRemover|[https://github.com/jenkinsci/jenkins/blob/c8efc7c78e26f3aefad24ef4c8a161cb9a269ea3/core/src/main/java/jenkins/util/io/PathRemover.java#L64]]..

{noformat}
return new PathRemover(new PausingGCRetryStrategy(Math.max(maxRetries, 1), gcAfterFailedRemove, waitBetweenRetries), pathChecker);{noformat}

jnord@cloudbees.com (JIRA)

unread,

Dec 3, 2019, 9:29:03 AM12/3/19

to jenkinsc...@googlegroups.com

James Nord updated an issue

Jenkins /

Change By:	James Nord

[https://github.com/jenkinsci/jenkins/blob/c8efc7c78e26f3aefad24ef4c8a161cb9a269ea3/core/src/main/java/hudson/Util.java#L1581-L1596] is confused.

The properties is for "retries" which you should be able to disable with a count of zero. but you can not. but the comment implies it is just for the number of tries (not retries).

However the code calls [{{PathRemover.newFilteredRobustRemover(pathChecker, DELETION_MAX - 1, GC_AFTER_FAILED_DELETE, WAIT_BETWEEN_DELETION_RETRIES);}}|#L1635]]

which ends up in [https://github.com/jenkinsci/jenkins/blob/c8efc7c78e26f3aefad24ef4c8a161cb9a269ea3/core/src/main/java/jenkins/util/io/PathRemover.java#L63-L65] which is using a max retries.

However if you run a test with the system property set to one. then you do get one retry not one try.

-DargLine=-Dhudson.Util.maxFileDeletionRetries=1

{noformat}
Unable to delete 'C:\Users\IEUser\Desktop\oc-server\target\tmp\j h6725733765603761727'. Tried 2 time (of a maximum of 2) waiting 0.1 sec between attempts. {noformat}
so the property does seem to be acting as a retry despite the code comment but you can not set it to zero one because...
{noformat}
static int DELETION_MAX = Math.max(1, SystemProperties.getInteger(Util.class.getName() + ".maxFileDeletionRetries", 3)); {noformat}

and the [PathRemover| [https://github.com/jenkinsci/jenkins/blob/c8efc7c78e26f3aefad24ef4c8a161cb9a269ea3/core/src/main/java/jenkins/util/io/PathRemover.java #L64]]..

{noformat}
return new PathRemover(new PausingGCRetryStrategy(Math.max(maxRetries, 1), gcAfterFailedRemove, waitBetweenRetries), pathChecker);{noformat}

which means it will always retry once, which is a PITA when trying to some timing bugs.

jnord@cloudbees.com (JIRA)

unread,

Dec 3, 2019, 9:41:02 AM12/3/19

to jenkinsc...@googlegroups.com

James Nord assigned an issue to James Nord

Jenkins /

Change By:	James Nord
Assignee:	James Nord

jnord@cloudbees.com (JIRA)

unread,

Dec 3, 2019, 9:41:02 AM12/3/19

to jenkinsc...@googlegroups.com

James Nord started work on

Change By:	James Nord
Status:	Open In Progress

jnord@cloudbees.com (JIRA)

unread,

Dec 18, 2019, 11:32:02 AM12/18/19

to jenkinsc...@googlegroups.com

James Nord updated an issue

Jenkins /

Change By:	James Nord
Labels:	lts-candidate