[JIRA] (JENKINS-60275) Connecting via https with Jenkins_URL as http breaks Favicon theme element

14 views
Skip to first unread message

williambrode@gmail.com (JIRA)

unread,
Nov 25, 2019, 6:56:02 PM11/25/19
to jenkinsc...@googlegroups.com
William Brode created an issue
 
Jenkins / Bug JENKINS-60275
Connecting via https with Jenkins_URL as http breaks Favicon theme element
Issue Type: Bug Bug
Assignee: William Brode
Components: simple-theme-plugin
Created: 2019-11-25 23:55
Environment: Jenkins 2.190.2
Simple Theme Plugin 0.5.1
Priority: Minor Minor
Reporter: William Brode

We have both https and http access supported for our Jenkins instance.  We set our Jenkins Location -> Jenkins URL to the http address.  We noticed that when connecting to the instance via https, the theme element for Favicon URL wasn't functioning properly (favicon was NOT repalced).  However, using the http address to the server worked fine (the favicon was replaced).

Doing some digging I was able to find what I think was the problem (uploading a simple change did fix the issue).  Basically it was using the jenkins url to load a file in the plugin - <url>/plugin/simple-theme-plugin/simple-theme.js .  But I believe since the url was to the http address something was not allowing it (like you can't load a site without SSL from an SSL site?).  I believe the simple fix is to remove the URL since directly accessing the file should work.  I'll send a pull request with the fix.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

williambrode@gmail.com (JIRA)

unread,
Nov 26, 2019, 2:55:03 PM11/26/19
to jenkinsc...@googlegroups.com
William Brode started work on Bug JENKINS-60275
 
Change By: William Brode
Status: Open In Progress

williambrode@gmail.com (JIRA)

unread,
Nov 26, 2019, 2:55:03 PM11/26/19
to jenkinsc...@googlegroups.com

tobias-jenkins@23.gs (JIRA)

unread,
Feb 2, 2020, 10:35:02 AM2/2/20
to jenkinsc...@googlegroups.com
Tobias Gruetzmacher stopped work on Bug JENKINS-60275
 
Change By: Tobias Gruetzmacher
Status: In Progress Open

tobias-jenkins@23.gs (JIRA)

unread,
Feb 2, 2020, 10:35:03 AM2/2/20
to jenkinsc...@googlegroups.com

tobias-jenkins@23.gs (JIRA)

unread,
Feb 2, 2020, 11:45:02 AM2/2/20
to jenkinsc...@googlegroups.com

tobias-jenkins@23.gs (JIRA)

unread,
Feb 2, 2020, 2:03:03 PM2/2/20
to jenkinsc...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages