[JIRA] (JENKINS-60197) Support macOS applications upload

0 views
Skip to first unread message

michal@cirkus.com (JIRA)

unread,
Nov 18, 2019, 6:10:04 AM11/18/19
to jenkinsc...@googlegroups.com
Em Jot created an issue
 
Jenkins / Improvement JENKINS-60197
Support macOS applications upload
Issue Type: Improvement Improvement
Assignee: Mez Pahlan
Components: appcenter-plugin
Created: 2019-11-18 11:09
Labels: appcenter
Priority: Major Major
Reporter: Em Jot

MacOS applications upload is not supported right now in appcenter-plugin.

When trying to upload  "*.app.zip"  file, it doesn't pass a validation that expects only Android or iOS binary (see discussion in:
https://github.com/jenkinsci/appcenter-plugin/pull/37#issuecomment-554527091
)

It would be great to have that feature in, as that's the only major missing piece after migration from Hockey.

Thanks
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

michal@cirkus.com (JIRA)

unread,
Nov 18, 2019, 6:12:02 AM11/18/19
to jenkinsc...@googlegroups.com
Em Jot updated an issue
Change By: Em Jot
MacOS applications upload is not supported right now in appcenter-plugin.

When trying to upload  "*.app.zip"  file, it doesn't pass a validation that expects only Android or iOS binary (see discussion in:
[https://github.com/jenkinsci/appcenter-plugin/pull/37#issuecomment-554527091]
)

It would be great to have that feature in, as that's the only major missing piece after migration from Hockey.


Thanks
Add Comment Add Comment
 

mez.pahlan@gmail.com (JIRA)

unread,
Nov 18, 2019, 6:22:03 AM11/18/19
to jenkinsc...@googlegroups.com
Mez Pahlan commented on Improvement JENKINS-60197
 
Re: Support macOS applications upload

Hi Em Jot thanks for raising this. I want to confirm some details first (I'm not an IOS / MacOS developer so don't know these answers myself).

  1. AppCenter supports .app.zip, .pkg, or .dmg as types of file that can be uploaded for a MacOS app. Is that your understanding too?
  2. What about debug symbols? Do MacOS apps have this ability? Does it make sense to also add support in the debug symbols code path of the plugin?
  3. Is the debug symbol format the same as it is for IOS apps? .zip?

Many thanks.

michal@cirkus.com (JIRA)

unread,
Nov 18, 2019, 6:45:03 AM11/18/19
to jenkinsc...@googlegroups.com
Em Jot commented on Improvement JENKINS-60197

Hi Mez Pahlan,

1. Yes, that's my understanding too, I'm personally using `app.zip`. 
2. Yes, macOS apps support symbols too, so it definitely makes sense to support those.
3. Yes, it is `.zip`. 

Attaching screenshot from the old Hockey plugin configuration, maybe you will find it useful:

michal@cirkus.com (JIRA)

unread,
Nov 18, 2019, 6:45:03 AM11/18/19
to jenkinsc...@googlegroups.com
Em Jot updated an issue
Change By: Em Jot
Attachment: Screenshot 2019-11-18 at 12.42.42.png

michal@cirkus.com (JIRA)

unread,
Nov 18, 2019, 6:46:03 AM11/18/19
to jenkinsc...@googlegroups.com
Em Jot edited a comment on Improvement JENKINS-60197
Hi [~mezpahlan],


1. Yes, that's my understanding too, I'm personally using `app.zip`. 
2. Yes, macOS apps support symbols too, so it definitely makes sense to add that feature.

3. Yes, it is `.zip`. 

Attaching screenshot from the old Hockey plugin configuration, maybe you will find it useful:


!Screenshot 2019-11-18 at 12.42.42.png!

Thanks

michal@cirkus.com (JIRA)

unread,
Nov 18, 2019, 6:46:03 AM11/18/19
to jenkinsc...@googlegroups.com
Em Jot edited a comment on Improvement JENKINS-60197
Hi [~mezpahlan],

1. Yes, that's my understanding too, I'm personally using `app.zip`. 
2. Yes, macOS apps support symbols too, so it definitely makes sense to support those add that feature .

3. Yes, it is `.zip`. 

Attaching screenshot from the old Hockey plugin configuration, maybe you will find it useful:


!Screenshot 2019-11-18 at 12.42.42.png!

mez.pahlan@gmail.com (JIRA)

unread,
Nov 18, 2019, 6:53:02 AM11/18/19
to jenkinsc...@googlegroups.com

Brilliant, thank you. I will look to do this as the next feature.

mez.pahlan@gmail.com (JIRA)

unread,
Nov 18, 2019, 12:26:02 PM11/18/19
to jenkinsc...@googlegroups.com
Mez Pahlan started work on Improvement JENKINS-60197
 
Change By: Mez Pahlan
Status: Open In Progress

mez.pahlan@gmail.com (JIRA)

unread,
Nov 18, 2019, 12:43:03 PM11/18/19
to jenkinsc...@googlegroups.com

So it looks like whilst we don't officially support MacOS files we don't restrict them either. At least from the point of view of uploading the app. It's only when we try and upload debug symbols do we face an issue.

In other words, this might be easy enough to implement!

mez.pahlan@gmail.com (JIRA)

unread,
Nov 18, 2019, 1:34:02 PM11/18/19
to jenkinsc...@googlegroups.com
Change By: Mez Pahlan
Status: In Progress Review

mez.pahlan@gmail.com (JIRA)

unread,
Nov 18, 2019, 1:34:03 PM11/18/19
to jenkinsc...@googlegroups.com
Change By: Mez Pahlan
Status: In Review Fixed but Unreleased
Resolution: Fixed

michal@cirkus.com (JIRA)

unread,
Nov 18, 2019, 3:37:02 PM11/18/19
to jenkinsc...@googlegroups.com
Em Jot commented on Improvement JENKINS-60197

Great, let me know if you want me to test it Mez Pahlan.

mez.pahlan@gmail.com (JIRA)

unread,
Nov 18, 2019, 4:20:06 PM11/18/19
to jenkinsc...@googlegroups.com

I think I've added sufficient test coverage for this. But if there is any issue do let me know. I'll be doing a release tonight.

mez.pahlan@gmail.com (JIRA)

unread,
Nov 18, 2019, 4:42:07 PM11/18/19
to jenkinsc...@googlegroups.com
Change By: Mez Pahlan
Status: Fixed but Unreleased Resolved
Resolution: Fixed Done
Released As: 0.8.0

michal@cirkus.com (JIRA)

unread,
Nov 25, 2019, 4:43:02 AM11/25/19
to jenkinsc...@googlegroups.com
Em Jot commented on Improvement JENKINS-60197

It works without any issues for me. Thanks for doing a great job Mez Pahlan 
Reply all
Reply to author
Forward
0 new messages