[JIRA] (JENKINS-60128) UserAgentInterceptor generates User-Agent header with spaces in product identifier

9 views
Skip to first unread message

Kalle.Niemitalo@procomp.fi (JIRA)

unread,
Nov 11, 2019, 6:03:03 AM11/11/19
to jenkinsc...@googlegroups.com
Kalle Niemitalo created an issue
 
Jenkins / Bug JENKINS-60128
UserAgentInterceptor generates User-Agent header with spaces in product identifier
Issue Type: Bug Bug
Assignee: Kristy Hughes
Components: atlassian-bitbucket-server-integration-plugin
Created: 2019-11-11 11:02
Priority: Trivial Trivial
Reporter: Kalle Niemitalo

src/main/java/com/atlassian/bitbucket/jenkins/internal/http/HttpRequestExecutorImpl.java generates a string that is then placed in the User-Agent header field of HTTP requests:

            bbJenkinsUserAgent = "Bitbucket Jenkins Integration/" + version;

According to the specification of the User-Agent header field in RFC 7231 and the definition of token in RFC 7230, a product identifier cannot contain space characters. As the string is apparently intended to contain only one product identifier rather than three, it should instead be something like "Bitbucket-Jenkins-Integration/" + version.
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

khughes@atlassian.com (JIRA)

unread,
Nov 11, 2019, 5:36:05 PM11/11/19
to jenkinsc...@googlegroups.com
Change By: Kristy Hughes
Status: In Progress Review

khughes@atlassian.com (JIRA)

unread,
Nov 11, 2019, 5:36:06 PM11/11/19
to jenkinsc...@googlegroups.com
Kristy Hughes started work on Bug JENKINS-60128
 
Change By: Kristy Hughes
Status: Open In Progress

khughes@atlassian.com (JIRA)

unread,
Nov 11, 2019, 5:36:06 PM11/11/19
to jenkinsc...@googlegroups.com
Change By: Kristy Hughes
Status: In Review Fixed but Unreleased
Resolution: Fixed

khughes@atlassian.com (JIRA)

unread,
Nov 11, 2019, 7:21:02 PM11/11/19
to jenkinsc...@googlegroups.com
Change By: Kristy Hughes
Status: Fixed but Unreleased Closed
Released As: 1.0.2
Reply all
Reply to author
Forward
0 new messages