[JIRA] (JENKINS-60117) Rework sorting for the Enabled columns of Installed in Plugin Manager

o.v.nenashev@gmail.com (JIRA)

unread,

Nov 10, 2019, 5:30:02 AM11/10/19

to jenkinsc...@googlegroups.com

Oleg Nenashev updated an issue

Jenkins /

JENKINS-60117

Rework sorting for the Enabled columns of Installed in Plugin Manager

Change By:	Oleg Nenashev
Summary:	Rework sorting for the Uninstall Enabled columns of Installed in Plugin Manager

Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

o.v.nenashev@gmail.com (JIRA)

unread,

Nov 10, 2019, 5:31:03 AM11/10/19

to jenkinsc...@googlegroups.com

Oleg Nenashev commented on

JENKINS-60117

Re: Rework sorting for the Enabled columns of Installed in Plugin Manager

In https://github.com/jenkinsci/jenkins/pull/4298 is was suggested that the issue is fixed, but looks like it's not according to the feedback from Daniel Beck and Josh Soref. So I detached it to a separate ticket

Add Comment

kalana.16@cse.mrt.ac.lk (JIRA)

unread,

Dec 11, 2019, 6:46:03 AM12/11/19

to jenkinsc...@googlegroups.com

Kalana Wijethunga commented on

JENKINS-60117

Re: Rework sorting for the Enabled columns of Installed in Plugin Manager

Hi Oleg Nenashev,

Shall I work on this?

Add Comment

o.v.nenashev@gmail.com (JIRA)

unread,

Dec 11, 2019, 6:55:02 AM12/11/19

to jenkinsc...@googlegroups.com

Oleg Nenashev commented on

JENKINS-60117

Re: Rework sorting for the Enabled columns of Installed in Plugin Manager

Feel free to do so

Add Comment

kalana.16@cse.mrt.ac.lk (JIRA)

unread,

Dec 15, 2019, 10:51:03 PM12/15/19

to jenkinsc...@googlegroups.com

Kalana Wijethunga assigned an issue to Kalana Wijethunga

Jenkins /

JENKINS-60117

Rework sorting for the Enabled columns of Installed in Plugin Manager

Change By:	Kalana Wijethunga
Assignee:	Kalana Wijethunga

Add Comment

kalana.16@cse.mrt.ac.lk (JIRA)

unread,

Dec 16, 2019, 7:21:03 AM12/16/19

to jenkinsc...@googlegroups.com

Kalana Wijethunga updated an issue

Jenkins /

JENKINS-60117

Rework sorting for the Enabled columns of Installed in Plugin Manager

Change By:	Kalana Wijethunga
Attachment:	jenkins.jpg

Add Comment

kalana.16@cse.mrt.ac.lk (JIRA)

unread,

Dec 16, 2019, 7:23:04 AM12/16/19

to jenkinsc...@googlegroups.com

Kalana Wijethunga commented on

JENKINS-60117

Re: Rework sorting for the Enabled columns of Installed in Plugin Manager

Hi Oleg Nenashev,

I was able to reproduce the issue and I followed the same process used in https://github.com/jenkinsci/jenkins/pull/4298 to group the data rows into Enabled, Enabled and cannot disable and Disabled and add the group name to data attribute of the table data column.

I used the following logic to group these 3 categories.

Enabled - plugin.Enabled and !hasMandatoryDependencies
Enabled and cannot disable - plugin.Enabled and hasMandatoryDependencies
Disabled - If it doesnt belong to above 2 categories(essentially !plugin.Enabled should belong to this)

I am able to correctly sort by Enable column using these groups. But some of the actually enabled plugins are yielding false for plugin.Enabled and therefore they are categorized into the Disabled group, which is wrong. I cant understand why some of the actually working plugins are giving the result false for plugin.Enabled . Do you have any idea what is causing this?

I have attached a screenshot for further clarification. I have setup the checked attribute of the highlighted input tab directly from the value plugin.Enabled. You can see that it has resulted in a false

Any help would be much appreciated

Add Comment

kalana.16@cse.mrt.ac.lk (JIRA)

unread,

Dec 23, 2019, 12:12:05 PM12/23/19

to jenkinsc...@googlegroups.com

Kalana Wijethunga commented on

JENKINS-60117

Re: Rework sorting for the Enabled columns of Installed in Plugin Manager

I have achieved the following expected result.

Sorting by Enabled should sort into three sets:

Enabled (checkbox checked)
Enabled (checkbox disabled) and can't be disabled (because they're used by enabled plugins)
Disabled (checkbox unchecked)

But it can be seen that there is one more group in addition to the above and that is 'Enabled (checkbox checked) and can be disabled(because it has mandatory dependents, but all the dependents are disabled)'. I used Plugin.hasMandatoryDependencies() to check whether the plugin can be disabled or not. But seems it is incorrect in the identified case because a plugin can be disabled even if it hasMandatoryDependencies() when those dependencies are disabled. Oleg Nenashev, Daniel Beck Can somebody suggest me a better criteria to identify whether the plugins can be disabled or not, please?