[JIRA] (JENKINS-60074) Empty array returned with p4sync after 1.10.6

0 views
Skip to first unread message

kwirth@perforce.com (JIRA)

unread,
Nov 6, 2019, 12:14:03 PM11/6/19
to jenkinsc...@googlegroups.com
Karl Wirth updated an issue
 
Jenkins / Improvement JENKINS-60074
Empty array returned with p4sync after 1.10.6
Change By: Karl Wirth
Summary: No environment variables Empty array returned with p4sync after 1.10.6
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

kwirth@perforce.com (JIRA)

unread,
Nov 6, 2019, 12:19:02 PM11/6/19
to jenkinsc...@googlegroups.com
Karl Wirth updated an issue
Change By: Karl Wirth
Labels: P4_VERIFY

kwirth@perforce.com (JIRA)

unread,
Nov 6, 2019, 12:19:03 PM11/6/19
to jenkinsc...@googlegroups.com
Karl Wirth commented on Improvement JENKINS-60074
 
Re: Empty array returned with p4sync after 1.10.6

Hi Alisdair Robertson,

Thanks for highlighting this. I was easily able to reproduce this so will pass to the developers.

 

Reproduction steps

Jenkins 2.176.1

Create a Jenkins pipeline job and put the following code in the Pipeline script section:

node() {
        node {
            def scmVars = p4sync charset: 'none', credential: 'JenkinsMaster', populate: autoClean(delete: true, modtime: false, parallel: [enable: false, minbytes: '1024', minfiles: '1', threads: '4'], pin: '', quiet: false, replace: true, tidy: false), source: streamSource('//streams/main')
            echo "Result was ${scmVars}"
        }
    }

On p4-plugin 1.10.4 the result is:

[Pipeline] echo
Result was [HUDSON_CHANGELOG_FILE:/var/lib/jenkins/jobs/PipelineEditorNode/builds/8/changelog0.xml, P4_CHANGELIST:2090, P4_CLIENT:jenkins-master-PipelineEditorNode-2, P4_PORT:perforce:1666, P4_ROOT:/var/lib/jenkins/workspace/PipelineEditorNode%402, P4_TICKET:6B786DA4A0A6298A60822A383758D0C4, P4_USER:super]

On p4-plugin 1.10.6 the result set is empty:

[Pipeline] echo
Result was [:]

kwirth@perforce.com (JIRA)

unread,
Nov 6, 2019, 12:19:03 PM11/6/19
to jenkinsc...@googlegroups.com
Karl Wirth updated an issue
Change By: Karl Wirth
Priority: Minor Major

alisdair.robertson@seeingmachines.com (JIRA)

unread,
Nov 6, 2019, 7:24:02 PM11/6/19
to jenkinsc...@googlegroups.com
Alisdair Robertson commented on Improvement JENKINS-60074
 
Re: Empty array returned with p4sync after 1.10.6

Thanks for this Karl! I hope it's an easy fix.

This originally occurred for us on the latest Jenkins version (2.190.2)

pallen@perforce.com (JIRA)

unread,
Nov 8, 2019, 9:23:02 AM11/8/19
to jenkinsc...@googlegroups.com
Change By: Paul Allen
Status: In Progress Review

pallen@perforce.com (JIRA)

unread,
Nov 8, 2019, 9:23:03 AM11/8/19
to jenkinsc...@googlegroups.com
Paul Allen started work on Improvement JENKINS-60074
 
Change By: Paul Allen
Status: Open In Progress

pallen@perforce.com (JIRA)

unread,
Nov 8, 2019, 9:25:03 AM11/8/19
to jenkinsc...@googlegroups.com
Paul Allen commented on Improvement JENKINS-60074
 
Re: Empty array returned with p4sync after 1.10.6

Passes internal tests - pushed to master

It may fail CI builds as Jenkins infra has been a bit sensitive lately.

https://ci.jenkins.io/job/Plugins/job/p4-plugin/job/master/409/
Reply all
Reply to author
Forward
0 new messages