[JIRA] (JENKINS-60050) Add title into the ChangeRequestSCMHead interface

0 views
Skip to first unread message

linuxsuren@gmail.com (JIRA)

unread,
Nov 4, 2019, 7:24:03 PM11/4/19
to jenkinsc...@googlegroups.com
Rick created an issue
 
Jenkins / Improvement JENKINS-60050
Add title into the ChangeRequestSCMHead interface
Issue Type: Improvement Improvement
Assignee: Rick
Components: scm-api-plugin
Created: 2019-11-05 00:23
Priority: Minor Minor
Reporter: Rick

As we know change requests in many git providers are necessary such as GitHub, Gitlab and so on. In my use cases, users want to get the title which they might send build email base on the change request title.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

linuxsuren@gmail.com (JIRA)

unread,
Nov 4, 2019, 7:25:02 PM11/4/19
to jenkinsc...@googlegroups.com
Rick started work on Improvement JENKINS-60050
 
Change By: Rick
Status: Open In Progress

linuxsuren@gmail.com (JIRA)

unread,
Nov 4, 2019, 7:25:02 PM11/4/19
to jenkinsc...@googlegroups.com

bitwiseman@gmail.com (JIRA)

unread,
Nov 8, 2019, 10:59:02 AM11/8/19
to jenkinsc...@googlegroups.com
Liam Newman commented on Improvement JENKINS-60050
 
Re: Add title into the ChangeRequestSCMHead interface

I'm sorry, but I disagree with this change.  "ChangeRequestSCMHead" should hold the pertinent SCM information needed to build the the change and I don't see the title as part of that. 

For example, the title can change without the meaningful SCM information changing. Should the title be included in `equals()` comparisons?  If the title changes, should a new build be triggered?

I understand it would be convenient to have this information, and I even support the Title of Change requests being added to some shared interface. However, there needs to be some additional discussion of other possible places to add this information and possible effects and changes in behavior.

I'm sorry. I want to support you in making improvements to this part of the API, but I'm have concerns about this improvement as it stands.

linuxsuren@gmail.com (JIRA)

unread,
Nov 8, 2019, 9:54:04 PM11/8/19
to jenkinsc...@googlegroups.com
Rick commented on Improvement JENKINS-60050

It's not a perfect solution that putting the title into ChangeRequestSCMHead. Do you have any suggestions about how can we make a connection with it? Maybe add a new interface for the title?

Reply all
Reply to author
Forward
0 new messages