[JIRA] (JENKINS-59874) Support resource domain

6 views
Skip to first unread message

jglick@cloudbees.com (JIRA)

unread,
Oct 21, 2019, 1:27:03 PM10/21/19
to jenkinsc...@googlegroups.com
Jesse Glick created an issue
 
Jenkins / New Feature JENKINS-59874
Support resource domain
Issue Type: New Feature New Feature
Assignee: Richard Bywater
Components: htmlpublisher-plugin
Created: 2019-10-21 17:26
Priority: Major Major
Reporter: Jesse Glick

As of JENKINS-41891 in Jenkins 2.200, the way this plugin works is undesirable—much too complex, and not very functional. It should merely copy the selected files to htmlreports and then serve them via DirectoryBrowserSupport (using target="_blank" so as not to lose track of the Jenkins site) without further mutilation. No BaseHTMLAction/index, no htmlpublisher-wrapper.html generation, etc. Ideally this would be done automatically when ResourceDomainConfiguration.isResourceDomainConfigured, though currently this is a @Restricted API.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

jglick@cloudbees.com (JIRA)

unread,
Oct 21, 2019, 3:18:02 PM10/21/19
to jenkinsc...@googlegroups.com

richard@bywater.nz (JIRA)

unread,
Oct 22, 2019, 3:25:02 AM10/22/19
to jenkinsc...@googlegroups.com
Richard Bywater commented on New Feature JENKINS-59874
 
Re: Support resource domain

Jesse Glick thanks for the heads up that the Resource Domain stuff has landed. I'll take a look at it although there's a couple of things that will need to be worked through namely the fact that currently the wrapper is handling the multi-index page support and the ZIP downloads (although I'm guessing this would just be a matter of writing out the wrapper at build time rather than at runtime when the report is viewed which means that all files would be served from the resource domain).

Also I'm not sure how soon the plugin will be able to support the new resource domain functionality as, presumably, it would mean upping the minimum Jenkins requirement to the next LTS which includes it and there's still quite a large percentage of people on older versions still at the moment.

Nevertheless I'll take a look to at least be ready to support when the time comes.

jglick@cloudbees.com (JIRA)

unread,
Oct 22, 2019, 9:13:03 AM10/22/19
to jenkinsc...@googlegroups.com
Jesse Glick commented on New Feature JENKINS-59874
 
Re: Support resource domain

To be clear, my proposal is that in a suitable instance, there would be no wrapper page—just the files archived by the user. This would match the behavior of browsing a node workspace, except of course it would work after the build completes. Nor is there are any real need for a wrapper merely to support multiple index pages, as you could just create multiple sidebar links.

Up to you about jenkins.version. There is no particular reason to wait for an LTS release. According to statistics (which lag a few weeks), a fair portion of the users who are running the latest plugin version to begin with are also running a weekly.

Arguably a change like this just belongs in a separate plugin.

Reply all
Reply to author
Forward
0 new messages