[JIRA] (JENKINS-59665) Rework sorting for the Enabled and Uninstall columns of Installed in Plugin Manager

16 views
Skip to first unread message

jsoref+jenkins@gmail.com (JIRA)

unread,
Oct 4, 2019, 2:28:02 PM10/4/19
to jenkinsc...@googlegroups.com
Josh Soref updated an issue
 
Jenkins / Improvement JENKINS-59665
Rework sorting for the Enabled and Uninstall columns of Installed in Plugin Manager
Change By: Josh Soref
open /pluginManager/installed (Jenkins 2.198)

Have:
# a couple of plugins with dependencies (enabled)
# a couple of plugins (disabled)
# a couple of plugins that have never been upgraded
# a couple of plugins which have been upgraded

h3. Actual results

I can't really explain what it's doing. – It appears to be stable (i.e. toggling the sort direction for one of these columns reverses the sort), but it isn't global (i.e. changing the sort key to a different column, e.g. Name, and then back to the Enabled column results in a new sort).
h3. Expected results
h5. Sorting by Enabled should sort into three sets:
# Enabled (checkbox checked)

# Enabled (checkbox disabled) and can't be disabled (because they're used by enabled plugins)

# Disabled (checkbox unchecked)

h5. Sorting by Uninstall should sort into: two sets:
# Uninstall button enabled
# Uninstall button disabled
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

jsoref+jenkins@gmail.com (JIRA)

unread,
Oct 4, 2019, 2:28:02 PM10/4/19
to jenkinsc...@googlegroups.com
Josh Soref created an issue
Issue Type: Improvement Improvement
Assignee: Unassigned
Components: core
Created: 2019-10-04 18:27
Priority: Minor Minor
Reporter: Josh Soref

open /pluginManager/installed

Have:

    1. a couple of plugins with dependencies (enabled)
    1. a couple of plugins (disabled)
    1. a couple of plugins that have never been upgraded
    1. a couple of plugins which have been upgraded

    Actual results

    I can't really explain what it's doing. – It appears to be stable (i.e. toggling the sort direction for one of these columns reverses the sort), but it isn't global (i.e. changing the sort key to a different column, e.g. Name, and then back to the Enabled column results in a new sort).

    Expected results

    Sorting by Enabled should sort into three sets:
    1. Enabled (checkbox checked)
    1. Enabled (checkbox disabled) and can't be disabled (because they're used by enabled plugins)
    1. Disabled (checkbox unchecked)
    Sorting by Uninstall should sort into: two sets:
    1. Uninstall button enabled
    2. Uninstall button disabled

    dbeck@cloudbees.com (JIRA)

    unread,
    Oct 12, 2019, 11:47:02 AM10/12/19
    to jenkinsc...@googlegroups.com
    Daniel Beck updated an issue
    Change By: Daniel Beck
    Labels: newbie-friendly

    jsoref+jenkins@gmail.com (JIRA)

    unread,
    Oct 12, 2019, 8:46:03 PM10/12/19
    to jenkinsc...@googlegroups.com
    Josh Soref updated an issue
    Change By: Josh Soref
    open /pluginManager/installed (Jenkins 2.198)

    Have:
    # a couple of plugins with dependencies (enabled)
    # a couple of plugins (disabled)
    # a couple of plugins that have never been upgraded
    # a couple of plugins which have been upgraded

    h3. Actual results


    I can't really explain what it's doing. – It appears to be stable (i.e. toggling the sort direction for one of these columns reverses the sort), but it isn't global (i.e. changing the sort key to a different column, e.g. Name, and then back to the Enabled column results in a new sort).
    h3. Expected results
    h5. Sorting by Enabled should sort into three sets:
    # Enabled (checkbox checked)

     # Enabled (checkbox disabled) and can't be disabled (because they're used by enabled plugins)
    # Disabled (checkbox unchecked)

    h5. Sorting by Uninstall should sort into     : two sets:

    # Uninstall button enabled
    # Uninstall button disabled

    hampp@hm.edu (JIRA)

    unread,
    Oct 16, 2019, 6:45:02 AM10/16/19
    to jenkinsc...@googlegroups.com
    Manuel Hampp assigned an issue to Manuel Hampp
    Change By: Manuel Hampp
    Assignee: Manuel Hampp

    hampp@hm.edu (JIRA)

    unread,
    Oct 16, 2019, 6:45:03 AM10/16/19
    to jenkinsc...@googlegroups.com
    Manuel Hampp started work on Improvement JENKINS-59665
     
    Change By: Manuel Hampp
    Status: Open In Progress

    hampp@hm.edu (JIRA)

    unread,
    Oct 16, 2019, 10:46:02 AM10/16/19
    to jenkinsc...@googlegroups.com
    Change By: Manuel Hampp
    Status: In Progress Review

    hampp@hm.edu (JIRA)

    unread,
    Oct 16, 2019, 10:48:02 AM10/16/19
    to jenkinsc...@googlegroups.com
    Manuel Hampp commented on Improvement JENKINS-59665
     
    Re: Rework sorting for the Enabled and Uninstall columns of Installed in Plugin Manager

    Hi,

    I fixed the sorting for the uninstall column. The enabled column already seems to work fine.

    BG

    Manuel

    pull request: https://github.com/jenkinsci/jenkins/pull/4298

    hampp@hm.edu (JIRA)

    unread,
    Oct 16, 2019, 10:48:02 AM10/16/19
    to jenkinsc...@googlegroups.com
    Manuel Hampp assigned an issue to Josh Soref
     
    Change By: Manuel Hampp
    Assignee: Manuel Hampp Josh Soref

    hampp@hm.edu (JIRA)

    unread,
    Oct 16, 2019, 10:49:01 AM10/16/19
    to jenkinsc...@googlegroups.com
    Manuel Hampp assigned an issue to Manuel Hampp
    Change By: Manuel Hampp
    Assignee: Josh Soref Manuel Hampp

    dbeck@cloudbees.com (JIRA)

    unread,
    Oct 18, 2019, 9:21:02 AM10/18/19
    to jenkinsc...@googlegroups.com
    Daniel Beck commented on Improvement JENKINS-59665
     
    Re: Rework sorting for the Enabled and Uninstall columns of Installed in Plugin Manager

    At least on Jenkins 2.190.1, the "Enabled" column does not behave.

    dbeck@cloudbees.com (JIRA)

    unread,
    Oct 18, 2019, 9:22:03 AM10/18/19
    to jenkinsc...@googlegroups.com
    Daniel Beck updated an issue
    Change By: Daniel Beck
    Attachment: Screenshot 2019-10-18 at 15.20.09.png
    Reply all
    Reply to author
    Forward
    0 new messages