[JIRA] (JENKINS-59638) Notify Testers

0 views
Skip to first unread message

niallkelly808@gmail.com (JIRA)

unread,
Oct 3, 2019, 3:45:09 AM10/3/19
to jenkinsc...@googlegroups.com
Niall Kelly created an issue
 
Jenkins / Improvement JENKINS-59638
Notify Testers
Issue Type: Improvement Improvement
Assignee: Mez Pahlan
Components: appcenter-plugin
Created: 2019-10-03 07:44
Priority: Minor Minor
Reporter: Niall Kelly

Currently the `notifyTesters` field in the `DistributeResourceTask` is hardcoded to `false` but could be easily set as a parameter when generating the `UploadTask`

 

Adding this will give developers control over whether the testers should be notified of the new release, rather than assuming that they always do not want to notify.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

mez.pahlan@gmail.com (JIRA)

unread,
Oct 4, 2019, 2:27:02 AM10/4/19
to jenkinsc...@googlegroups.com
Mez Pahlan commented on Improvement JENKINS-59638
 
Re: Notify Testers

Hi Niall Kelly Thanks for raising this. I think that this should be an optional flag and probably be defaulted to true. By optional I mean it should not be required in the @DataBoundConstructor but instead use a @DataBoundSetter. Have a look at the release notes for an example.

mez.pahlan@gmail.com (JIRA)

unread,
Oct 4, 2019, 2:31:02 AM10/4/19
to jenkinsc...@googlegroups.com
Mez Pahlan updated an issue
Change By: Mez Pahlan
Currently the `notifyTesters` field in the `DistributeResourceTask` is hardcoded to `false` but could be easily set as a parameter when generating the `UploadTask`

 

Adding this will give developers control over whether the testers should be notified of the new release, rather than assuming that they always do not want to notify.


Acceptance Criteria:
# Notify Testers can be specified in the configuration for the plugin.
# Notify Testers is optional.
# Notify Testers defaults to true.
# A test is provided to assert the status of the flag in the uploaded JSON.

mez.pahlan@gmail.com (JIRA)

unread,
Oct 7, 2019, 4:03:02 PM10/7/19
to jenkinsc...@googlegroups.com
Mez Pahlan started work on Improvement JENKINS-59638
 
Change By: Mez Pahlan
Status: Open In Progress

mez.pahlan@gmail.com (JIRA)

unread,
Oct 9, 2019, 12:05:01 PM10/9/19
to jenkinsc...@googlegroups.com
Change By: Mez Pahlan
Status: In Progress Fixed but Unreleased
Resolution: Fixed

paul.obrien@cartrawler.com (JIRA)

unread,
Oct 17, 2019, 5:42:02 AM10/17/19
to jenkinsc...@googlegroups.com
Paul O'Brien commented on Improvement JENKINS-59638
 
Re: Notify Testers

Hi Mez Pahlan Niall Kelly, thanks for raising and fixing this issue. 

Do you know when this will intended to be released? 

Cheers,
Paul

mez.pahlan@gmail.com (JIRA)

unread,
Oct 17, 2019, 6:12:04 AM10/17/19
to jenkinsc...@googlegroups.com
Mez Pahlan commented on Improvement JENKINS-59638
 
Re: Notify Testers

I'm on holiday at the moment but should get some time this weekend to release this. Thanks.

paul.obrien@cartrawler.com (JIRA)

unread,
Oct 17, 2019, 8:32:02 AM10/17/19
to jenkinsc...@googlegroups.com
Paul O'Brien commented on Improvement JENKINS-59638
 
Re: Notify Testers

Thanks so much Mez Pahlan

Enjoy the holiday!

mez.pahlan@gmail.com (JIRA)

unread,
Oct 20, 2019, 11:11:03 AM10/20/19
to jenkinsc...@googlegroups.com
Mez Pahlan commented on Improvement JENKINS-59638
 
Re: Notify Testers

This should be available in a few hours.

mez.pahlan@gmail.com (JIRA)

unread,
Oct 20, 2019, 11:11:03 AM10/20/19
to jenkinsc...@googlegroups.com
Change By: Mez Pahlan
Status: Fixed but Unreleased Resolved
Released As: 0.7.0

paul.obrien@cartrawler.com (JIRA)

unread,
Oct 21, 2019, 9:51:05 AM10/21/19
to jenkinsc...@googlegroups.com
Paul O'Brien commented on Improvement JENKINS-59638
 
Re: Notify Testers

Mez Pahlan, have tested and working as expected. Thanks for this 

mez.pahlan@gmail.com (JIRA)

unread,
Oct 21, 2019, 10:22:01 AM10/21/19
to jenkinsc...@googlegroups.com
Mez Pahlan commented on Improvement JENKINS-59638
 
Re: Notify Testers

You're welcome, it was really thanks to Niall Kelly for the fix!

Reply all
Reply to author
Forward
0 new messages