[JIRA] (JENKINS-59600) Promotion logs not accessible anymore after Jenkins upgrade

[dirk.heinrichs@recommind.com (JIRA)]

Dirk Heinrichs created an issue

Jenkins / JENKINS-59600 Promotion logs not accessible anymore after Jenkins upgrade Issue Type: Bug Assignee: Unassigned Components: core Created: 2019-10-01 07:00 Environment: Linux Priority: Major Reporter: Dirk Heinrichs After update from 2.73.3 to 2.190.1, we can't access promotion logs anymore. While the link looks correct, Jenkins now shows the log of the promoted build instead of the promotion log. Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[jake.price@gmail.com (JIRA)]

Jake Price commented on JENKINS-59600

Re: Promotion logs not accessible anymore after Jenkins upgrade Facing the same issue as well which has made it difficult to troubleshoot promotion failures.

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck commented on JENKINS-59600

Re: Promotion logs not accessible anymore after Jenkins upgrade

This is probably either a security fix in 2.138.4 or 2.176.2. The Jenkins system log should include a relevant message.

Add Comment

[dirk.heinrichs@recommind.com (JIRA)]

Dirk Heinrichs commented on JENKINS-59600

Re: Promotion logs not accessible anymore after Jenkins upgrade

This one, maybe? Use of toString() on hudson.util.Secret from org.apache.commons.jelly.expression.ExpressionSupport.evaluateAsString(ExpressionSupport.java:53). Prefer getPlainText() or getEncryptedValue() depending your needs. see https://jenkins.io/redirect/hudson.util.Secret/

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck commented on JENKINS-59600

Re: Promotion logs not accessible anymore after Jenkins upgrade

https://jenkins.io/doc/upgrade-guide/2.138/#SECURITY-595 or https://jenkins.io/doc/upgrade-guide/2.176/#SECURITY-534 would be my guess.

Add Comment

[dirk.heinrichs@recommind.com (JIRA)]

Dirk Heinrichs commented on JENKINS-59600

Re: Promotion logs not accessible anymore after Jenkins upgrade

Neither warnings mentioned under above links show up in the log here when I try to view a promotion log.

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck commented on JENKINS-59600

Re: Promotion logs not accessible anymore after Jenkins upgrade

Interesting. This might be related to a change in Jenkins 2.138.2 that should not have any side effects. Unfortunately these versions are so old that it's no longer straightforward to set up a new Jenkins instance with all the required dependencies from scratch. Ideally someone here can confirm it works in 2.138.1 (or 2.146) and does no longer work in 2.138.2 (or 2.147).

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck commented on JENKINS-59600

Re: Promotion logs not accessible anymore after Jenkins upgrade

Confirmed broke in 2.138.2 (which is interestingly older than the minimum version for current releases of 2.138.4, so manual or automated testing before release should have caught this).

Add Comment

[jake.price@gmail.com (JIRA)]

Jake Price commented on JENKINS-59600

Re: Promotion logs not accessible anymore after Jenkins upgrade

For what it's worth my upgrade path to 2.190.1 looked like this:   2.164.3 (promotion logs working) -> 2.190.1 (broken) I had to roll back and rolled back to 2.176.1 where it is once again working.  2.176.3 gave me LDAP plugin issues so that is why 2.176.1 was chosen.

Add Comment

[jake.price@gmail.com (JIRA)]

Jake Price edited a comment on JENKINS-59600

[jake.price@gmail.com (JIRA)]

[dbeck@cloudbees.com (JIRA)]

Daniel Beck started work on JENKINS-59600

Change By: Daniel Beck Status: Open In Progress

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck updated JENKINS-59600

Jenkins / JENKINS-59600

Promotion logs not accessible anymore after Jenkins upgrade

Change By: Daniel Beck Status: In Progress Review

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck commented on JENKINS-59600

Re: Promotion logs not accessible anymore after Jenkins upgrade PR with fix up at https://github.com/jenkinsci/promoted-builds-plugin/pull/140

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck updated an issue

Jenkins / JENKINS-59600

Promotion logs not accessible anymore after Jenkins upgrade

Change By: Daniel Beck Component/s: promoted-builds-plugin Component/s: core

Add Comment

[dbeck@cloudbees.com (JIRA)]

Daniel Beck commented on JENKINS-59600

Re: Promotion logs not accessible anymore after Jenkins upgrade

2.164.3 (promotion logs working) -> 2.190.1 (broken)

Based on Filipe's analysis in a comment to JENKINS-58337 that's probably only because you're changing versions of both core and plugins here. The problem was introduced in Jenkins 2.138.2/2.147 and integrated into the plugin in 3.3.

Add Comment

[o.v.nenashev@gmail.com (JIRA)]

Oleg Nenashev updated JENKINS-59600

Thanks to Daniel Beck, the fix was released in 3.4: https://github.com/jenkinsci/promoted-builds-plugin/releases/tag/promoted-builds-3.4

Jenkins / JENKINS-59600

Promotion logs not accessible anymore after Jenkins upgrade

Change By: Oleg Nenashev Status: In Review Resolved Resolution: Fixed Released As: Promoted Builds 3.4

Add Comment

[jeff.dege@korterra.com (JIRA)]

Jeff Dege commented on JENKINS-59600

Re: Promotion logs not accessible anymore after Jenkins upgrade This is a show-stopper for us, I'm trying to set up promotions on a job, and I'm getting this every time I try to re-execute a promotion. Any ideas when it will be fixed? Or what I need to roll back, and how far, to get this working?

Add Comment