[JIRA] (JENKINS-59587) Groovy sandbox class loading cache cleared out by garbage collection

4 views
Skip to first unread message

dnusbaum@cloudbees.com (JIRA)

unread,
Sep 30, 2019, 11:25:02 AM9/30/19
to jenkinsc...@googlegroups.com
Devin Nusbaum created an issue
 
Jenkins / Bug JENKINS-59587
Groovy sandbox class loading cache cleared out by garbage collection
Issue Type: Bug Bug
Assignee: Devin Nusbaum
Components: script-security-plugin
Created: 2019-09-30 15:24
Labels: pipeline
Priority: Major Major
Reporter: Devin Nusbaum

A fix for memory leaks in script-security released in version 1.60 (PR 253) inadvertently caused the inner caches in SandboxResolvingClassLoader.parentClassCache (which contain the actual cached classes) to always be weakly referenced, allowing them to always be cleared out by the garbage collector, since the inner caches are never strongly referenced anywhere else. In cases where the garbage collector is running frequently, this significantly reduces the effectiveness of the cache, and can contribute to performance problems in code that uses SandboxResolvingClassLoader, such as Pipeline.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

dnusbaum@cloudbees.com (JIRA)

unread,
Oct 1, 2019, 2:03:02 PM10/1/19
to jenkinsc...@googlegroups.com
Devin Nusbaum resolved as Fixed
 

A fix for this issue was released in script-security 1.66.

Change By: Devin Nusbaum
Status: Open Resolved
Resolution: Fixed
Released As: script-security 1.66
Reply all
Reply to author
Forward
0 new messages