[JIRA] (JENKINS-59583) JunitTestsPublisher: Also set stage result

6 views
Skip to first unread message

f.modler@gmx.net (JIRA)

unread,
Sep 30, 2019, 6:43:02 AM9/30/19
to jenkinsc...@googlegroups.com
Falko Modler started work on Improvement JENKINS-59583
 
Change By: Falko Modler
Status: Open In Progress
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

f.modler@gmx.net (JIRA)

unread,
Sep 30, 2019, 6:43:02 AM9/30/19
to jenkinsc...@googlegroups.com
Falko Modler created an issue
 
Jenkins / Improvement JENKINS-59583
JunitTestsPublisher: Also set stage result
Issue Type: Improvement Improvement
Assignee: Falko Modler
Components: pipeline-maven-plugin
Created: 2019-09-30 10:42
Priority: Minor Minor
Reporter: Falko Modler

There is already a TODO in the code:

                // TODO: Once JENKINS-43995 lands, update this to set the step status instead of the entire build.
                // context.setResult(Result.UNSTABLE);
                run.setResult(Result.UNSTABLE);

Now with JENKINS-43995 done, this should be implemented via

context.get(FlowNode.class).add(new WarningAction(Result.UNSTABLE).withMessage(...)

or maybe even `addOrReplaceAction()` as in https://github.com/jenkinsci/workflow-basic-steps-plugin/blob/workflow-basic-steps-2.18/src/main/java/org/jenkinsci/plugins/workflow/steps/UnstableStep.java#L73

f.modler@gmx.net (JIRA)

unread,
Sep 30, 2019, 6:44:02 AM9/30/19
to jenkinsc...@googlegroups.com
Falko Modler updated an issue
Change By: Falko Modler
There is already a TODO in the code:

                // TODO: Once JENKINS-43995 lands, update this to set the step status instead of the entire build.
                // context.setResult(Result.UNSTABLE);
                run.setResult(Result.UNSTABLE);
{code}


Now with JENKINS-43995 done, this should be implemented via
{code:java}
context.get(FlowNode.class).add(new WarningAction(Result.UNSTABLE).withMessage(...)
{code}
or maybe even ` {{ addOrReplaceAction() ` }} as in https://github.com/jenkinsci/workflow-basic-steps-plugin/blob/workflow-basic-steps-2.18/src/main/java/org/jenkinsci/plugins/workflow/steps/UnstableStep.java#L73

f.modler@gmx.net (JIRA)

unread,
Sep 30, 2019, 11:20:05 AM9/30/19
to jenkinsc...@googlegroups.com
Falko Modler updated an issue
There is already a TODO in the code:
{code:java|title=https://github.com/jenkinsci/pipeline-maven-plugin/blob/pipeline-maven-3.8.1/jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher.java#L337-L339}
                // TODO: Once JENKINS-43995 lands, update this to set the step status instead of the entire build.
                // context.setResult(Result.UNSTABLE);
                run.setResult(Result.UNSTABLE);
{code}

Now with JENKINS-43995 done, this should be implemented via
{code:java}
context.get(FlowNode.class). add addAction (new WarningAction(Result.UNSTABLE).withMessage(...)

cleclerc@cloudbees.com (JIRA)

unread,
Oct 10, 2019, 5:49:02 PM10/10/19
to jenkinsc...@googlegroups.com
Cyrille Le Clerc closed an issue as Fixed
 

fixed in 3.8.2
Change By: Cyrille Le Clerc
Status: In Progress Closed
Resolution: Fixed
Reply all
Reply to author
Forward
0 new messages