[JIRA] (JENKINS-59560) NPE exception on pipeline checkout step (Pipeline multibranch)

0 views
Skip to first unread message

griarts@gmail.com (JIRA)

unread,
Sep 30, 2019, 10:12:02 AM9/30/19
to jenkinsc...@googlegroups.com
Artem Gryshyn updated an issue
 
Jenkins / Bug JENKINS-59560
NPE exception on pipeline checkout step (Pipeline multibranch)
Change By: Artem Gryshyn
Summary: Multibranch pipeline checkout NPE exception on pipeline checkout step (Pipeline multibranch)
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
Atlassian logo

griarts@gmail.com (JIRA)

unread,
Sep 30, 2019, 10:13:02 AM9/30/19
to jenkinsc...@googlegroups.com
Artem Gryshyn updated an issue
Multibranch pipeline jobs are failing on git checkout step after update to with the latest versions of pipeline plugins.
{code:java}
java.lang.NullPointerException at org.jenkinsci.plugins.workflow.job.WorkflowRun.onCheckout(WorkflowRun.java:836) at org.jenkinsci.plugins.workflow.job.WorkflowRun.access$1000(WorkflowRun.java:133) at org.jenkinsci.plugins.workflow.job.WorkflowRun$SCMListenerImpl.onCheckout(WorkflowRun.java:1101) at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:133) at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:91) at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:78) at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Finished: FAILURE
{code}
Multibranch pipeline job does not fail with Pipeline: SCM Step 2.7 version, next versions (2.8, 2.9) leads to fails with NPE.

This is an example of Jenkinsfile:

 
{code:java}
pipeline {
  agent none
  options {
    timeout(time: 1, unit: 'HOURS')
    buildDiscarder(logRotator(numToKeepStr: '20'))
    disableConcurrentBuilds()
    timestamps()
  }
  stages {
    stage('Build and publish') {
      agent { label 'environment/qa && java/1.8' }
      steps {
        git branch: 'test',
            url: 'g...@github.com:yourorganization/yourgit.git'
        sh 'echo test'
      }
    }
  }
}
{code}
 

 

dnusbaum@cloudbees.com (JIRA)

unread,
Jan 14, 2020, 1:19:05 PM1/14/20
to jenkinsc...@googlegroups.com
Devin Nusbaum commented on Bug JENKINS-59560
 
Re: NPE exception on pipeline checkout step (Pipeline multibranch)

Artem Gryshyn I think this is related to JENKINS-57918, but in that case, it only affected the Repo SCM. I have not heard any other reports from Git users, so maybe there is something special about your case? What version of workflow-job are you running so we can see exactly what line in WorkflowRun is throwing the NPE?

Feel free to try out https://github.com/jenkinsci/workflow-scm-step-plugin/pull/37 in your dev environment to see if it fixes the problem.

griarts@gmail.com (JIRA)

unread,
Jan 15, 2020, 4:12:07 AM1/15/20
to jenkinsc...@googlegroups.com

Devin Nusbaum tnx, your changes fixed NPE. I tested my case with multibranch pipeline and single pipeline, nothing has broken.

griarts@gmail.com (JIRA)

unread,
Jan 15, 2020, 6:47:06 AM1/15/20
to jenkinsc...@googlegroups.com

Devin Nusbaum I'm not sure I get you right, but if you mean Pipeline: Job - version is 2.35

dnusbaum@cloudbees.com (JIRA)

unread,
Jan 15, 2020, 11:33:07 AM1/15/20
to jenkinsc...@googlegroups.com

Artem Gryshyn Yes, sorry, the artifact id of the plugin is workflow-job, but the name shown to users is Pipeline: Job Plugin. What is the GitHub plugin being configured in the attached screenshot (it doesn't look like GitHub Branch Source)? That plugin should probably be updated so that it writes an empty changelog file when there are no changes instead of leaving the changelog file empty for consistency with other SCMs.

griarts@gmail.com (JIRA)

unread,
Jan 15, 2020, 11:38:08 AM1/15/20
to jenkinsc...@googlegroups.com

Devin Nusbaum this is a https://plugins.jenkins.io/github GitHub plugin, 1.29.4 version. Also used https://plugins.jenkins.io/git Git plugin, 3.12.1 version. 

Git plugin was downgraded to 3.12.1 from 4.0.0 because of dependency on "Pipeline: SCM" plugin

dnusbaum@cloudbees.com (JIRA)

unread,
Jan 15, 2020, 5:10:03 PM1/15/20
to jenkinsc...@googlegroups.com

It looks like the plugin shown in the screenshot is the GitHub Integration Plugin (https://plugins.jenkins.io/github-pullrequest), this config.jelly file in particular. Perhaps this is the problematic code in that plugin, it could return a parser that just doesn't do anything instead of null. My fix in workflow-scm-step should work fine for this particular issue though.

dnusbaum@cloudbees.com (JIRA)

unread,
Jan 15, 2020, 5:11:07 PM1/15/20
to jenkinsc...@googlegroups.com
Devin Nusbaum assigned an issue to Devin Nusbaum
 
Change By: Devin Nusbaum
Assignee: Devin Nusbaum

dnusbaum@cloudbees.com (JIRA)

unread,
Jan 15, 2020, 5:12:03 PM1/15/20
to jenkinsc...@googlegroups.com
Devin Nusbaum updated an issue
Change By: Devin Nusbaum
Component/s: github-integration-plugin
Component/s: workflow-scm-step-plugin
Component/s: workflow-multibranch-plugin

griarts@gmail.com (JIRA)

unread,
Jan 16, 2020, 5:44:07 AM1/16/20
to jenkinsc...@googlegroups.com
Artem Gryshyn commented on Bug JENKINS-59560
 
Re: NPE exception on pipeline checkout step (Pipeline multibranch)

Devin Nusbaum yes, it really does. Since I built plugin with your fix, there are no more NPE exceptions. Interesting thing that NPE is only with multibranch pipeline, single pipeline is not affected. 

Does your fix going to be implemented and issued with new version of plugin or I have to use my custom built?

griarts@gmail.com (JIRA)

unread,
Jan 16, 2020, 5:45:07 AM1/16/20
to jenkinsc...@googlegroups.com
Artem Gryshyn edited a comment on Bug JENKINS-59560
[~dnusbaum] yes, it really does. Since I built plugin with your fix, there are no more NPE exceptions. Interesting thing that NPE is only with multibranch pipeline, single pipeline is not affected. 

Does your fix going to be implemented and issued with new version of plugin or I have to use my custom built build ?

dnusbaum@cloudbees.com (JIRA)

unread,
Jan 16, 2020, 9:57:07 AM1/16/20
to jenkinsc...@googlegroups.com

Artem Gryshyn I would like to add some automated tests before I merge the change, but I will try to get a release out with my fix in the next few weeks. 

dnusbaum@cloudbees.com (JIRA)

unread,
Jan 22, 2020, 5:15:04 PM1/22/20
to jenkinsc...@googlegroups.com
Devin Nusbaum resolved as Fixed
 

A fix for this issue was just release in Pipeline: SCM Step Plugin version 2.10.
Change By: Devin Nusbaum
Status: Open Resolved
Resolution: Fixed
Released As: workflow-scm-step 2.10
Reply all
Reply to author
Forward
0 new messages