[JIRA] (JENKINS-59557) Support Gitea required status checks

[davidsvantesson@gmail.com (JIRA)]

David Svantesson created an issue

Jenkins / JENKINS-59557 Support Gitea required status checks Issue Type: Improvement Assignee: Unassigned Components: gitea-plugin Created: 2019-09-27 05:23 Labels: plugin Priority: Major Reporter: David Svantesson Gitea now supports [required status checks before merge|https://github.com/go-gitea/gitea/pull/7481] and will be available in next release (Gitea 1.10.0).  However because the Gitea plugin reports status checks with the context "Pipeline/PR-#" it is not possible to choose a required status check because it will alter for each PR. The number in the end should be removed from the reported context, or at least give the option to doing so.  Add Comment

This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)

[scm@amshove.org (JIRA)]

Markus Amshove commented on JENKINS-59557

Re: Support Gitea required status checks I propose to use `Pipeline/PR-<targetbranch>` as context for PR builds, so that they give additional context when viewed within a PR.   In our case we have 2 branches which merge changes into and both need branch protection. Currently the status check shows builds for both PRs in both PRs, so we would like to discriminate based on the target branch (you can see it as a version of the product).

Add Comment

[scm@amshove.org (JIRA)]

Markus Amshove commented on JENKINS-59557

Re: Support Gitea required status checks

Also wouldn't the HEAD build also need another label? Currently for us it is the branch-name

Add Comment

[davidsvantesson@gmail.com (JIRA)]

David Svantesson commented on JENKINS-59557

Re: Support Gitea required status checks

I agree `Pipeline/PR-<targetbranch>` would be a good context. I don't understand about HEAD as that depends on what you check out. Usually tip of 'master' is considered to be 'HEAD'? It should be added there was another PR in Gitea to only have 'overall status checks'. It would still be good to change the context from Jenkins to be able to have different checks.

Add Comment

[scm@amshove.org (JIRA)]

Markus Amshove commented on JENKINS-59557

Re: Support Gitea required status checks

Currently we get the following status contexts:   HEAD (name of the branch) PR-#prnumber   So if I have a branch called `my-cool-feature`, which I open PRs for to the `master` branch and another branch called `qa`, a commit of that branch would get: `Pipeline/my-cool-feature` `Pipeline/PR-1` (the one to `master`) `Pipeline/PR-2` (the one to `qa`)   What I would need for status checks: `Pipeline/HEAD` (or something else, but not the branch name, as this wouldn't work with status checks) `Pipeline/PR-master` `Pipeline/PR-qa`     I've had a look at the plugins sourcecode and the hardest part for me is to understand how the jobname/contexntame could be decoupled, because currently the contextname is just the jobname. However, the jobname needs to still be something like PR-12345, because otherwise it isn't unique anymore

Add Comment

[davidsvantesson@gmail.com (JIRA)]

David Svantesson commented on JENKINS-59557

Re: Support Gitea required status checks

I see your point now. I think this is more clear than HEAD: `Pipeline/branch` Best would maybe be to have it configurable with possibility of using replaceable parameters, but I don't know how hard it would be to do.

Add Comment

[davidsvantesson@gmail.com (JIRA)]

David Svantesson edited a comment on JENKINS-59557

Re: Support Gitea required status checks

I see your point now. I think this is more clear than HEAD:

`Pipeline/branch`    (exactly like that, not the branch name)

Best would maybe be to have it configurable with possibility of using replaceable parameters, but I don't know how hard it would be to do.

Add Comment

[scm@amshove.org (JIRA)]

Markus Amshove commented on JENKINS-59557

Re: Support Gitea required status checks

I've created a PR to solve this issue. I'm open for options or adoption of the context names

Add Comment